Re: [PATCH 5.3] mwifiex: fix 802.11n/WPA detection

2019-07-30 Thread Kalle Valo
Brian Norris wrote: > Commit 63d7ef36103d ("mwifiex: Don't abort on small, spec-compliant > vendor IEs") adjusted the ieee_types_vendor_header struct, which > inadvertently messed up the offsets used in > mwifiex_is_wpa_oui_present(). Add that offset back in, mirroring >

Re: [PATCH 5.3] mwifiex: fix 802.11n/WPA detection

2019-07-30 Thread Kalle Valo
Brian Norris writes: > On Mon, Jul 29, 2019 at 9:01 AM Takashi Iwai wrote: >> This isn't seen in linux-next yet. > > Apparently not. > >> Still pending review? > > I guess? Probably mostly pending maintainer attention. Correct, I was offline for few days. > Also, Johannes already had noticed

Re: [PATCH 5.3] mwifiex: fix 802.11n/WPA detection

2019-07-29 Thread Brian Norris
On Mon, Jul 29, 2019 at 9:01 AM Takashi Iwai wrote: > This isn't seen in linux-next yet. Apparently not. > Still pending review? I guess? Probably mostly pending maintainer attention. Also, Johannes already had noticed (and privately messaged me): this patch took a while to show up on the

Re: [PATCH 5.3] mwifiex: fix 802.11n/WPA detection

2019-07-29 Thread Takashi Iwai
On Wed, 24 Jul 2019 21:46:34 +0200, Brian Norris wrote: > > Commit 63d7ef36103d ("mwifiex: Don't abort on small, spec-compliant > vendor IEs") adjusted the ieee_types_vendor_header struct, which > inadvertently messed up the offsets used in > mwifiex_is_wpa_oui_present(). Add that offset back in,

[PATCH 5.3] mwifiex: fix 802.11n/WPA detection

2019-07-24 Thread Brian Norris
Commit 63d7ef36103d ("mwifiex: Don't abort on small, spec-compliant vendor IEs") adjusted the ieee_types_vendor_header struct, which inadvertently messed up the offsets used in mwifiex_is_wpa_oui_present(). Add that offset back in, mirroring mwifiex_is_rsn_oui_present(). As it stands, commit

Re: [PATCH 5.3] mwifiex: fix 802.11n/WPA detection

2019-07-24 Thread Guenter Roeck
On 7/24/19 12:46 PM, Brian Norris wrote: Commit 63d7ef36103d ("mwifiex: Don't abort on small, spec-compliant vendor IEs") adjusted the ieee_types_vendor_header struct, which inadvertently messed up the offsets used in mwifiex_is_wpa_oui_present(). Add that offset back in, mirroring

Re: [PATCH 5.3] mwifiex: fix 802.11n/WPA detection

2019-07-24 Thread Brian Norris
On Wed, Jul 24, 2019 at 12:46:34PM -0700, Brian Norris wrote: > Fixes: 63d7ef36103d ("mwifiex: Don't abort on small, spec-compliant vendor > IEs") > Cc: > Signed-off-by: Brian Norris To add to this: unfortunately, the above went out to -stable earlier this week. So a prompt merging would be