Re: [PATCH 6/6] bcache: don't pass BIOSET_NEED_BVECS for the 'bio_set' embedded in 'cache_set'

[Christoph Hellwig]

On Wed, Dec 30, 2020 at 08:32:55AM +0800, Ming Lei wrote:
> This bioset is just for allocating bio only from bio_next_split, and it 
> needn't
> bvecs, so remove the flag.

Overly long line above.

Otherwise looks good:

Reviewed-by: Christoph Hellwig 

[PATCH 6/6] bcache: don't pass BIOSET_NEED_BVECS for the 'bio_set' embedded in 'cache_set'

[Ming Lei]

This bioset is just for allocating bio only from bio_next_split, and it needn't
bvecs, so remove the flag.

Cc: linux-bca...@vger.kernel.org
Cc: Coly Li 
Signed-off-by: Ming Lei 
---
 drivers/md/bcache/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index 0e06d721cd8e..61c8aafc0a32 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -1897,7 +1897,7 @@ struct cache_set *bch_cache_set_alloc(struct cache_sb *sb)
goto err;
 
if (bioset_init(>bio_split, 4, offsetof(struct bbio, bio),
-   BIOSET_NEED_BVECS|BIOSET_NEED_RESCUER))
+   BIOSET_NEED_RESCUER))
goto err;
 
c->uuids = alloc_meta_bucket_pages(GFP_KERNEL, sb);
-- 
2.28.0