Re: [PATCH 6/7] lkdtm: crash on overwriting protected pmalloc var

2018-03-07 Thread J Freyensee
On 3/7/18 5:18 AM, Igor Stoppa wrote: On 06/03/18 19:20, J Freyensee wrote: On 2/28/18 12:06 PM, Igor Stoppa wrote: [...] void __init lkdtm_perms_init(void); void lkdtm_WRITE_RO(void); void lkdtm_WRITE_RO_AFTER_INIT(void); +void lkdtm_WRITE_RO_PMALLOC(void); Does this need some

Re: [PATCH 6/7] lkdtm: crash on overwriting protected pmalloc var

2018-03-07 Thread J Freyensee
On 3/7/18 5:18 AM, Igor Stoppa wrote: On 06/03/18 19:20, J Freyensee wrote: On 2/28/18 12:06 PM, Igor Stoppa wrote: [...] void __init lkdtm_perms_init(void); void lkdtm_WRITE_RO(void); void lkdtm_WRITE_RO_AFTER_INIT(void); +void lkdtm_WRITE_RO_PMALLOC(void); Does this need some

Re: [PATCH 6/7] lkdtm: crash on overwriting protected pmalloc var

2018-03-07 Thread Igor Stoppa
On 06/03/18 19:20, J Freyensee wrote: > On 2/28/18 12:06 PM, Igor Stoppa wrote: [...] >> void __init lkdtm_perms_init(void); >> void lkdtm_WRITE_RO(void); >> void lkdtm_WRITE_RO_AFTER_INIT(void); >> +void lkdtm_WRITE_RO_PMALLOC(void); > > Does this need some sort of #ifdef too? Not

Re: [PATCH 6/7] lkdtm: crash on overwriting protected pmalloc var

2018-03-07 Thread Igor Stoppa
On 06/03/18 19:20, J Freyensee wrote: > On 2/28/18 12:06 PM, Igor Stoppa wrote: [...] >> void __init lkdtm_perms_init(void); >> void lkdtm_WRITE_RO(void); >> void lkdtm_WRITE_RO_AFTER_INIT(void); >> +void lkdtm_WRITE_RO_PMALLOC(void); > > Does this need some sort of #ifdef too? Not

Re: [PATCH 6/7] lkdtm: crash on overwriting protected pmalloc var

2018-03-06 Thread J Freyensee
On 2/28/18 12:06 PM, Igor Stoppa wrote: Verify that pmalloc read-only protection is in place: trying to overwrite a protected variable will crash the kernel. Signed-off-by: Igor Stoppa --- drivers/misc/lkdtm.h | 1 + drivers/misc/lkdtm_core.c | 3 +++

Re: [PATCH 6/7] lkdtm: crash on overwriting protected pmalloc var

2018-03-06 Thread J Freyensee
On 2/28/18 12:06 PM, Igor Stoppa wrote: Verify that pmalloc read-only protection is in place: trying to overwrite a protected variable will crash the kernel. Signed-off-by: Igor Stoppa --- drivers/misc/lkdtm.h | 1 + drivers/misc/lkdtm_core.c | 3 +++ drivers/misc/lkdtm_perms.c

Re: [PATCH 6/7] lkdtm: crash on overwriting protected pmalloc var

2018-03-06 Thread J Freyensee
On 3/6/18 9:05 AM, J Freyensee wrote:   +#ifdef CONFIG_PROTECTABLE_MEMORY +void lkdtm_WRITE_RO_PMALLOC(void) +{ +    struct gen_pool *pool; +    int *i; + +    pool = pmalloc_create_pool("pool", 0); +    if (unlikely(!pool)) { +    pr_info("Failed preparing pool for pmalloc test."); +

Re: [PATCH 6/7] lkdtm: crash on overwriting protected pmalloc var

2018-03-06 Thread J Freyensee
On 3/6/18 9:05 AM, J Freyensee wrote:   +#ifdef CONFIG_PROTECTABLE_MEMORY +void lkdtm_WRITE_RO_PMALLOC(void) +{ +    struct gen_pool *pool; +    int *i; + +    pool = pmalloc_create_pool("pool", 0); +    if (unlikely(!pool)) { +    pr_info("Failed preparing pool for pmalloc test."); +

Re: [PATCH 6/7] lkdtm: crash on overwriting protected pmalloc var

2018-03-06 Thread J Freyensee
+#ifdef CONFIG_PROTECTABLE_MEMORY +void lkdtm_WRITE_RO_PMALLOC(void) +{ + struct gen_pool *pool; + int *i; + + pool = pmalloc_create_pool("pool", 0); + if (unlikely(!pool)) { + pr_info("Failed preparing pool for pmalloc test."); + return; +

Re: [PATCH 6/7] lkdtm: crash on overwriting protected pmalloc var

2018-03-06 Thread J Freyensee
+#ifdef CONFIG_PROTECTABLE_MEMORY +void lkdtm_WRITE_RO_PMALLOC(void) +{ + struct gen_pool *pool; + int *i; + + pool = pmalloc_create_pool("pool", 0); + if (unlikely(!pool)) { + pr_info("Failed preparing pool for pmalloc test."); + return; +

[PATCH 6/7] lkdtm: crash on overwriting protected pmalloc var

2018-02-28 Thread Igor Stoppa
Verify that pmalloc read-only protection is in place: trying to overwrite a protected variable will crash the kernel. Signed-off-by: Igor Stoppa --- drivers/misc/lkdtm.h | 1 + drivers/misc/lkdtm_core.c | 3 +++ drivers/misc/lkdtm_perms.c | 28

[PATCH 6/7] lkdtm: crash on overwriting protected pmalloc var

2018-02-28 Thread Igor Stoppa
Verify that pmalloc read-only protection is in place: trying to overwrite a protected variable will crash the kernel. Signed-off-by: Igor Stoppa --- drivers/misc/lkdtm.h | 1 + drivers/misc/lkdtm_core.c | 3 +++ drivers/misc/lkdtm_perms.c | 28 3 files

Re: [PATCH 6/7] lkdtm: crash on overwriting protected pmalloc var

2018-02-24 Thread kbuild test robot
Hi Igor, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc2] [cannot apply to next-20180223] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 6/7] lkdtm: crash on overwriting protected pmalloc var

2018-02-24 Thread kbuild test robot
Hi Igor, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc2] [cannot apply to next-20180223] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH 6/7] lkdtm: crash on overwriting protected pmalloc var

2018-02-23 Thread Igor Stoppa
Verify that pmalloc read-only protection is in place: trying to overwrite a protected variable will crash the kernel. Signed-off-by: Igor Stoppa --- drivers/misc/lkdtm.h | 1 + drivers/misc/lkdtm_core.c | 3 +++ drivers/misc/lkdtm_perms.c | 28

[PATCH 6/7] lkdtm: crash on overwriting protected pmalloc var

2018-02-23 Thread Igor Stoppa
Verify that pmalloc read-only protection is in place: trying to overwrite a protected variable will crash the kernel. Signed-off-by: Igor Stoppa --- drivers/misc/lkdtm.h | 1 + drivers/misc/lkdtm_core.c | 3 +++ drivers/misc/lkdtm_perms.c | 28 3 files