Re: [PATCH 6/7] mfd: omap-usb-host: Return value is not 'const int'

2016-09-15 Thread Arnd Bergmann 
On Thursday, September 15, 2016 11:45:20 AM CEST Lee Jones wrote:
> Change from 'const int' to just 'int'.
> 
> Cc: 
> Signed-off-by: Lee Jones 
> 

Looks good, I seem to have done the same thing. Also didn't submit,
so keep your version.

I tend to include the exact warning in the changelog, which here was

drivers/mfd/omap-usb-host.c:165:18: warning: type qualifiers ignored on 
function return type [-Wignored-qualifiers]

Arnd

Re: [PATCH 6/7] mfd: omap-usb-host: Return value is not 'const int'

2016-09-15 Thread Arnd Bergmann 
On Thursday, September 15, 2016 11:45:20 AM CEST Lee Jones wrote:
> Change from 'const int' to just 'int'.
> 
> Cc: 
> Signed-off-by: Lee Jones 
> 

Looks good, I seem to have done the same thing. Also didn't submit,
so keep your version.

I tend to include the exact warning in the changelog, which here was

drivers/mfd/omap-usb-host.c:165:18: warning: type qualifiers ignored on 
function return type [-Wignored-qualifiers]

Arnd

[PATCH 6/7] mfd: omap-usb-host: Return value is not 'const int'

2016-09-15 Thread Lee Jones 
Change from 'const int' to just 'int'.

Cc: 
Signed-off-by: Lee Jones 
---
 drivers/mfd/omap-usb-host.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index 1d924d1..7aab376 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -162,7 +162,7 @@ static const char * const port_modes[] = {
  * provided port mode string as per the port_modes table.
  * If no match is found it returns -ENODEV
  */
-static const int omap_usbhs_get_dt_port_mode(const char *mode)
+static int omap_usbhs_get_dt_port_mode(const char *mode)
 {
int i;
 
-- 
2.9.3

[PATCH 6/7] mfd: omap-usb-host: Return value is not 'const int'

2016-09-15 Thread Lee Jones 
Change from 'const int' to just 'int'.

Cc: 
Signed-off-by: Lee Jones 
---
 drivers/mfd/omap-usb-host.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index 1d924d1..7aab376 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -162,7 +162,7 @@ static const char * const port_modes[] = {
  * provided port mode string as per the port_modes table.
  * If no match is found it returns -ENODEV
  */
-static const int omap_usbhs_get_dt_port_mode(const char *mode)
+static int omap_usbhs_get_dt_port_mode(const char *mode)
 {
int i;
 
-- 
2.9.3