Re: [PATCH 6/8] clk: versatile: sp810: Remove usage of CLK_IS_BASIC
Quoting Stephen Boyd (2018-12-06 13:58:56) > This flag doesn't look to be used by any code, just set in the clk init > structure and then never tested again. Remove it from this driver as it > doesn't provide any benefit. > > Cc: Linus Walleij > Signed-off-by: Stephen Boyd > --- Applied to clk-next
Re: [PATCH 6/8] clk: versatile: sp810: Remove usage of CLK_IS_BASIC
On Thu, Dec 6, 2018 at 10:59 PM Stephen Boyd wrote: > This flag doesn't look to be used by any code, just set in the clk init > structure and then never tested again. Remove it from this driver as it > doesn't provide any benefit. > > Cc: Linus Walleij > Signed-off-by: Stephen Boyd Acked-by: Linus Walleij Can't help but wonder what semantic it was supposed to have. It seems a bit vague now. Yours, Linus Walleij
Re: [PATCH 6/8] clk: versatile: sp810: Remove usage of CLK_IS_BASIC
On Thu, Dec 6, 2018 at 10:59 PM Stephen Boyd wrote: > This flag doesn't look to be used by any code, just set in the clk init > structure and then never tested again. Remove it from this driver as it > doesn't provide any benefit. > > Cc: Linus Walleij > Signed-off-by: Stephen Boyd Acked-by: Linus Walleij Can't help but wonder what semantic it was supposed to have. It seems a bit vague now. Yours, Linus Walleij
[PATCH 6/8] clk: versatile: sp810: Remove usage of CLK_IS_BASIC
This flag doesn't look to be used by any code, just set in the clk init structure and then never tested again. Remove it from this driver as it doesn't provide any benefit. Cc: Linus Walleij Signed-off-by: Stephen Boyd --- drivers/clk/versatile/clk-sp810.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/versatile/clk-sp810.c b/drivers/clk/versatile/clk-sp810.c index 1fe1e8d970cf..c2b6bb814742 100644 --- a/drivers/clk/versatile/clk-sp810.c +++ b/drivers/clk/versatile/clk-sp810.c @@ -111,7 +111,7 @@ static void __init clk_sp810_of_setup(struct device_node *node) init.name = name; init.ops = _sp810_timerclken_ops; - init.flags = CLK_IS_BASIC; + init.flags = 0; init.parent_names = parent_names; init.num_parents = num; -- Sent by a computer through tubes
[PATCH 6/8] clk: versatile: sp810: Remove usage of CLK_IS_BASIC
This flag doesn't look to be used by any code, just set in the clk init structure and then never tested again. Remove it from this driver as it doesn't provide any benefit. Cc: Linus Walleij Signed-off-by: Stephen Boyd --- drivers/clk/versatile/clk-sp810.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/versatile/clk-sp810.c b/drivers/clk/versatile/clk-sp810.c index 1fe1e8d970cf..c2b6bb814742 100644 --- a/drivers/clk/versatile/clk-sp810.c +++ b/drivers/clk/versatile/clk-sp810.c @@ -111,7 +111,7 @@ static void __init clk_sp810_of_setup(struct device_node *node) init.name = name; init.ops = _sp810_timerclken_ops; - init.flags = CLK_IS_BASIC; + init.flags = 0; init.parent_names = parent_names; init.num_parents = num; -- Sent by a computer through tubes
