[PATCH 6/8] efi/efi_test: Use memdup_user() as a cleanup

[Matt Fleming]

From: Ivan Hu 

Fix coccicheck warning which recommends to use memdup_user()

This patch fixes below coccicheck warnings:
drivers/firmware/efi/test/efi_test.c:269:8-15: WARNING opportunity for
memdup_user

Signed-off-by: Ivan Hu 
Cc: Ivan Khoronzhuk 
Cc: Ard Biesheuvel 
Signed-off-by: Matt Fleming 
---
 drivers/firmware/efi/test/efi_test.c | 10 +++---
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/firmware/efi/test/efi_test.c 
b/drivers/firmware/efi/test/efi_test.c
index bb26e12b0cfd..8cd578f62059 100644
--- a/drivers/firmware/efi/test/efi_test.c
+++ b/drivers/firmware/efi/test/efi_test.c
@@ -265,14 +265,10 @@ static long efi_runtime_set_variable(unsigned long arg)
return rv;
}
 
-   data = kmalloc(setvariable.data_size, GFP_KERNEL);
-   if (!data) {
+   data = memdup_user(setvariable.data, setvariable.data_size);
+   if (IS_ERR(data)) {
kfree(name);
-   return -ENOMEM;
-   }
-   if (copy_from_user(data, setvariable.data, setvariable.data_size)) {
-   rv = -EFAULT;
-   goto out;
+   return PTR_ERR(data);
}
 
status = efi.set_variable(name, _guid,
-- 
2.10.0

[PATCH 6/8] efi/efi_test: Use memdup_user() as a cleanup

[Matt Fleming]

From: Ivan Hu 

Fix coccicheck warning which recommends to use memdup_user()

This patch fixes below coccicheck warnings:
drivers/firmware/efi/test/efi_test.c:269:8-15: WARNING opportunity for
memdup_user

Signed-off-by: Ivan Hu 
Cc: Ivan Khoronzhuk 
Cc: Ard Biesheuvel 
Signed-off-by: Matt Fleming 
---
 drivers/firmware/efi/test/efi_test.c | 10 +++---
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/firmware/efi/test/efi_test.c 
b/drivers/firmware/efi/test/efi_test.c
index bb26e12b0cfd..8cd578f62059 100644
--- a/drivers/firmware/efi/test/efi_test.c
+++ b/drivers/firmware/efi/test/efi_test.c
@@ -265,14 +265,10 @@ static long efi_runtime_set_variable(unsigned long arg)
return rv;
}
 
-   data = kmalloc(setvariable.data_size, GFP_KERNEL);
-   if (!data) {
+   data = memdup_user(setvariable.data, setvariable.data_size);
+   if (IS_ERR(data)) {
kfree(name);
-   return -ENOMEM;
-   }
-   if (copy_from_user(data, setvariable.data, setvariable.data_size)) {
-   rv = -EFAULT;
-   goto out;
+   return PTR_ERR(data);
}
 
status = efi.set_variable(name, _guid,
-- 
2.10.0