Re: [PATCH 6/9] dt-bindings: Document rk3399 Gru/Kevin
Am Freitag, 9. Dezember 2016, 11:54:02 CET schrieb Rob Herring: > On Thu, Dec 01, 2016 at 06:27:30PM -0800, Brian Norris wrote: > > Gru is a base dev board for a family of devices, including Kevin. Both > > utilize Rockchip RK3399, and they share much of their design. > > > > Signed-off-by: Brian Norris > > --- > > > > Documentation/devicetree/bindings/arm/rockchip.txt | 20 > > 1 file changed, 20 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt > > b/Documentation/devicetree/bindings/arm/rockchip.txt index > > cc4ace6397ab..830e13f5890c 100644 > > --- a/Documentation/devicetree/bindings/arm/rockchip.txt > > +++ b/Documentation/devicetree/bindings/arm/rockchip.txt > > @@ -99,6 +99,26 @@ Rockchip platforms device tree bindings > > > > "google,veyron-speedy-rev3", "google,veyron-speedy-rev2", > > "google,veyron-speedy", "google,veyron", "rockchip,rk3288"; > > > > +- Google Gru (dev-board): > > +Required root node properties: > > + - compatible = "google,gru-rev15", "google,gru-rev14", > > +"google,gru-rev13", "google,gru-rev12", > > +"google,gru-rev11", "google,gru-rev10", > > +"google,gru-rev9", "google,gru-rev8", > > +"google,gru-rev7", "google,gru-rev6", > > +"google,gru-rev5", "google,gru-rev4", > > +"google,gru-rev3", "google,gru-rev2", > > +"google,gru", "rockchip,rk3399"; > > All of these are supposed to be specified or just one rev at a time? All of them. I.e. the devicetree is supposed to be compatible with all of those, while the bootloader determines the actual board revision and sets the choosen compatible - at least that was the way with the previous series of devices based around the rk3288 (veyron) and I think it will be the same way still. I.e. as you can see below, Kevin starts being compatible at -rev6, as (engineering) revisions before that probably had some differences on the board. > > > + > > +- Google Kevin: > > +Required root node properties: > > + - compatible = "google,kevin-rev15", "google,kevin-rev14", > > +"google,kevin-rev13", "google,kevin-rev12", > > +"google,kevin-rev11", "google,kevin-rev10", > > +"google,kevin-rev9", "google,kevin-rev8", > > +"google,kevin-rev7", "google,kevin-rev6", > > +"google,kevin", "google,gru", "rockchip,rk3399"; > > + > > > > - mqmaker MiQi: > > Required root node properties: > >- compatible = "mqmaker,miqi", "rockchip,rk3288";
Re: [PATCH 6/9] dt-bindings: Document rk3399 Gru/Kevin
On Thu, Dec 01, 2016 at 06:27:30PM -0800, Brian Norris wrote: > Gru is a base dev board for a family of devices, including Kevin. Both > utilize Rockchip RK3399, and they share much of their design. > > Signed-off-by: Brian Norris > --- > Documentation/devicetree/bindings/arm/rockchip.txt | 20 > 1 file changed, 20 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt > b/Documentation/devicetree/bindings/arm/rockchip.txt > index cc4ace6397ab..830e13f5890c 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.txt > +++ b/Documentation/devicetree/bindings/arm/rockchip.txt > @@ -99,6 +99,26 @@ Rockchip platforms device tree bindings >"google,veyron-speedy-rev3", "google,veyron-speedy-rev2", >"google,veyron-speedy", "google,veyron", "rockchip,rk3288"; > > +- Google Gru (dev-board): > +Required root node properties: > + - compatible = "google,gru-rev15", "google,gru-rev14", > + "google,gru-rev13", "google,gru-rev12", > + "google,gru-rev11", "google,gru-rev10", > + "google,gru-rev9", "google,gru-rev8", > + "google,gru-rev7", "google,gru-rev6", > + "google,gru-rev5", "google,gru-rev4", > + "google,gru-rev3", "google,gru-rev2", > + "google,gru", "rockchip,rk3399"; All of these are supposed to be specified or just one rev at a time? > + > +- Google Kevin: > +Required root node properties: > + - compatible = "google,kevin-rev15", "google,kevin-rev14", > + "google,kevin-rev13", "google,kevin-rev12", > + "google,kevin-rev11", "google,kevin-rev10", > + "google,kevin-rev9", "google,kevin-rev8", > + "google,kevin-rev7", "google,kevin-rev6", > + "google,kevin", "google,gru", "rockchip,rk3399"; > + > - mqmaker MiQi: > Required root node properties: >- compatible = "mqmaker,miqi", "rockchip,rk3288"; > -- > 2.8.0.rc3.226.g39d4020 >
Re: [PATCH 6/9] dt-bindings: Document rk3399 Gru/Kevin
Am Mittwoch, 7. Dezember 2016, 09:41:39 CET schrieb Brian Norris: > On Wed, Dec 07, 2016 at 06:12:13PM +0100, Heiko Stuebner wrote: > > Hi Brian, > > > > Am Donnerstag, 1. Dezember 2016, 18:27:30 CET schrieb Brian Norris: > > > Gru is a base dev board for a family of devices, including Kevin. Both > > > utilize Rockchip RK3399, and they share much of their design. > > > > > > Signed-off-by: Brian Norris > > > --- > > > > > > Documentation/devicetree/bindings/arm/rockchip.txt | 20 > > > > > > 1 file changed, 20 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt > > > b/Documentation/devicetree/bindings/arm/rockchip.txt index > > > cc4ace6397ab..830e13f5890c 100644 > > > --- a/Documentation/devicetree/bindings/arm/rockchip.txt > > > +++ b/Documentation/devicetree/bindings/arm/rockchip.txt > > > @@ -99,6 +99,26 @@ Rockchip platforms device tree bindings > > > > > >"google,veyron-speedy-rev3", "google,veyron-speedy-rev2", > > >"google,veyron-speedy", "google,veyron", "rockchip,rk3288"; > > > > > > +- Google Gru (dev-board): > > boards sorted alphabetically please > > > > Brian, Gru, Jaq, ... Kevin, ... > > > > While the sorting of old boards is not right yet, new boards should be > > sorted. > I got the idea that there was some attempt to group logically before > alphabetically. Like keeping board/SoC families together. But maybe not. > > I can do as you suggested, if you don't care about keeping actual > similar boards together (i.e., veyron/3288 vs gru/3399). I'd prefer a simple alphabetical sorting. I think people reading the document will know what device they have, but not necessarily the actual soc in it. At least I would look for Google Kevin primarily without thinking of the soc at first. And in general, most Rockchip boards (maybe except Google-boards) tend to follow the reference design quite closely, so it may become hard to decide when one is similar to another :-) . So best to keep it simple.
Re: [PATCH 6/9] dt-bindings: Document rk3399 Gru/Kevin
On Wed, Dec 07, 2016 at 06:12:13PM +0100, Heiko Stuebner wrote: > Hi Brian, > > Am Donnerstag, 1. Dezember 2016, 18:27:30 CET schrieb Brian Norris: > > Gru is a base dev board for a family of devices, including Kevin. Both > > utilize Rockchip RK3399, and they share much of their design. > > > > Signed-off-by: Brian Norris > > --- > > Documentation/devicetree/bindings/arm/rockchip.txt | 20 > > 1 file changed, 20 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt > > b/Documentation/devicetree/bindings/arm/rockchip.txt index > > cc4ace6397ab..830e13f5890c 100644 > > --- a/Documentation/devicetree/bindings/arm/rockchip.txt > > +++ b/Documentation/devicetree/bindings/arm/rockchip.txt > > @@ -99,6 +99,26 @@ Rockchip platforms device tree bindings > > "google,veyron-speedy-rev3", "google,veyron-speedy-rev2", > > "google,veyron-speedy", "google,veyron", "rockchip,rk3288"; > > > > +- Google Gru (dev-board): > > boards sorted alphabetically please > > Brian, Gru, Jaq, ... Kevin, ... > > While the sorting of old boards is not right yet, new boards should be sorted. I got the idea that there was some attempt to group logically before alphabetically. Like keeping board/SoC families together. But maybe not. I can do as you suggested, if you don't care about keeping actual similar boards together (i.e., veyron/3288 vs gru/3399). Brian
Re: [PATCH 6/9] dt-bindings: Document rk3399 Gru/Kevin
Hi Brian, Am Donnerstag, 1. Dezember 2016, 18:27:30 CET schrieb Brian Norris: > Gru is a base dev board for a family of devices, including Kevin. Both > utilize Rockchip RK3399, and they share much of their design. > > Signed-off-by: Brian Norris > --- > Documentation/devicetree/bindings/arm/rockchip.txt | 20 > 1 file changed, 20 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt > b/Documentation/devicetree/bindings/arm/rockchip.txt index > cc4ace6397ab..830e13f5890c 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.txt > +++ b/Documentation/devicetree/bindings/arm/rockchip.txt > @@ -99,6 +99,26 @@ Rockchip platforms device tree bindings >"google,veyron-speedy-rev3", "google,veyron-speedy-rev2", >"google,veyron-speedy", "google,veyron", "rockchip,rk3288"; > > +- Google Gru (dev-board): boards sorted alphabetically please Brian, Gru, Jaq, ... Kevin, ... While the sorting of old boards is not right yet, new boards should be sorted. Thanks Heiko > +Required root node properties: > + - compatible = "google,gru-rev15", "google,gru-rev14", > + "google,gru-rev13", "google,gru-rev12", > + "google,gru-rev11", "google,gru-rev10", > + "google,gru-rev9", "google,gru-rev8", > + "google,gru-rev7", "google,gru-rev6", > + "google,gru-rev5", "google,gru-rev4", > + "google,gru-rev3", "google,gru-rev2", > + "google,gru", "rockchip,rk3399"; > + > +- Google Kevin: > +Required root node properties: > + - compatible = "google,kevin-rev15", "google,kevin-rev14", > + "google,kevin-rev13", "google,kevin-rev12", > + "google,kevin-rev11", "google,kevin-rev10", > + "google,kevin-rev9", "google,kevin-rev8", > + "google,kevin-rev7", "google,kevin-rev6", > + "google,kevin", "google,gru", "rockchip,rk3399"; > + > - mqmaker MiQi: > Required root node properties: >- compatible = "mqmaker,miqi", "rockchip,rk3288";
[PATCH 6/9] dt-bindings: Document rk3399 Gru/Kevin
Gru is a base dev board for a family of devices, including Kevin. Both utilize Rockchip RK3399, and they share much of their design. Signed-off-by: Brian Norris --- Documentation/devicetree/bindings/arm/rockchip.txt | 20 1 file changed, 20 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt b/Documentation/devicetree/bindings/arm/rockchip.txt index cc4ace6397ab..830e13f5890c 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.txt +++ b/Documentation/devicetree/bindings/arm/rockchip.txt @@ -99,6 +99,26 @@ Rockchip platforms device tree bindings "google,veyron-speedy-rev3", "google,veyron-speedy-rev2", "google,veyron-speedy", "google,veyron", "rockchip,rk3288"; +- Google Gru (dev-board): +Required root node properties: + - compatible = "google,gru-rev15", "google,gru-rev14", +"google,gru-rev13", "google,gru-rev12", +"google,gru-rev11", "google,gru-rev10", +"google,gru-rev9", "google,gru-rev8", +"google,gru-rev7", "google,gru-rev6", +"google,gru-rev5", "google,gru-rev4", +"google,gru-rev3", "google,gru-rev2", +"google,gru", "rockchip,rk3399"; + +- Google Kevin: +Required root node properties: + - compatible = "google,kevin-rev15", "google,kevin-rev14", +"google,kevin-rev13", "google,kevin-rev12", +"google,kevin-rev11", "google,kevin-rev10", +"google,kevin-rev9", "google,kevin-rev8", +"google,kevin-rev7", "google,kevin-rev6", +"google,kevin", "google,gru", "rockchip,rk3399"; + - mqmaker MiQi: Required root node properties: - compatible = "mqmaker,miqi", "rockchip,rk3288"; -- 2.8.0.rc3.226.g39d4020
