Re: [PATCH 7/8] gpio: zynq: Fix warnings in the driver

2017-08-14 Thread Linus Walleij
On Mon, Aug 7, 2017 at 1:02 PM, Michal Simek  wrote:

> From: Nava kishore Manne 
>
> This patch fixes the below warning
> -->Block comments should align the * on each line.
> -->suspect code indent for conditional statements.
> -->Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Nava kishore Manne 
> Signed-off-by: Michal Simek 

Patch applied.

Yours,
Linus Walleij


[PATCH 7/8] gpio: zynq: Fix warnings in the driver

2017-08-07 Thread Michal Simek
From: Nava kishore Manne 

This patch fixes the below warning
-->Block comments should align the * on each line.
-->suspect code indent for conditional statements.
-->Prefer 'unsigned int' to bare use of 'unsigned'

Signed-off-by: Nava kishore Manne 
Signed-off-by: Michal Simek 
---

 drivers/gpio/gpio-zynq.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
index 2d9f27e34d31..26653bf89e58 100644
--- a/drivers/gpio/gpio-zynq.c
+++ b/drivers/gpio/gpio-zynq.c
@@ -198,10 +198,10 @@ static inline void zynq_gpio_get_bank_pin(unsigned int 
pin_num,
for (bank = 0; bank < gpio->p_data->max_bank; bank++) {
if ((pin_num >= gpio->p_data->bank_min[bank]) &&
(pin_num <= gpio->p_data->bank_max[bank])) {
-   *bank_num = bank;
-   *bank_pin_num = pin_num -
-   gpio->p_data->bank_min[bank];
-   return;
+   *bank_num = bank;
+   *bank_pin_num = pin_num -
+   gpio->p_data->bank_min[bank];
+   return;
}
}
 
@@ -751,7 +751,7 @@ static int __maybe_unused zynq_gpio_runtime_resume(struct 
device *dev)
return clk_prepare_enable(gpio->clk);
 }
 
-static int zynq_gpio_request(struct gpio_chip *chip, unsigned offset)
+static int zynq_gpio_request(struct gpio_chip *chip, unsigned int offset)
 {
int ret;
 
@@ -764,7 +764,7 @@ static int zynq_gpio_request(struct gpio_chip *chip, 
unsigned offset)
return ret < 0 ? ret : 0;
 }
 
-static void zynq_gpio_free(struct gpio_chip *chip, unsigned offset)
+static void zynq_gpio_free(struct gpio_chip *chip, unsigned int offset)
 {
pm_runtime_put(chip->parent);
 }
-- 
1.9.1