Re: [PATCH 7/8] platform/chrome: cros_ec: Add sysfs entry to set keyboard wake lid angle

2017-08-11 Thread Thierry Escande
Hi Benson, On 11/08/2017 07:29, Benson Leung wrote: +/* Keyboard wake angle control */ + +static ssize_t show_kb_wake_angle(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct ec_response_motion_sense *resp; + struct

Re: [PATCH 7/8] platform/chrome: cros_ec: Add sysfs entry to set keyboard wake lid angle

2017-08-11 Thread Thierry Escande
Hi Benson, On 11/08/2017 07:29, Benson Leung wrote: +/* Keyboard wake angle control */ + +static ssize_t show_kb_wake_angle(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct ec_response_motion_sense *resp; + struct

Re: [PATCH 7/8] platform/chrome: cros_ec: Add sysfs entry to set keyboard wake lid angle

2017-08-10 Thread Benson Leung
Hi Thierry, On Fri, Aug 11, 2017 at 12:16:49AM +0200, Thierry Escande wrote: > From: Gwendal Grignou > > This adds a sysfs attribute (/sys/class/chromeos/cros_ec/kb_wake_angle) > used to set and get the keyboard wake lid angle. This attribute is > present only if 2

Re: [PATCH 7/8] platform/chrome: cros_ec: Add sysfs entry to set keyboard wake lid angle

2017-08-10 Thread Benson Leung
Hi Thierry, On Fri, Aug 11, 2017 at 12:16:49AM +0200, Thierry Escande wrote: > From: Gwendal Grignou > > This adds a sysfs attribute (/sys/class/chromeos/cros_ec/kb_wake_angle) > used to set and get the keyboard wake lid angle. This attribute is > present only if 2 accelerometers are controlled

[PATCH 7/8] platform/chrome: cros_ec: Add sysfs entry to set keyboard wake lid angle

2017-08-10 Thread Thierry Escande
From: Gwendal Grignou This adds a sysfs attribute (/sys/class/chromeos/cros_ec/kb_wake_angle) used to set and get the keyboard wake lid angle. This attribute is present only if 2 accelerometers are controlled by the EC. This patch also moves the cros_ec features check

[PATCH 7/8] platform/chrome: cros_ec: Add sysfs entry to set keyboard wake lid angle

2017-08-10 Thread Thierry Escande
From: Gwendal Grignou This adds a sysfs attribute (/sys/class/chromeos/cros_ec/kb_wake_angle) used to set and get the keyboard wake lid angle. This attribute is present only if 2 accelerometers are controlled by the EC. This patch also moves the cros_ec features check before the device is added