[PATCH 8/8] net: stmmac: invert the logic for dumping regs

[Corentin Labbe]

It is easier to follow the logic by removing the not operator

Signed-off-by: Corentin Labbe 
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c 
b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
index aab895d..5ff6bc4 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
@@ -442,24 +442,24 @@ static void stmmac_ethtool_gregs(struct net_device *dev,
 
memset(reg_space, 0x0, REG_SPACE_SIZE);
 
-   if (!(priv->plat->has_gmac || priv->plat->has_gmac4)) {
+   if (priv->plat->has_gmac || priv->plat->has_gmac4) {
/* MAC registers */
-   for (i = 0; i < 12; i++)
+   for (i = 0; i < 55; i++)
reg_space[i] = readl(priv->ioaddr + (i * 4));
/* DMA registers */
-   for (i = 0; i < 9; i++)
-   reg_space[i + 12] =
+   for (i = 0; i < 22; i++)
+   reg_space[i + 55] =
readl(priv->ioaddr + (DMA_BUS_MODE + (i * 4)));
-   reg_space[22] = readl(priv->ioaddr + DMA_CUR_TX_BUF_ADDR);
-   reg_space[23] = readl(priv->ioaddr + DMA_CUR_RX_BUF_ADDR);
} else {
/* MAC registers */
-   for (i = 0; i < 55; i++)
+   for (i = 0; i < 12; i++)
reg_space[i] = readl(priv->ioaddr + (i * 4));
/* DMA registers */
-   for (i = 0; i < 22; i++)
-   reg_space[i + 55] =
+   for (i = 0; i < 9; i++)
+   reg_space[i + 12] =
readl(priv->ioaddr + (DMA_BUS_MODE + (i * 4)));
+   reg_space[22] = readl(priv->ioaddr + DMA_CUR_TX_BUF_ADDR);
+   reg_space[23] = readl(priv->ioaddr + DMA_CUR_RX_BUF_ADDR);
}
 }
 
-- 
2.10.2

[PATCH 8/8] net: stmmac: invert the logic for dumping regs

[Corentin Labbe]

It is easier to follow the logic by removing the not operator

Signed-off-by: Corentin Labbe 
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c 
b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
index aab895d..5ff6bc4 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
@@ -442,24 +442,24 @@ static void stmmac_ethtool_gregs(struct net_device *dev,
 
memset(reg_space, 0x0, REG_SPACE_SIZE);
 
-   if (!(priv->plat->has_gmac || priv->plat->has_gmac4)) {
+   if (priv->plat->has_gmac || priv->plat->has_gmac4) {
/* MAC registers */
-   for (i = 0; i < 12; i++)
+   for (i = 0; i < 55; i++)
reg_space[i] = readl(priv->ioaddr + (i * 4));
/* DMA registers */
-   for (i = 0; i < 9; i++)
-   reg_space[i + 12] =
+   for (i = 0; i < 22; i++)
+   reg_space[i + 55] =
readl(priv->ioaddr + (DMA_BUS_MODE + (i * 4)));
-   reg_space[22] = readl(priv->ioaddr + DMA_CUR_TX_BUF_ADDR);
-   reg_space[23] = readl(priv->ioaddr + DMA_CUR_RX_BUF_ADDR);
} else {
/* MAC registers */
-   for (i = 0; i < 55; i++)
+   for (i = 0; i < 12; i++)
reg_space[i] = readl(priv->ioaddr + (i * 4));
/* DMA registers */
-   for (i = 0; i < 22; i++)
-   reg_space[i + 55] =
+   for (i = 0; i < 9; i++)
+   reg_space[i + 12] =
readl(priv->ioaddr + (DMA_BUS_MODE + (i * 4)));
+   reg_space[22] = readl(priv->ioaddr + DMA_CUR_TX_BUF_ADDR);
+   reg_space[23] = readl(priv->ioaddr + DMA_CUR_RX_BUF_ADDR);
}
 }
 
-- 
2.10.2