Re: [PATCH RESEND] drm/ast: free correct pointer in astfb_create() error paths

2016-11-13 Thread Daniel Vetter
On Mon, Nov 14, 2016 at 02:03:59PM +1100, Andrew Donnellan wrote: > In the err_free_vram and err_release_fbi error paths in astfb_create(), we > attempt to free afbdev->sysram. The only jumps to these error paths occur > before we assign afbdev->sysram = sysram. Free sysram instead. > >

Re: [PATCH RESEND] drm/ast: free correct pointer in astfb_create() error paths

2016-11-13 Thread Daniel Vetter
On Mon, Nov 14, 2016 at 02:03:59PM +1100, Andrew Donnellan wrote: > In the err_free_vram and err_release_fbi error paths in astfb_create(), we > attempt to free afbdev->sysram. The only jumps to these error paths occur > before we assign afbdev->sysram = sysram. Free sysram instead. > >

[PATCH RESEND] drm/ast: free correct pointer in astfb_create() error paths

2016-11-13 Thread Andrew Donnellan
In the err_free_vram and err_release_fbi error paths in astfb_create(), we attempt to free afbdev->sysram. The only jumps to these error paths occur before we assign afbdev->sysram = sysram. Free sysram instead. Signed-off-by: Andrew Donnellan --- Found by

[PATCH RESEND] drm/ast: free correct pointer in astfb_create() error paths

2016-11-13 Thread Andrew Donnellan
In the err_free_vram and err_release_fbi error paths in astfb_create(), we attempt to free afbdev->sysram. The only jumps to these error paths occur before we assign afbdev->sysram = sysram. Free sysram instead. Signed-off-by: Andrew Donnellan --- Found by Coverity Scan. Compile tested only.

Re: [PATCH RESEND] drm/ast: free correct pointer in astfb_create() error paths

2016-09-19 Thread Andrew Donnellan
On 20/09/16 11:56, Andrew Donnellan wrote: In the err_free_vram and err_release_fbi error paths in astfb_create(), we attempt to free afbdev->sysram. The only jumps to these error paths occur before we assign afbdev->sysram = sysram. Free sysram instead. Signed-off-by: Andrew Donnellan

Re: [PATCH RESEND] drm/ast: free correct pointer in astfb_create() error paths

2016-09-19 Thread Andrew Donnellan
On 20/09/16 11:56, Andrew Donnellan wrote: In the err_free_vram and err_release_fbi error paths in astfb_create(), we attempt to free afbdev->sysram. The only jumps to these error paths occur before we assign afbdev->sysram = sysram. Free sysram instead. Signed-off-by: Andrew Donnellan ---

[PATCH RESEND] drm/ast: free correct pointer in astfb_create() error paths

2016-09-19 Thread Andrew Donnellan
In the err_free_vram and err_release_fbi error paths in astfb_create(), we attempt to free afbdev->sysram. The only jumps to these error paths occur before we assign afbdev->sysram = sysram. Free sysram instead. Signed-off-by: Andrew Donnellan --- Found by

[PATCH RESEND] drm/ast: free correct pointer in astfb_create() error paths

2016-09-19 Thread Andrew Donnellan
In the err_free_vram and err_release_fbi error paths in astfb_create(), we attempt to free afbdev->sysram. The only jumps to these error paths occur before we assign afbdev->sysram = sysram. Free sysram instead. Signed-off-by: Andrew Donnellan --- Found by Coverity Scan. Compile tested only.