RE: [PATCH RESEND v2 1/3] usb: chipidea: msm: Add device tree binding information

2014-02-24 Thread Peter Chen
 
> 
> On Mon, 2014-02-24 at 08:15 +, Peter Chen wrote:
> > > +CI13xxx (Chipidea) USB controllers
> > > +
> > > +Required properties:
> > > +- compatible:   should contain "qcom,ci-hdrc"
> > > +- reg:  offset and length of the register set in the memory
> map
> > > +- interrupts:   interrupt-specifier for the controller interrupt.
> > > +- usb-phy:  phandle for the PHY device
> > > +- dr_mode:  Sould be "peripheral"
> > > +
> > > + gadget@f9a55000 {
> > > + compatible = "qcom,ci-hdrc";
> > > + reg = <0xf9a55000 0x400>;
> > > + dr_mode = "peripheral";
> > > + interrupts = <0 134 0>;
> > > + usb-phy = <_otg>;
> > > + };
> > > +
> >
> > usb_otg is not a good name for the node of usb phy.
> 
> Well, this is just an example. Is this better <>?
> 

<> is better since we have ethernet, sata, pcie phy.

Peter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


RE: [PATCH RESEND v2 1/3] usb: chipidea: msm: Add device tree binding information

2014-02-24 Thread Ivan T. Ivanov
On Mon, 2014-02-24 at 08:15 +, Peter Chen wrote: 
> > +CI13xxx (Chipidea) USB controllers
> > +
> > +Required properties:
> > +- compatible:   should contain "qcom,ci-hdrc"
> > +- reg:  offset and length of the register set in the memory map
> > +- interrupts:   interrupt-specifier for the controller interrupt.
> > +- usb-phy:  phandle for the PHY device
> > +- dr_mode:  Sould be "peripheral"
> > +
> > +   gadget@f9a55000 {
> > +   compatible = "qcom,ci-hdrc";
> > +   reg = <0xf9a55000 0x400>;
> > +   dr_mode = "peripheral";
> > +   interrupts = <0 134 0>;
> > +   usb-phy = <_otg>;
> > +   };
> > +
> 
> usb_otg is not a good name for the node of usb phy.

Well, this is just an example. Is this better <>?

Regards,
Ivan


> 
> Peter
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


RE: [PATCH RESEND v2 1/3] usb: chipidea: msm: Add device tree binding information

2014-02-24 Thread Peter Chen
 
> +CI13xxx (Chipidea) USB controllers
> +
> +Required properties:
> +- compatible:   should contain "qcom,ci-hdrc"
> +- reg:  offset and length of the register set in the memory map
> +- interrupts:   interrupt-specifier for the controller interrupt.
> +- usb-phy:  phandle for the PHY device
> +- dr_mode:  Sould be "peripheral"
> +
> + gadget@f9a55000 {
> + compatible = "qcom,ci-hdrc";
> + reg = <0xf9a55000 0x400>;
> + dr_mode = "peripheral";
> + interrupts = <0 134 0>;
> + usb-phy = <_otg>;
> + };
> +

usb_otg is not a good name for the node of usb phy.

Peter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


RE: [PATCH RESEND v2 1/3] usb: chipidea: msm: Add device tree binding information

2014-02-24 Thread Peter Chen
 
 +CI13xxx (Chipidea) USB controllers
 +
 +Required properties:
 +- compatible:   should contain qcom,ci-hdrc
 +- reg:  offset and length of the register set in the memory map
 +- interrupts:   interrupt-specifier for the controller interrupt.
 +- usb-phy:  phandle for the PHY device
 +- dr_mode:  Sould be peripheral
 +
 + gadget@f9a55000 {
 + compatible = qcom,ci-hdrc;
 + reg = 0xf9a55000 0x400;
 + dr_mode = peripheral;
 + interrupts = 0 134 0;
 + usb-phy = usb_otg;
 + };
 +

usb_otg is not a good name for the node of usb phy.

Peter

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


RE: [PATCH RESEND v2 1/3] usb: chipidea: msm: Add device tree binding information

2014-02-24 Thread Ivan T. Ivanov
On Mon, 2014-02-24 at 08:15 +, Peter Chen wrote: 
  +CI13xxx (Chipidea) USB controllers
  +
  +Required properties:
  +- compatible:   should contain qcom,ci-hdrc
  +- reg:  offset and length of the register set in the memory map
  +- interrupts:   interrupt-specifier for the controller interrupt.
  +- usb-phy:  phandle for the PHY device
  +- dr_mode:  Sould be peripheral
  +
  +   gadget@f9a55000 {
  +   compatible = qcom,ci-hdrc;
  +   reg = 0xf9a55000 0x400;
  +   dr_mode = peripheral;
  +   interrupts = 0 134 0;
  +   usb-phy = usb_otg;
  +   };
  +
 
 usb_otg is not a good name for the node of usb phy.

Well, this is just an example. Is this better phy0?

Regards,
Ivan


 
 Peter
 


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


RE: [PATCH RESEND v2 1/3] usb: chipidea: msm: Add device tree binding information

2014-02-24 Thread Peter Chen
 
 
 On Mon, 2014-02-24 at 08:15 +, Peter Chen wrote:
   +CI13xxx (Chipidea) USB controllers
   +
   +Required properties:
   +- compatible:   should contain qcom,ci-hdrc
   +- reg:  offset and length of the register set in the memory
 map
   +- interrupts:   interrupt-specifier for the controller interrupt.
   +- usb-phy:  phandle for the PHY device
   +- dr_mode:  Sould be peripheral
   +
   + gadget@f9a55000 {
   + compatible = qcom,ci-hdrc;
   + reg = 0xf9a55000 0x400;
   + dr_mode = peripheral;
   + interrupts = 0 134 0;
   + usb-phy = usb_otg;
   + };
   +
 
  usb_otg is not a good name for the node of usb phy.
 
 Well, this is just an example. Is this better phy0?
 

usbphy0 is better since we have ethernet, sata, pcie phy.

Peter

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH RESEND v2 1/3] usb: chipidea: msm: Add device tree binding information

2014-02-20 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" 

Document device tree binding information as required by
the Qualcomm USB controller.

Signed-off-by: Ivan T. Ivanov 
---
 .../devicetree/bindings/usb/msm-hsusb.txt  |   17 +
 1 file changed, 17 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/msm-hsusb.txt 
b/Documentation/devicetree/bindings/usb/msm-hsusb.txt
index 5ea26c6..d4e7e41 100644
--- a/Documentation/devicetree/bindings/usb/msm-hsusb.txt
+++ b/Documentation/devicetree/bindings/usb/msm-hsusb.txt
@@ -15,3 +15,20 @@ Example EHCI controller device node:
usb-phy = <_otg>;
};
 
+CI13xxx (Chipidea) USB controllers
+
+Required properties:
+- compatible:   should contain "qcom,ci-hdrc"
+- reg:  offset and length of the register set in the memory map
+- interrupts:   interrupt-specifier for the controller interrupt.
+- usb-phy:  phandle for the PHY device
+- dr_mode:  Sould be "peripheral"
+
+   gadget@f9a55000 {
+   compatible = "qcom,ci-hdrc";
+   reg = <0xf9a55000 0x400>;
+   dr_mode = "peripheral";
+   interrupts = <0 134 0>;
+   usb-phy = <_otg>;
+   };
+
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH RESEND v2 1/3] usb: chipidea: msm: Add device tree binding information

2014-02-20 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com

Document device tree binding information as required by
the Qualcomm USB controller.

Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com
---
 .../devicetree/bindings/usb/msm-hsusb.txt  |   17 +
 1 file changed, 17 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/msm-hsusb.txt 
b/Documentation/devicetree/bindings/usb/msm-hsusb.txt
index 5ea26c6..d4e7e41 100644
--- a/Documentation/devicetree/bindings/usb/msm-hsusb.txt
+++ b/Documentation/devicetree/bindings/usb/msm-hsusb.txt
@@ -15,3 +15,20 @@ Example EHCI controller device node:
usb-phy = usb_otg;
};
 
+CI13xxx (Chipidea) USB controllers
+
+Required properties:
+- compatible:   should contain qcom,ci-hdrc
+- reg:  offset and length of the register set in the memory map
+- interrupts:   interrupt-specifier for the controller interrupt.
+- usb-phy:  phandle for the PHY device
+- dr_mode:  Sould be peripheral
+
+   gadget@f9a55000 {
+   compatible = qcom,ci-hdrc;
+   reg = 0xf9a55000 0x400;
+   dr_mode = peripheral;
+   interrupts = 0 134 0;
+   usb-phy = usb_otg;
+   };
+
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/