Re: [PATCH RFC v2 3/3] drivers: irqchip: pdc: log PDC info in FTRACE

2018-02-05 Thread Steven Rostedt
On Mon, 5 Feb 2018 15:50:48 + Lina Iyer wrote: > >diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c > >index a392380eada6..7f177ad88713 100644 > >--- a/drivers/irqchip/qcom-pdc.c > >+++ b/drivers/irqchip/qcom-pdc.c > >@@ -26,6 +26,8 @@ > > #include

Re: [PATCH RFC v2 3/3] drivers: irqchip: pdc: log PDC info in FTRACE

2018-02-05 Thread Steven Rostedt
On Mon, 5 Feb 2018 15:50:48 + Lina Iyer wrote: > >diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c > >index a392380eada6..7f177ad88713 100644 > >--- a/drivers/irqchip/qcom-pdc.c > >+++ b/drivers/irqchip/qcom-pdc.c > >@@ -26,6 +26,8 @@ > > #include > > #include > >

Re: [PATCH RFC v2 3/3] drivers: irqchip: pdc: log PDC info in FTRACE

2018-02-05 Thread Steven Rostedt
On Mon, 5 Feb 2018 15:18:46 + Lina Iyer wrote: > >Some product configurations disable debugfs. I will ask around if this > >can be dropped. > > > Memory dumps after a crash have support for FTRACE and it helps greatly > on production issues. Hence the preference for

Re: [PATCH RFC v2 3/3] drivers: irqchip: pdc: log PDC info in FTRACE

2018-02-05 Thread Steven Rostedt
On Mon, 5 Feb 2018 15:18:46 + Lina Iyer wrote: > >Some product configurations disable debugfs. I will ask around if this > >can be dropped. > > > Memory dumps after a crash have support for FTRACE and it helps greatly > on production issues. Hence the preference for FTRACE support. Note,

Re: [PATCH RFC v2 3/3] drivers: irqchip: pdc: log PDC info in FTRACE

2018-02-05 Thread Lina Iyer
Hi Steve, On Fri, Feb 02 2018 at 14:22 +, Lina Iyer wrote: From: Archana Sathyakumar Log key PDC pin configuration in FTRACE. Cc: Steven Rostedt Signed-off-by: Archana Sathyakumar Signed-off-by: Lina Iyer

Re: [PATCH RFC v2 3/3] drivers: irqchip: pdc: log PDC info in FTRACE

2018-02-05 Thread Lina Iyer
Hi Steve, On Fri, Feb 02 2018 at 14:22 +, Lina Iyer wrote: From: Archana Sathyakumar Log key PDC pin configuration in FTRACE. Cc: Steven Rostedt Signed-off-by: Archana Sathyakumar Signed-off-by: Lina Iyer --- drivers/irqchip/qcom-pdc.c | 7 ++ include/trace/events/pdc.h | 55

Re: [PATCH RFC v2 3/3] drivers: irqchip: pdc: log PDC info in FTRACE

2018-02-05 Thread Lina Iyer
On Fri, Feb 02 2018 at 23:02 +, Lina Iyer wrote: On Fri, Feb 02 2018 at 15:57 +, Thomas Gleixner wrote: On Fri, 2 Feb 2018, Lina Iyer wrote: +++ b/include/trace/events/pdc.h @@ -0,0 +1,55 @@ +/* Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. + * + * This program is

Re: [PATCH RFC v2 3/3] drivers: irqchip: pdc: log PDC info in FTRACE

2018-02-05 Thread Lina Iyer
On Fri, Feb 02 2018 at 23:02 +, Lina Iyer wrote: On Fri, Feb 02 2018 at 15:57 +, Thomas Gleixner wrote: On Fri, 2 Feb 2018, Lina Iyer wrote: +++ b/include/trace/events/pdc.h @@ -0,0 +1,55 @@ +/* Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. + * + * This program is

Re: [PATCH RFC v2 3/3] drivers: irqchip: pdc: log PDC info in FTRACE

2018-02-02 Thread Lina Iyer
On Fri, Feb 02 2018 at 15:57 +, Thomas Gleixner wrote: On Fri, 2 Feb 2018, Lina Iyer wrote: +++ b/include/trace/events/pdc.h @@ -0,0 +1,55 @@ +/* Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify

Re: [PATCH RFC v2 3/3] drivers: irqchip: pdc: log PDC info in FTRACE

2018-02-02 Thread Lina Iyer
On Fri, Feb 02 2018 at 15:57 +, Thomas Gleixner wrote: On Fri, 2 Feb 2018, Lina Iyer wrote: +++ b/include/trace/events/pdc.h @@ -0,0 +1,55 @@ +/* Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify

Re: [PATCH RFC v2 3/3] drivers: irqchip: pdc: log PDC info in FTRACE

2018-02-02 Thread Lina Iyer
On Fri, Feb 02 2018 at 16:32 +, Steven Rostedt wrote: On Fri, 2 Feb 2018 07:22:00 -0700 Lina Iyer wrote: Hi Lina, This looks really good. I have one nit below. From: Archana Sathyakumar Log key PDC pin configuration in FTRACE. Cc:

Re: [PATCH RFC v2 3/3] drivers: irqchip: pdc: log PDC info in FTRACE

2018-02-02 Thread Lina Iyer
On Fri, Feb 02 2018 at 16:32 +, Steven Rostedt wrote: On Fri, 2 Feb 2018 07:22:00 -0700 Lina Iyer wrote: Hi Lina, This looks really good. I have one nit below. From: Archana Sathyakumar Log key PDC pin configuration in FTRACE. Cc: Steven Rostedt Signed-off-by: Archana Sathyakumar

Re: [PATCH RFC v2 3/3] drivers: irqchip: pdc: log PDC info in FTRACE

2018-02-02 Thread Steven Rostedt
On Fri, 2 Feb 2018 07:22:00 -0700 Lina Iyer wrote: Hi Lina, This looks really good. I have one nit below. > From: Archana Sathyakumar > > Log key PDC pin configuration in FTRACE. > > Cc: Steven Rostedt > Signed-off-by:

Re: [PATCH RFC v2 3/3] drivers: irqchip: pdc: log PDC info in FTRACE

2018-02-02 Thread Steven Rostedt
On Fri, 2 Feb 2018 07:22:00 -0700 Lina Iyer wrote: Hi Lina, This looks really good. I have one nit below. > From: Archana Sathyakumar > > Log key PDC pin configuration in FTRACE. > > Cc: Steven Rostedt > Signed-off-by: Archana Sathyakumar > Signed-off-by: Lina Iyer > --- >

Re: [PATCH RFC v2 3/3] drivers: irqchip: pdc: log PDC info in FTRACE

2018-02-02 Thread Thomas Gleixner
On Fri, 2 Feb 2018, Lina Iyer wrote: > +++ b/include/trace/events/pdc.h > @@ -0,0 +1,55 @@ > +/* Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public

Re: [PATCH RFC v2 3/3] drivers: irqchip: pdc: log PDC info in FTRACE

2018-02-02 Thread Thomas Gleixner
On Fri, 2 Feb 2018, Lina Iyer wrote: > +++ b/include/trace/events/pdc.h > @@ -0,0 +1,55 @@ > +/* Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public

[PATCH RFC v2 3/3] drivers: irqchip: pdc: log PDC info in FTRACE

2018-02-02 Thread Lina Iyer
From: Archana Sathyakumar Log key PDC pin configuration in FTRACE. Cc: Steven Rostedt Signed-off-by: Archana Sathyakumar Signed-off-by: Lina Iyer --- drivers/irqchip/qcom-pdc.c | 7 ++

[PATCH RFC v2 3/3] drivers: irqchip: pdc: log PDC info in FTRACE

2018-02-02 Thread Lina Iyer
From: Archana Sathyakumar Log key PDC pin configuration in FTRACE. Cc: Steven Rostedt Signed-off-by: Archana Sathyakumar Signed-off-by: Lina Iyer --- drivers/irqchip/qcom-pdc.c | 7 ++ include/trace/events/pdc.h | 55 ++ 2 files changed, 62