Re: [PATCH RT v3 5/5] rcutorture: Avoid problematic critical section nesting on RT

2019-09-23 Thread Sebastian Andrzej Siewior
On 2019-09-17 11:32:11 [-0500], Scott Wood wrote: > Nice! Are the "false positives" real issues from components that are > currently blacklisted on RT, or something different? So first a little bit of infrastructure like commit d5096aa65acd0 ("sched: Mark hrtimers to expire in hard interrupt

Re: [PATCH RT v3 5/5] rcutorture: Avoid problematic critical section nesting on RT

2019-09-17 Thread Scott Wood
On Tue, 2019-09-17 at 16:50 +0200, Sebastian Andrzej Siewior wrote: > On 2019-09-17 09:36:22 [-0500], Scott Wood wrote: > > > On non-RT you can (but should not) use the counter part of the > > > function > > > in random order like: > > > local_bh_disable(); > > > local_irq_disable(); > > >

Re: [PATCH RT v3 5/5] rcutorture: Avoid problematic critical section nesting on RT

2019-09-17 Thread Sebastian Andrzej Siewior
On 2019-09-17 09:36:22 [-0500], Scott Wood wrote: > > On non-RT you can (but should not) use the counter part of the function > > in random order like: > > local_bh_disable(); > > local_irq_disable(); > > local_bh_enable(); > > local_irq_enable(); > > Actually even non-RT will

Re: [PATCH RT v3 5/5] rcutorture: Avoid problematic critical section nesting on RT

2019-09-17 Thread Scott Wood
On Tue, 2019-09-17 at 12:07 +0200, Sebastian Andrzej Siewior wrote: > On 2019-09-16 11:55:57 [-0500], Scott Wood wrote: > > On Thu, 2019-09-12 at 18:17 -0400, Joel Fernandes wrote: > > > On Wed, Sep 11, 2019 at 05:57:29PM +0100, Scott Wood wrote: > > > > rcutorture was generating some nesting

Re: [PATCH RT v3 5/5] rcutorture: Avoid problematic critical section nesting on RT

2019-09-17 Thread Sebastian Andrzej Siewior
On 2019-09-16 11:55:57 [-0500], Scott Wood wrote: > On Thu, 2019-09-12 at 18:17 -0400, Joel Fernandes wrote: > > On Wed, Sep 11, 2019 at 05:57:29PM +0100, Scott Wood wrote: > > > rcutorture was generating some nesting scenarios that are not > > > reasonable. Constrain the state selection to avoid

Re: [PATCH RT v3 5/5] rcutorture: Avoid problematic critical section nesting on RT

2019-09-16 Thread Scott Wood
On Thu, 2019-09-12 at 18:17 -0400, Joel Fernandes wrote: > On Wed, Sep 11, 2019 at 05:57:29PM +0100, Scott Wood wrote: > > rcutorture was generating some nesting scenarios that are not > > reasonable. Constrain the state selection to avoid them. > > > > Example #1: > > > > 1. preempt_disable()

Re: [PATCH RT v3 5/5] rcutorture: Avoid problematic critical section nesting on RT

2019-09-12 Thread Joel Fernandes
On Wed, Sep 11, 2019 at 05:57:29PM +0100, Scott Wood wrote: > rcutorture was generating some nesting scenarios that are not > reasonable. Constrain the state selection to avoid them. > > Example #1: > > 1. preempt_disable() > 2. local_bh_disable() > 3. preempt_enable() > 4. local_bh_enable() >

[PATCH RT v3 5/5] rcutorture: Avoid problematic critical section nesting on RT

2019-09-11 Thread Scott Wood
rcutorture was generating some nesting scenarios that are not reasonable. Constrain the state selection to avoid them. Example #1: 1. preempt_disable() 2. local_bh_disable() 3. preempt_enable() 4. local_bh_enable() On PREEMPT_RT, BH disabling takes a local lock only when called in non-atomic