Re: [PATCH V2] lib/scatterlist: Add SG_CHAIN and SG_END macros for LSB encodings

2018-02-19 Thread Andy Shevchenko
On Mon, Feb 19, 2018 at 12:10 PM, Tvrtko Ursulin wrote: > On 19/02/18 04:12, Anshuman Khandual wrote: >> On 02/18/2018 12:58 AM, kbuild test robot wrote: >>> #define SG_END 0x02 >>> In file included from include/linux/blkdev.h:28:0, >>> from drivers/staging/r

Re: [PATCH V2] lib/scatterlist: Add SG_CHAIN and SG_END macros for LSB encodings

2018-02-19 Thread Tvrtko Ursulin
On 19/02/18 04:12, Anshuman Khandual wrote: On 02/18/2018 12:58 AM, kbuild test robot wrote: Hi Anshuman, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.16-rc1 next-20180216] [if your patch is applied to the wron

Re: [PATCH V2] lib/scatterlist: Add SG_CHAIN and SG_END macros for LSB encodings

2018-02-19 Thread Johannes Thumshirn
On Mon, Feb 19, 2018 at 09:42:29AM +0530, Anshuman Khandual wrote: > SG_END is already defined in a driver. Hence shall we change back > 'SG_END' definition as 'SG_EMARK' or any other suggestions ? Yes something like this. -- Johannes Thumshirn Storage jth

Re: [PATCH V2] lib/scatterlist: Add SG_CHAIN and SG_END macros for LSB encodings

2018-02-18 Thread Anshuman Khandual
On 02/18/2018 12:58 AM, kbuild test robot wrote: > Hi Anshuman, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on linus/master] > [also build test WARNING on v4.16-rc1 next-20180216] > [if your patch is applied to the wrong git tree, please drop us a note

Re: [PATCH V2] lib/scatterlist: Add SG_CHAIN and SG_END macros for LSB encodings

2018-02-17 Thread kbuild test robot
Hi Anshuman, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.16-rc1 next-20180216] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-

Re: [PATCH V2] lib/scatterlist: Add SG_CHAIN and SG_END macros for LSB encodings

2018-02-17 Thread kbuild test robot
Hi Anshuman, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.16-rc1 next-20180216] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-

Re: [PATCH V2] lib/scatterlist: Add SG_CHAIN and SG_END macros for LSB encodings

2018-02-14 Thread Chris Wilson
Quoting Anshuman Khandual (2018-02-15 03:33:56) > This replaces scatterlist->page_link LSB encodings with SG_CHAIN and > SG_END definitions without any functional change. > > Signed-off-by: Anshuman Khandual > --- > Changes in V2: > - Changed SG_EMARK as SG_END as per Johannes and Tvrtko > - Adde

Re: [PATCH V2] lib/scatterlist: Add SG_CHAIN and SG_END macros for LSB encodings

2018-02-14 Thread Jens Axboe
On 2/14/18 8:33 PM, Anshuman Khandual wrote: > This replaces scatterlist->page_link LSB encodings with SG_CHAIN and > SG_END definitions without any functional change. Looks good to me, I'll add it for 4.17. -- Jens Axboe

[PATCH V2] lib/scatterlist: Add SG_CHAIN and SG_END macros for LSB encodings

2018-02-14 Thread Anshuman Khandual
This replaces scatterlist->page_link LSB encodings with SG_CHAIN and SG_END definitions without any functional change. Signed-off-by: Anshuman Khandual --- Changes in V2: - Changed SG_EMARK as SG_END as per Johannes and Tvrtko - Added 'UL' to the constants as per Bart include/linux/scatterlist.