[PATCH net 3/4] rxrpc: Fix checking of error from ip6_route_output()

[David Howells]

ip6_route_output() doesn't return a negative error when it fails, rather
the ->error field of the returned dst_entry struct needs to be checked.

Reported-by: Dan Carpenter 
Fixes: 75b54cb57ca3 ("rxrpc: Add IPv6 support")
Signed-off-by: David Howells 
---

 net/rxrpc/peer_object.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/rxrpc/peer_object.c b/net/rxrpc/peer_object.c
index 941b724d523b..862eea6b266c 100644
--- a/net/rxrpc/peer_object.c
+++ b/net/rxrpc/peer_object.c
@@ -193,8 +193,8 @@ static void rxrpc_assess_MTU_size(struct rxrpc_peer *peer)
fl6->fl6_dport = htons(7001);
fl6->fl6_sport = htons(7000);
dst = ip6_route_output(_net, NULL, fl6);
-   if (IS_ERR(dst)) {
-   _leave(" [route err %ld]", PTR_ERR(dst));
+   if (dst->error) {
+   _leave(" [route err %d]", dst->error);
return;
}
break;

[PATCH net 3/4] rxrpc: Fix checking of error from ip6_route_output()

[David Howells]

ip6_route_output() doesn't return a negative error when it fails, rather
the ->error field of the returned dst_entry struct needs to be checked.

Reported-by: Dan Carpenter 
Fixes: 75b54cb57ca3 ("rxrpc: Add IPv6 support")
Signed-off-by: David Howells 
---

 net/rxrpc/peer_object.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/rxrpc/peer_object.c b/net/rxrpc/peer_object.c
index 941b724d523b..862eea6b266c 100644
--- a/net/rxrpc/peer_object.c
+++ b/net/rxrpc/peer_object.c
@@ -193,8 +193,8 @@ static void rxrpc_assess_MTU_size(struct rxrpc_peer *peer)
fl6->fl6_dport = htons(7001);
fl6->fl6_sport = htons(7000);
dst = ip6_route_output(_net, NULL, fl6);
-   if (IS_ERR(dst)) {
-   _leave(" [route err %ld]", PTR_ERR(dst));
+   if (dst->error) {
+   _leave(" [route err %d]", dst->error);
return;
}
break;