Re: [PATCH v06 36/36] uapi linux/kfd_ioctl.h: use __u32 and __u64 instead of uint32_t and uint64_t

2017-09-02 Thread Oded Gabbay
On Mon, Aug 7, 2017 at 6:01 PM, Arnd Bergmann  wrote:
> On Sun, Aug 6, 2017 at 6:44 PM, Mikko Rapeli  wrote:
>> Include  instead of  which on Linux includes
>>  and on non-Linux platforms defines __u32 etc types.
>>
>> Fixes user space compilation errors like:
>>
>> linux/kfd_ioctl.h:33:2: error: unknown type name ‘uint32_t’
>>   uint32_t major_version; /* from KFD */
>>   ^~~~
>>
>> Signed-off-by: Mikko Rapeli 
>> Cc: Yair Shachar 
>> Cc: Oded Gabbay 
>> Cc: Andrew Lewycky 
>
> Looks good to me,
>
> Acked-by: Arnd Bergmann 

Thanks!
Applied to amdkfd -next tree

Oded


Re: [PATCH v06 36/36] uapi linux/kfd_ioctl.h: use __u32 and __u64 instead of uint32_t and uint64_t

2017-08-07 Thread Arnd Bergmann
On Sun, Aug 6, 2017 at 6:44 PM, Mikko Rapeli  wrote:
> Include  instead of  which on Linux includes
>  and on non-Linux platforms defines __u32 etc types.
>
> Fixes user space compilation errors like:
>
> linux/kfd_ioctl.h:33:2: error: unknown type name ‘uint32_t’
>   uint32_t major_version; /* from KFD */
>   ^~~~
>
> Signed-off-by: Mikko Rapeli 
> Cc: Yair Shachar 
> Cc: Oded Gabbay 
> Cc: Andrew Lewycky 

Looks good to me,

Acked-by: Arnd Bergmann 


[PATCH v06 36/36] uapi linux/kfd_ioctl.h: use __u32 and __u64 instead of uint32_t and uint64_t

2017-08-06 Thread Mikko Rapeli
Include  instead of  which on Linux includes
 and on non-Linux platforms defines __u32 etc types.

Fixes user space compilation errors like:

linux/kfd_ioctl.h:33:2: error: unknown type name ‘uint32_t’
  uint32_t major_version; /* from KFD */
  ^~~~

Signed-off-by: Mikko Rapeli 
Cc: Yair Shachar 
Cc: Oded Gabbay 
Cc: Andrew Lewycky 
---
 include/uapi/linux/kfd_ioctl.h | 172 -
 1 file changed, 86 insertions(+), 86 deletions(-)

diff --git a/include/uapi/linux/kfd_ioctl.h b/include/uapi/linux/kfd_ioctl.h
index d6833426fdef..189ebfc2e193 100644
--- a/include/uapi/linux/kfd_ioctl.h
+++ b/include/uapi/linux/kfd_ioctl.h
@@ -23,15 +23,15 @@
 #ifndef KFD_IOCTL_H_INCLUDED
 #define KFD_IOCTL_H_INCLUDED
 
-#include 
+#include 
 #include 
 
 #define KFD_IOCTL_MAJOR_VERSION 1
 #define KFD_IOCTL_MINOR_VERSION 1
 
 struct kfd_ioctl_get_version_args {
-   uint32_t major_version; /* from KFD */
-   uint32_t minor_version; /* from KFD */
+   __u32 major_version;/* from KFD */
+   __u32 minor_version;/* from KFD */
 };
 
 /* For kfd_ioctl_create_queue_args.queue_type. */
@@ -43,36 +43,36 @@ struct kfd_ioctl_get_version_args {
 #define KFD_MAX_QUEUE_PRIORITY 15
 
 struct kfd_ioctl_create_queue_args {
-   uint64_t ring_base_address; /* to KFD */
-   uint64_t write_pointer_address; /* from KFD */
-   uint64_t read_pointer_address;  /* from KFD */
-   uint64_t doorbell_offset;   /* from KFD */
-
-   uint32_t ring_size; /* to KFD */
-   uint32_t gpu_id;/* to KFD */
-   uint32_t queue_type;/* to KFD */
-   uint32_t queue_percentage;  /* to KFD */
-   uint32_t queue_priority;/* to KFD */
-   uint32_t queue_id;  /* from KFD */
-
-   uint64_t eop_buffer_address;/* to KFD */
-   uint64_t eop_buffer_size;   /* to KFD */
-   uint64_t ctx_save_restore_address; /* to KFD */
-   uint64_t ctx_save_restore_size; /* to KFD */
+   __u64 ring_base_address;/* to KFD */
+   __u64 write_pointer_address;/* from KFD */
+   __u64 read_pointer_address; /* from KFD */
+   __u64 doorbell_offset;  /* from KFD */
+
+   __u32 ring_size;/* to KFD */
+   __u32 gpu_id;   /* to KFD */
+   __u32 queue_type;   /* to KFD */
+   __u32 queue_percentage; /* to KFD */
+   __u32 queue_priority;   /* to KFD */
+   __u32 queue_id; /* from KFD */
+
+   __u64 eop_buffer_address;   /* to KFD */
+   __u64 eop_buffer_size;  /* to KFD */
+   __u64 ctx_save_restore_address; /* to KFD */
+   __u64 ctx_save_restore_size;/* to KFD */
 };
 
 struct kfd_ioctl_destroy_queue_args {
-   uint32_t queue_id;  /* to KFD */
-   uint32_t pad;
+   __u32 queue_id; /* to KFD */
+   __u32 pad;
 };
 
 struct kfd_ioctl_update_queue_args {
-   uint64_t ring_base_address; /* to KFD */
+   __u64 ring_base_address;/* to KFD */
 
-   uint32_t queue_id;  /* to KFD */
-   uint32_t ring_size; /* to KFD */
-   uint32_t queue_percentage;  /* to KFD */
-   uint32_t queue_priority;/* to KFD */
+   __u32 queue_id; /* to KFD */
+   __u32 ring_size;/* to KFD */
+   __u32 queue_percentage; /* to KFD */
+   __u32 queue_priority;   /* to KFD */
 };
 
 /* For kfd_ioctl_set_memory_policy_args.default_policy and alternate_policy */
@@ -80,13 +80,13 @@ struct kfd_ioctl_update_queue_args {
 #define KFD_IOC_CACHE_POLICY_NONCOHERENT 1
 
 struct kfd_ioctl_set_memory_policy_args {
-   uint64_t alternate_aperture_base;   /* to KFD */
-   uint64_t alternate_aperture_size;   /* to KFD */
+   __u64 alternate_aperture_base;  /* to KFD */
+   __u64 alternate_aperture_size;  /* to KFD */
 
-   uint32_t gpu_id;/* to KFD */
-   uint32_t default_policy;/* to KFD */
-   uint32_t alternate_policy;  /* to KFD */
-   uint32_t pad;
+   __u32 gpu_id;   /* to KFD */
+   __u32 default_policy;   /* to KFD */
+   __u32 alternate_policy; /* to KFD */
+   __u32 pad;
 };
 
 /*
@@ -97,26 +97,26 @@ struct kfd_ioctl_set_memory_policy_args {
  */
 
 struct kfd_ioctl_get_clock_counters_args {
-   uint64_t gpu_clock_counter; /* from KFD */
-   uint64_t cpu_clock_counter; /* from KFD */
-   uint64_t system_clock_counter;  /* from KFD */
-   uint64_t system_clock_freq; /* from KFD */
+   __u64 gpu_clock_counter;/* from KFD */
+   __u64 cpu_clock_counter;/* from KFD */
+   __u64 system_clock_counter; /* from KFD */
+   __u64 system_clock_freq;/* from KFD */
 
-   uint32_t gpu_id;/* to KFD */
-   uint32_t pad;
+   __u32 gpu_id;   /* to K