Re: [PATCH v1 1/7] mfd: stmpe-spi: Correct the name used in MODULE_DEVICE_TABLE

2025-05-01 Thread Lee Jones 
On Sun, 27 Apr 2025, Krzysztof Kozlowski wrote:

> On 26/04/2025 18:16, Alexey Gladkov wrote:
> > The name used in the macro does not exist.
> > 
> > drivers/mfd/stmpe-spi.c:132:26: error: use of undeclared identifier 
> > 'stmpe_id'
> >   132 | MODULE_DEVICE_TABLE(spi, stmpe_id);
> >   |  ^
> > 1 error generated.
> 
> 
> Reviewed-by: Krzysztof Kozlowski 
> 
> P.S. You can trim the error messages to relevant parts, e.g. "1 error
> generated" is really redundant and not needed to store in git history.

Trimmed on apply, thanks.

-- 
Lee Jones [李琼斯]

Re: (subset) [PATCH v1 1/7] mfd: stmpe-spi: Correct the name used in MODULE_DEVICE_TABLE

2025-05-01 Thread Lee Jones 
On Sat, 26 Apr 2025 18:16:32 +0200, Alexey Gladkov wrote:
> The name used in the macro does not exist.
> 
> drivers/mfd/stmpe-spi.c:132:26: error: use of undeclared identifier 'stmpe_id'
>   132 | MODULE_DEVICE_TABLE(spi, stmpe_id);
>   |  ^
> 1 error generated.
> 
> [...]

Applied, thanks!

[1/7] mfd: stmpe-spi: Correct the name used in MODULE_DEVICE_TABLE
  commit: 7e5d7dcd96e29bb30fe7b105c53ae63a8edcd3e1

--
Lee Jones [李琼斯]

Re: [PATCH v1 1/7] mfd: stmpe-spi: Correct the name used in MODULE_DEVICE_TABLE

2025-04-27 Thread Krzysztof Kozlowski 
On 26/04/2025 18:16, Alexey Gladkov wrote:
> The name used in the macro does not exist.
> 
> drivers/mfd/stmpe-spi.c:132:26: error: use of undeclared identifier 'stmpe_id'
>   132 | MODULE_DEVICE_TABLE(spi, stmpe_id);
>   |  ^
> 1 error generated.


Reviewed-by: Krzysztof Kozlowski 

P.S. You can trim the error messages to relevant parts, e.g. "1 error
generated" is really redundant and not needed to store in git history.

> 

Best regards,
Krzysztof

[PATCH v1 1/7] mfd: stmpe-spi: Correct the name used in MODULE_DEVICE_TABLE

2025-04-26 Thread Alexey Gladkov 
The name used in the macro does not exist.

drivers/mfd/stmpe-spi.c:132:26: error: use of undeclared identifier 'stmpe_id'
  132 | MODULE_DEVICE_TABLE(spi, stmpe_id);
  |  ^
1 error generated.

Fixes: e789995d5c61 ("mfd: Add support for STMPE SPI interface")
Cc: Lee Jones 
Cc: Maxime Coquelin 
Cc: Alexandre Torgue 
Signed-off-by: Alexey Gladkov 
---
 drivers/mfd/stmpe-spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/stmpe-spi.c b/drivers/mfd/stmpe-spi.c
index 792236f56399..b9cc85ea2c40 100644
--- a/drivers/mfd/stmpe-spi.c
+++ b/drivers/mfd/stmpe-spi.c
@@ -129,7 +129,7 @@ static const struct spi_device_id stmpe_spi_id[] = {
{ "stmpe2403", STMPE2403 },
{ }
 };
-MODULE_DEVICE_TABLE(spi, stmpe_id);
+MODULE_DEVICE_TABLE(spi, stmpe_spi_id);
 
 static struct spi_driver stmpe_spi_driver = {
.driver = {
-- 
2.49.0