Re: [PATCH v1 2/2] PCI: Allow user to request power management of conventional and hotplug bridges

2018-02-26 Thread Mika Westerberg
On Mon, Feb 26, 2018 at 01:22:43PM +0100, Lukas Wunner wrote: > On Mon, Feb 26, 2018 at 02:05:34PM +0200, Mika Westerberg wrote: > > On Thu, Feb 22, 2018 at 02:18:34PM +0100, Lukas Wunner wrote: > > > We do need runtime PM on hotplug ports to power off Thunderbolt > > > controllers when nothing is

Re: [PATCH v1 2/2] PCI: Allow user to request power management of conventional and hotplug bridges

2018-02-26 Thread Lukas Wunner
On Mon, Feb 26, 2018 at 02:05:34PM +0200, Mika Westerberg wrote: > On Thu, Feb 22, 2018 at 02:18:34PM +0100, Lukas Wunner wrote: > > We do need runtime PM on hotplug ports to power off Thunderbolt > > controllers when nothing is plugged in. That saves 1.5 W, so a > > noticeable amount of power. I

Re: [PATCH v1 2/2] PCI: Allow user to request power management of conventional and hotplug bridges

2018-02-26 Thread Mika Westerberg
On Thu, Feb 22, 2018 at 02:18:34PM +0100, Lukas Wunner wrote: > We do need runtime PM on hotplug ports to power off Thunderbolt > controllers when nothing is plugged in. That saves 1.5 W, so a > noticeable amount of power. I was going to respin the series one > of these days, I think the best I c

Re: [PATCH v1 2/2] PCI: Allow user to request power management of conventional and hotplug bridges

2018-02-22 Thread Rafael J. Wysocki
On Thu, Feb 22, 2018 at 2:31 PM, Rafael J. Wysocki wrote: > On 2/22/2018 2:18 PM, Lukas Wunner wrote: >> >> On Tue, Feb 20, 2018 at 12:15:54PM -0600, Bjorn Helgaas wrote: >>> >>> Basically I was hoping to partially rectify what I think was a mistake >>> on my part when we merged this. 9d26d3a8f1b

Re: [PATCH v1 2/2] PCI: Allow user to request power management of conventional and hotplug bridges

2018-02-22 Thread Rafael J. Wysocki
On 2/22/2018 2:18 PM, Lukas Wunner wrote: On Tue, Feb 20, 2018 at 12:15:54PM -0600, Bjorn Helgaas wrote: Basically I was hoping to partially rectify what I think was a mistake on my part when we merged this. 9d26d3a8f1b0 ("PCI: Put PCIe ports into D3 during suspend") is somewhat misleading beca

Re: [PATCH v1 2/2] PCI: Allow user to request power management of conventional and hotplug bridges

2018-02-22 Thread Lukas Wunner
On Tue, Feb 20, 2018 at 12:15:54PM -0600, Bjorn Helgaas wrote: > Basically I was hoping to partially rectify what I think was a mistake > on my part when we merged this. 9d26d3a8f1b0 ("PCI: Put PCIe ports > into D3 during suspend") is somewhat misleading because it suggests > that PCI bridge power

Re: [PATCH v1 2/2] PCI: Allow user to request power management of conventional and hotplug bridges

2018-02-20 Thread Rafael J. Wysocki
On Tue, Feb 20, 2018 at 7:15 PM, Bjorn Helgaas wrote: > On Tue, Feb 20, 2018 at 10:41:33AM +0100, Rafael J. Wysocki wrote: >> On Tue, Feb 20, 2018 at 12:14 AM, Bjorn Helgaas wrote: >> > From: Bjorn Helgaas >> > >> > Previously "pcie_port_pm=force" enabled power management of PCI bridges, >> > bu

Re: [PATCH v1 2/2] PCI: Allow user to request power management of conventional and hotplug bridges

2018-02-20 Thread Bjorn Helgaas
On Tue, Feb 20, 2018 at 10:41:33AM +0100, Rafael J. Wysocki wrote: > On Tue, Feb 20, 2018 at 12:14 AM, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > > > Previously "pcie_port_pm=force" enabled power management of PCI bridges, > > but only for PCIe ports (not conventional PCI bridges) and only

Re: [PATCH v1 2/2] PCI: Allow user to request power management of conventional and hotplug bridges

2018-02-20 Thread Rafael J. Wysocki
On Tue, Feb 20, 2018 at 10:41 AM, Rafael J. Wysocki wrote: > On Tue, Feb 20, 2018 at 12:14 AM, Bjorn Helgaas wrote: >> From: Bjorn Helgaas >> >> Previously "pcie_port_pm=force" enabled power management of PCI bridges, >> but only for PCIe ports (not conventional PCI bridges) and only for ports >

Re: [PATCH v1 2/2] PCI: Allow user to request power management of conventional and hotplug bridges

2018-02-20 Thread Rafael J. Wysocki
On Tue, Feb 20, 2018 at 12:14 AM, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Previously "pcie_port_pm=force" enabled power management of PCI bridges, > but only for PCIe ports (not conventional PCI bridges) and only for ports > that do not support hotplug. Those limitations are there because

Re: [PATCH v1 2/2] PCI: Allow user to request power management of conventional and hotplug bridges

2018-02-19 Thread valdis . kletnieks
On Mon, 19 Feb 2018 17:14:06 -0600, Bjorn Helgaas said: > Change "pcie_port_pm=force" to enable power management of conventional PCI > bridges and hotplug bridges as well as PCIe ports. As with the previous > PCIe port-only behavior, this is not expected to work in all systems. This part says th

[PATCH v1 2/2] PCI: Allow user to request power management of conventional and hotplug bridges

2018-02-19 Thread Bjorn Helgaas
From: Bjorn Helgaas Previously "pcie_port_pm=force" enabled power management of PCI bridges, but only for PCIe ports (not conventional PCI bridges) and only for ports that do not support hotplug. Those limitations are there because we're not confident that all those configurations work, not beca