Re: [PATCH v1 3/4] KVM: MMU: Add 5 level EPT & Shadow page table support.

2017-08-14 Thread Yu Zhang
On 8/14/2017 11:02 PM, Paolo Bonzini wrote: On 14/08/2017 16:32, Yu Zhang wrote: On 8/14/2017 10:13 PM, Paolo Bonzini wrote: On 14/08/2017 13:37, Yu Zhang wrote: Thanks a lot for your comments, Paolo. :-) On 8/14/2017 3:31 PM, Paolo Bonzini wrote: On 12/08/2017 15:35, Yu Zhang wrote:

Re: [PATCH v1 3/4] KVM: MMU: Add 5 level EPT & Shadow page table support.

2017-08-14 Thread Paolo Bonzini
On 14/08/2017 16:32, Yu Zhang wrote: > > > On 8/14/2017 10:13 PM, Paolo Bonzini wrote: >> On 14/08/2017 13:37, Yu Zhang wrote: >>> Thanks a lot for your comments, Paolo. :-) >>> >>> >>> On 8/14/2017 3:31 PM, Paolo Bonzini wrote: On 12/08/2017 15:35, Yu Zhang wrote: >struct rsvd_bits_

Re: [PATCH v1 3/4] KVM: MMU: Add 5 level EPT & Shadow page table support.

2017-08-14 Thread Yu Zhang
On 8/14/2017 10:13 PM, Paolo Bonzini wrote: On 14/08/2017 13:37, Yu Zhang wrote: Thanks a lot for your comments, Paolo. :-) On 8/14/2017 3:31 PM, Paolo Bonzini wrote: On 12/08/2017 15:35, Yu Zhang wrote: struct rsvd_bits_validate { -u64 rsvd_bits_mask[2][4]; +u64 rsvd_bits_mask[

Re: [PATCH v1 3/4] KVM: MMU: Add 5 level EPT & Shadow page table support.

2017-08-14 Thread Paolo Bonzini
On 14/08/2017 13:37, Yu Zhang wrote: > Thanks a lot for your comments, Paolo. :-) > > > On 8/14/2017 3:31 PM, Paolo Bonzini wrote: >> On 12/08/2017 15:35, Yu Zhang wrote: >>> struct rsvd_bits_validate { >>> -u64 rsvd_bits_mask[2][4]; >>> +u64 rsvd_bits_mask[2][5]; >>> u64 bad_mt_x

Re: [PATCH v1 3/4] KVM: MMU: Add 5 level EPT & Shadow page table support.

2017-08-14 Thread Yu Zhang
Thanks a lot for your comments, Paolo. :-) On 8/14/2017 3:31 PM, Paolo Bonzini wrote: On 12/08/2017 15:35, Yu Zhang wrote: struct rsvd_bits_validate { - u64 rsvd_bits_mask[2][4]; + u64 rsvd_bits_mask[2][5]; u64 bad_mt_xwr; }; Can you change this 4 to PT64_ROOT_MAX_LEV

Re: [PATCH v1 3/4] KVM: MMU: Add 5 level EPT & Shadow page table support.

2017-08-14 Thread Paolo Bonzini
On 12/08/2017 15:35, Yu Zhang wrote: > struct rsvd_bits_validate { > - u64 rsvd_bits_mask[2][4]; > + u64 rsvd_bits_mask[2][5]; > u64 bad_mt_xwr; > }; Can you change this 4 to PT64_ROOT_MAX_LEVEL in patch 2? > - if (vcpu->arch.mmu.shadow_root_level == PT64_ROOT_4LEVEL && > -

[PATCH v1 3/4] KVM: MMU: Add 5 level EPT & Shadow page table support.

2017-08-12 Thread Yu Zhang
Extends the shadow paging code, so that 5 level shadow page table can be constructed if VM is running in 5 level paging mode. Also extends the ept code, so that 5 level ept table can be constructed if maxphysaddr of VM exceeds 48 bits. Unlike the shadow logic, KVM should still use 4 level ept tabl