On Thu, May 21, 2020 at 02:09:09PM +0300, Tali Perry wrote:
> Add Nuvoton NPCM BMC I2C controller driver.
>
> Signed-off-by: Tali Perry
This is a very complex driver, so I can really comment only about high
level things. Thank you very much for keeping at it!
My code checkers say:
CHECKPATCH:
> From a glimpse, this looks good to go. I will have a close look later
> today.
Phew, this driver is huge. I won't finish my review today, but I am
working on it and am maybe 2/3 through.
signature.asc
Description: PGP signature
On Thu, May 21, 2020 at 11:37 PM Wolfram Sang wrote:
>
>
> > > > I wondered also about DEBUG_FS entries. I can see their value when
> > > > developing the driver. But since this is done now, do they really help a
> > > > user to debug a difficult case? I am not sure, and then I wonder if we
> > >
> > > I wondered also about DEBUG_FS entries. I can see their value when
> > > developing the driver. But since this is done now, do they really help a
> > > user to debug a difficult case? I am not sure, and then I wonder if we
> > > should have that code in upstream. I am open for discussion,
On Thu, May 21, 2020 at 05:45:03PM +0300, Tali Perry wrote:
> On Thu, May 21, 2020 at 5:31 PM Wolfram Sang wrote:
> > On Thu, May 21, 2020 at 05:23:40PM +0300, Andy Shevchenko wrote:
> > > On Thu, May 21, 2020 at 02:09:09PM +0300, Tali Perry wrote:
> > > > Add Nuvoton NPCM BMC I2C controller
On Thu, May 21, 2020 at 5:31 PM Wolfram Sang wrote:
>
> Hi Tali, Andy!
>
> On Thu, May 21, 2020 at 05:23:40PM +0300, Andy Shevchenko wrote:
> > On Thu, May 21, 2020 at 02:09:09PM +0300, Tali Perry wrote:
> > > Add Nuvoton NPCM BMC I2C controller driver.
> >
> > Thanks. My comments below.
> >
Hi Tali, Andy!
On Thu, May 21, 2020 at 05:23:40PM +0300, Andy Shevchenko wrote:
> On Thu, May 21, 2020 at 02:09:09PM +0300, Tali Perry wrote:
> > Add Nuvoton NPCM BMC I2C controller driver.
>
> Thanks. My comments below.
> After addressing them, FWIW,
> Reviewed-by: Andy Shevchenko
Thanks,
On Thu, May 21, 2020 at 02:09:09PM +0300, Tali Perry wrote:
> Add Nuvoton NPCM BMC I2C controller driver.
Thanks. My comments below.
After addressing them, FWIW,
Reviewed-by: Andy Shevchenko
...
> + /* Frequency larger than 1 MHZ is not supported */
1 MHZ -> 1MHz
...
> +#ifdef
Add Nuvoton NPCM BMC I2C controller driver.
Signed-off-by: Tali Perry
---
drivers/i2c/busses/Kconfig |9 +
drivers/i2c/busses/Makefile |1 +
drivers/i2c/busses/i2c-npcm7xx.c | 1818 ++
3 files changed, 1828 insertions(+)
create mode 100644
9 matches
Mail list logo
