Re: [PATCH v2] dp83640: Ensure against premature access to PHY registers after reset

2018-04-06 Thread Andrew Lunn
On Fri, Apr 06, 2018 at 07:08:44PM +0200, Esben Haabendal wrote: > From: Esben Haabendal Hi Esben It it good to have some form of commit message. Something like: The datasheet specifies a 3uS pause after performing a software reset. The default implementation of

Re: [PATCH v2] dp83640: Ensure against premature access to PHY registers after reset

2018-04-06 Thread Andrew Lunn
On Fri, Apr 06, 2018 at 07:08:44PM +0200, Esben Haabendal wrote: > From: Esben Haabendal Hi Esben It it good to have some form of commit message. Something like: The datasheet specifies a 3uS pause after performing a software reset. The default implementation of genphy_soft_reset() does not

[PATCH v2] dp83640: Ensure against premature access to PHY registers after reset

2018-04-06 Thread Esben Haabendal
From: Esben Haabendal Signed-off-by: Esben Haabendal --- drivers/net/phy/dp83640.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c index 654f42d00092..a6c87793d899 100644 ---

[PATCH v2] dp83640: Ensure against premature access to PHY registers after reset

2018-04-06 Thread Esben Haabendal
From: Esben Haabendal Signed-off-by: Esben Haabendal --- drivers/net/phy/dp83640.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c index 654f42d00092..a6c87793d899 100644 --- a/drivers/net/phy/dp83640.c +++