Re: [PATCH v2] i2c: i2c-mux-gpio: remove error messages for probe deferrals

[Wolfram Sang]

On Mon, Mar 30, 2015 at 03:03:38PM +0200, Ioan Nicu wrote:
> Probe deferral is not an error case. It happens only when
> the necessary dependencies are not there yet.
> 
> The driver core is already printing a message when a driver
> requests probe deferral, so this can be traced in the logs
> without these error prints.
> 
> This patch removes the error messages for these deferral cases.
> 
> Signed-off-by: Ionut Nicu 

Applied to for-next, thanks!



signature.asc
Description: Digital signature

Re: [PATCH v2] i2c: i2c-mux-gpio: remove error messages for probe deferrals

[Wolfram Sang]

On Mon, Mar 30, 2015 at 03:03:38PM +0200, Ioan Nicu wrote:
 Probe deferral is not an error case. It happens only when
 the necessary dependencies are not there yet.
 
 The driver core is already printing a message when a driver
 requests probe deferral, so this can be traced in the logs
 without these error prints.
 
 This patch removes the error messages for these deferral cases.
 
 Signed-off-by: Ionut Nicu ioan.nicu@nokia.com

Applied to for-next, thanks!



signature.asc
Description: Digital signature

Re: [PATCH v2] i2c: i2c-mux-gpio: remove error messages for probe deferrals

[Peter Korsgaard]

> "AS" == Alexander Sverdlin  writes:

Hi,

AS> On 30/03/15 15:03, Ioan Nicu wrote:
>> Probe deferral is not an error case. It happens only when
>> the necessary dependencies are not there yet.
>>
>> The driver core is already printing a message when a driver
>> requests probe deferral, so this can be traced in the logs
>> without these error prints.
>>
>> This patch removes the error messages for these deferral cases.
>>
>> Signed-off-by: Ionut Nicu 

AS> Acked-by: Alexander Sverdlin 

Acked-by: Peter Korsgaard 

--
Sorry about disclaimer - It's out of my control.
Bye, Peter Korsgaard
This message is subject to the following terms and conditions: MAIL 
DISCLAIMER
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] i2c: i2c-mux-gpio: remove error messages for probe deferrals

[Alexander Sverdlin]

On 30/03/15 15:03, Ioan Nicu wrote:
> Probe deferral is not an error case. It happens only when
> the necessary dependencies are not there yet.
> 
> The driver core is already printing a message when a driver
> requests probe deferral, so this can be traced in the logs
> without these error prints.
> 
> This patch removes the error messages for these deferral cases.
> 
> Signed-off-by: Ionut Nicu 

Acked-by: Alexander Sverdlin 

> ---
>  drivers/i2c/muxes/i2c-mux-gpio.c |   10 +++---
>  1 files changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c 
> b/drivers/i2c/muxes/i2c-mux-gpio.c
> index f5798eb..70db992 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
> @@ -76,10 +76,9 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
>   return -ENODEV;
>   }
>   adapter = of_find_i2c_adapter_by_node(adapter_np);
> - if (!adapter) {
> - dev_err(>dev, "Cannot find parent bus\n");
> + if (!adapter)
>   return -EPROBE_DEFER;
> - }
> +
>   mux->data.parent = i2c_adapter_id(adapter);
>   put_device(>dev);
>  
> @@ -177,11 +176,8 @@ static int i2c_mux_gpio_probe(struct platform_device 
> *pdev)
>   }
>  
>   parent = i2c_get_adapter(mux->data.parent);
> - if (!parent) {
> - dev_err(>dev, "Parent adapter (%d) not found\n",
> - mux->data.parent);
> + if (!parent)
>   return -EPROBE_DEFER;
> - }
>  
>   mux->parent = parent;
>   mux->gpio_base = gpio_base;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] i2c: i2c-mux-gpio: remove error messages for probe deferrals

[Alexander Sverdlin]

On 30/03/15 15:03, Ioan Nicu wrote:
 Probe deferral is not an error case. It happens only when
 the necessary dependencies are not there yet.
 
 The driver core is already printing a message when a driver
 requests probe deferral, so this can be traced in the logs
 without these error prints.
 
 This patch removes the error messages for these deferral cases.
 
 Signed-off-by: Ionut Nicu ioan.nicu@nokia.com

Acked-by: Alexander Sverdlin alexander.sverd...@nokia.com

 ---
  drivers/i2c/muxes/i2c-mux-gpio.c |   10 +++---
  1 files changed, 3 insertions(+), 7 deletions(-)
 
 diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c 
 b/drivers/i2c/muxes/i2c-mux-gpio.c
 index f5798eb..70db992 100644
 --- a/drivers/i2c/muxes/i2c-mux-gpio.c
 +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
 @@ -76,10 +76,9 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
   return -ENODEV;
   }
   adapter = of_find_i2c_adapter_by_node(adapter_np);
 - if (!adapter) {
 - dev_err(pdev-dev, Cannot find parent bus\n);
 + if (!adapter)
   return -EPROBE_DEFER;
 - }
 +
   mux-data.parent = i2c_adapter_id(adapter);
   put_device(adapter-dev);
  
 @@ -177,11 +176,8 @@ static int i2c_mux_gpio_probe(struct platform_device 
 *pdev)
   }
  
   parent = i2c_get_adapter(mux-data.parent);
 - if (!parent) {
 - dev_err(pdev-dev, Parent adapter (%d) not found\n,
 - mux-data.parent);
 + if (!parent)
   return -EPROBE_DEFER;
 - }
  
   mux-parent = parent;
   mux-gpio_base = gpio_base;
 
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] i2c: i2c-mux-gpio: remove error messages for probe deferrals

[Peter Korsgaard]

 AS == Alexander Sverdlin alexander.sverd...@nokia.com writes:

Hi,

AS On 30/03/15 15:03, Ioan Nicu wrote:
 Probe deferral is not an error case. It happens only when
 the necessary dependencies are not there yet.

 The driver core is already printing a message when a driver
 requests probe deferral, so this can be traced in the logs
 without these error prints.

 This patch removes the error messages for these deferral cases.

 Signed-off-by: Ionut Nicu ioan.nicu@nokia.com

AS Acked-by: Alexander Sverdlin alexander.sverd...@nokia.com

Acked-by: Peter Korsgaard peter.korsga...@barco.com

--
Sorry about disclaimer - It's out of my control.
Bye, Peter Korsgaard
This message is subject to the following terms and conditions: MAIL 
DISCLAIMERhttp://www.barco.com/en/maildisclaimer
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2] i2c: i2c-mux-gpio: remove error messages for probe deferrals

[Ioan Nicu]

Probe deferral is not an error case. It happens only when
the necessary dependencies are not there yet.

The driver core is already printing a message when a driver
requests probe deferral, so this can be traced in the logs
without these error prints.

This patch removes the error messages for these deferral cases.

Signed-off-by: Ionut Nicu 
---
 drivers/i2c/muxes/i2c-mux-gpio.c |   10 +++---
 1 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
index f5798eb..70db992 100644
--- a/drivers/i2c/muxes/i2c-mux-gpio.c
+++ b/drivers/i2c/muxes/i2c-mux-gpio.c
@@ -76,10 +76,9 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
return -ENODEV;
}
adapter = of_find_i2c_adapter_by_node(adapter_np);
-   if (!adapter) {
-   dev_err(>dev, "Cannot find parent bus\n");
+   if (!adapter)
return -EPROBE_DEFER;
-   }
+
mux->data.parent = i2c_adapter_id(adapter);
put_device(>dev);
 
@@ -177,11 +176,8 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev)
}
 
parent = i2c_get_adapter(mux->data.parent);
-   if (!parent) {
-   dev_err(>dev, "Parent adapter (%d) not found\n",
-   mux->data.parent);
+   if (!parent)
return -EPROBE_DEFER;
-   }
 
mux->parent = parent;
mux->gpio_base = gpio_base;
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2] i2c: i2c-mux-gpio: remove error messages for probe deferrals

[Ioan Nicu]

Probe deferral is not an error case. It happens only when
the necessary dependencies are not there yet.

The driver core is already printing a message when a driver
requests probe deferral, so this can be traced in the logs
without these error prints.

This patch removes the error messages for these deferral cases.

Signed-off-by: Ionut Nicu ioan.nicu@nokia.com
---
 drivers/i2c/muxes/i2c-mux-gpio.c |   10 +++---
 1 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
index f5798eb..70db992 100644
--- a/drivers/i2c/muxes/i2c-mux-gpio.c
+++ b/drivers/i2c/muxes/i2c-mux-gpio.c
@@ -76,10 +76,9 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
return -ENODEV;
}
adapter = of_find_i2c_adapter_by_node(adapter_np);
-   if (!adapter) {
-   dev_err(pdev-dev, Cannot find parent bus\n);
+   if (!adapter)
return -EPROBE_DEFER;
-   }
+
mux-data.parent = i2c_adapter_id(adapter);
put_device(adapter-dev);
 
@@ -177,11 +176,8 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev)
}
 
parent = i2c_get_adapter(mux-data.parent);
-   if (!parent) {
-   dev_err(pdev-dev, Parent adapter (%d) not found\n,
-   mux-data.parent);
+   if (!parent)
return -EPROBE_DEFER;
-   }
 
mux-parent = parent;
mux-gpio_base = gpio_base;
-- 
1.7.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/