Re: [PATCH v2 0/3] perf/buildid-cache: Add --list and --purge-all options

2018-04-17 Thread Masami Hiramatsu 
On Tue, 17 Apr 2018 09:43:43 +0530
Ravi Bangoria  wrote:

> First patch is a trivial error message fix. Second and third
> adds new options --list and --purge-all to 'buildid-cache'
> subcommand.
> 
> v2 changes:
>  - [PATCH v2 2/3] Display optput of 'perf buildid-cache -l' same as
>'perf buildid-list'.
>  - [PATCH v2 2/3] Other minor changes as suggested by Jiri.
> 
> v1 can be found at:
>   https://lkml.org/lkml/2018/4/9/295

All patches in this series looks good to me.

Acked-by: Masami Hiramatsu 

Thanks,

> 
> Ravi Bangoria (3):
>   tools/parse-options: Add '\n' at the end of error messages
>   perf/buildid-cache: Support --list option
>   perf/buildid-cache: Support --purge-all option
> 
>  tools/lib/subcmd/parse-options.c|  6 +-
>  tools/perf/Documentation/perf-buildid-cache.txt |  7 ++-
>  tools/perf/builtin-buildid-cache.c  | 77 
> -
>  3 files changed, 83 insertions(+), 7 deletions(-)
> 
> -- 
> 2.14.3
> 


-- 
Masami Hiramatsu

Re: [PATCH v2 0/3] perf/buildid-cache: Add --list and --purge-all options

2018-04-17 Thread Masami Hiramatsu 
On Tue, 17 Apr 2018 09:43:43 +0530
Ravi Bangoria  wrote:

> First patch is a trivial error message fix. Second and third
> adds new options --list and --purge-all to 'buildid-cache'
> subcommand.
> 
> v2 changes:
>  - [PATCH v2 2/3] Display optput of 'perf buildid-cache -l' same as
>'perf buildid-list'.
>  - [PATCH v2 2/3] Other minor changes as suggested by Jiri.
> 
> v1 can be found at:
>   https://lkml.org/lkml/2018/4/9/295

All patches in this series looks good to me.

Acked-by: Masami Hiramatsu 

Thanks,

> 
> Ravi Bangoria (3):
>   tools/parse-options: Add '\n' at the end of error messages
>   perf/buildid-cache: Support --list option
>   perf/buildid-cache: Support --purge-all option
> 
>  tools/lib/subcmd/parse-options.c|  6 +-
>  tools/perf/Documentation/perf-buildid-cache.txt |  7 ++-
>  tools/perf/builtin-buildid-cache.c  | 77 
> -
>  3 files changed, 83 insertions(+), 7 deletions(-)
> 
> -- 
> 2.14.3
> 


-- 
Masami Hiramatsu

Re: [PATCH v2 0/3] perf/buildid-cache: Add --list and --purge-all options

2018-04-17 Thread Arnaldo Carvalho de Melo 
Em Tue, Apr 17, 2018 at 09:57:50AM +0200, Jiri Olsa escreveu:
> On Tue, Apr 17, 2018 at 09:43:43AM +0530, Ravi Bangoria wrote:
> > First patch is a trivial error message fix. Second and third
> > adds new options --list and --purge-all to 'buildid-cache'
> > subcommand.
> > 
> > v2 changes:
> >  - [PATCH v2 2/3] Display optput of 'perf buildid-cache -l' same as
> >'perf buildid-list'.
> >  - [PATCH v2 2/3] Other minor changes as suggested by Jiri.
> 
> Acked-by: Jiri Olsa 

Thanks, applied 1/3 to perf/urgent, 2-3/3 to perf/core.

- Arnaldo

Re: [PATCH v2 0/3] perf/buildid-cache: Add --list and --purge-all options

2018-04-17 Thread Arnaldo Carvalho de Melo 
Em Tue, Apr 17, 2018 at 09:57:50AM +0200, Jiri Olsa escreveu:
> On Tue, Apr 17, 2018 at 09:43:43AM +0530, Ravi Bangoria wrote:
> > First patch is a trivial error message fix. Second and third
> > adds new options --list and --purge-all to 'buildid-cache'
> > subcommand.
> > 
> > v2 changes:
> >  - [PATCH v2 2/3] Display optput of 'perf buildid-cache -l' same as
> >'perf buildid-list'.
> >  - [PATCH v2 2/3] Other minor changes as suggested by Jiri.
> 
> Acked-by: Jiri Olsa 

Thanks, applied 1/3 to perf/urgent, 2-3/3 to perf/core.

- Arnaldo

Re: [PATCH v2 0/3] perf/buildid-cache: Add --list and --purge-all options

2018-04-17 Thread Jiri Olsa 
On Tue, Apr 17, 2018 at 09:43:43AM +0530, Ravi Bangoria wrote:
> First patch is a trivial error message fix. Second and third
> adds new options --list and --purge-all to 'buildid-cache'
> subcommand.
> 
> v2 changes:
>  - [PATCH v2 2/3] Display optput of 'perf buildid-cache -l' same as
>'perf buildid-list'.
>  - [PATCH v2 2/3] Other minor changes as suggested by Jiri.

Acked-by: Jiri Olsa 

thanks,
jirka

> 
> v1 can be found at:
>   https://lkml.org/lkml/2018/4/9/295
> 
> Ravi Bangoria (3):
>   tools/parse-options: Add '\n' at the end of error messages
>   perf/buildid-cache: Support --list option
>   perf/buildid-cache: Support --purge-all option
> 
>  tools/lib/subcmd/parse-options.c|  6 +-
>  tools/perf/Documentation/perf-buildid-cache.txt |  7 ++-
>  tools/perf/builtin-buildid-cache.c  | 77 
> -
>  3 files changed, 83 insertions(+), 7 deletions(-)
> 
> -- 
> 2.14.3
>

Re: [PATCH v2 0/3] perf/buildid-cache: Add --list and --purge-all options

2018-04-17 Thread Jiri Olsa 
On Tue, Apr 17, 2018 at 09:43:43AM +0530, Ravi Bangoria wrote:
> First patch is a trivial error message fix. Second and third
> adds new options --list and --purge-all to 'buildid-cache'
> subcommand.
> 
> v2 changes:
>  - [PATCH v2 2/3] Display optput of 'perf buildid-cache -l' same as
>'perf buildid-list'.
>  - [PATCH v2 2/3] Other minor changes as suggested by Jiri.

Acked-by: Jiri Olsa 

thanks,
jirka

> 
> v1 can be found at:
>   https://lkml.org/lkml/2018/4/9/295
> 
> Ravi Bangoria (3):
>   tools/parse-options: Add '\n' at the end of error messages
>   perf/buildid-cache: Support --list option
>   perf/buildid-cache: Support --purge-all option
> 
>  tools/lib/subcmd/parse-options.c|  6 +-
>  tools/perf/Documentation/perf-buildid-cache.txt |  7 ++-
>  tools/perf/builtin-buildid-cache.c  | 77 
> -
>  3 files changed, 83 insertions(+), 7 deletions(-)
> 
> -- 
> 2.14.3
>

[PATCH v2 0/3] perf/buildid-cache: Add --list and --purge-all options

2018-04-16 Thread Ravi Bangoria 
First patch is a trivial error message fix. Second and third
adds new options --list and --purge-all to 'buildid-cache'
subcommand.

v2 changes:
 - [PATCH v2 2/3] Display optput of 'perf buildid-cache -l' same as
   'perf buildid-list'.
 - [PATCH v2 2/3] Other minor changes as suggested by Jiri.

v1 can be found at:
  https://lkml.org/lkml/2018/4/9/295

Ravi Bangoria (3):
  tools/parse-options: Add '\n' at the end of error messages
  perf/buildid-cache: Support --list option
  perf/buildid-cache: Support --purge-all option

 tools/lib/subcmd/parse-options.c|  6 +-
 tools/perf/Documentation/perf-buildid-cache.txt |  7 ++-
 tools/perf/builtin-buildid-cache.c  | 77 -
 3 files changed, 83 insertions(+), 7 deletions(-)

-- 
2.14.3

[PATCH v2 0/3] perf/buildid-cache: Add --list and --purge-all options

2018-04-16 Thread Ravi Bangoria 
First patch is a trivial error message fix. Second and third
adds new options --list and --purge-all to 'buildid-cache'
subcommand.

v2 changes:
 - [PATCH v2 2/3] Display optput of 'perf buildid-cache -l' same as
   'perf buildid-list'.
 - [PATCH v2 2/3] Other minor changes as suggested by Jiri.

v1 can be found at:
  https://lkml.org/lkml/2018/4/9/295

Ravi Bangoria (3):
  tools/parse-options: Add '\n' at the end of error messages
  perf/buildid-cache: Support --list option
  perf/buildid-cache: Support --purge-all option

 tools/lib/subcmd/parse-options.c|  6 +-
 tools/perf/Documentation/perf-buildid-cache.txt |  7 ++-
 tools/perf/builtin-buildid-cache.c  | 77 -
 3 files changed, 83 insertions(+), 7 deletions(-)

-- 
2.14.3