Re: [RESEND PATCH v2 1/2] sched/rt: add utilization tracking

2017-08-08 Thread Peter Zijlstra
On Tue, Aug 08, 2017 at 03:56:26PM +0200, Vincent Guittot wrote: > > I don't think that IRQ tracking patch is working. > update_irq_load_avg(rq->clock, cpu_of(rq), rq, 1); is called in > update_rq_clock_task() which is never called in irq context. In order > to use PELT for tracking irq and

Re: [RESEND PATCH v2 1/2] sched/rt: add utilization tracking

2017-08-08 Thread Peter Zijlstra
On Tue, Aug 08, 2017 at 03:56:26PM +0200, Vincent Guittot wrote: > > I don't think that IRQ tracking patch is working. > update_irq_load_avg(rq->clock, cpu_of(rq), rq, 1); is called in > update_rq_clock_task() which is never called in irq context. In order > to use PELT for tracking irq and

Re: [RESEND PATCH v2 1/2] sched/rt: add utilization tracking

2017-08-08 Thread Vincent Guittot
On 7 August 2017 at 18:44, Peter Zijlstra wrote: > On Fri, Aug 04, 2017 at 03:40:21PM +0200, Vincent Guittot wrote: > >> There were several comments on v1: >> - As raised by Peter for v1, if IRQ time is taken into account in >> rt_avg, it will not be accounted in

Re: [RESEND PATCH v2 1/2] sched/rt: add utilization tracking

2017-08-08 Thread Vincent Guittot
On 7 August 2017 at 18:44, Peter Zijlstra wrote: > On Fri, Aug 04, 2017 at 03:40:21PM +0200, Vincent Guittot wrote: > >> There were several comments on v1: >> - As raised by Peter for v1, if IRQ time is taken into account in >> rt_avg, it will not be accounted in rq->clock_task. This means that

Re: [RESEND PATCH v2 1/2] sched/rt: add utilization tracking

2017-08-07 Thread Peter Zijlstra
On Fri, Aug 04, 2017 at 03:40:21PM +0200, Vincent Guittot wrote: > There were several comments on v1: > - As raised by Peter for v1, if IRQ time is taken into account in > rt_avg, it will not be accounted in rq->clock_task. This means that cfs > utilization is not affected by some extra

Re: [RESEND PATCH v2 1/2] sched/rt: add utilization tracking

2017-08-07 Thread Peter Zijlstra
On Fri, Aug 04, 2017 at 03:40:21PM +0200, Vincent Guittot wrote: > There were several comments on v1: > - As raised by Peter for v1, if IRQ time is taken into account in > rt_avg, it will not be accounted in rq->clock_task. This means that cfs > utilization is not affected by some extra

[RESEND PATCH v2 1/2] sched/rt: add utilization tracking

2017-08-04 Thread Vincent Guittot
schedutil governor relies on cfs_rq's util_avg to choose the OPP when cfs tasks are running. When the CPU is overloaded by cfs and rt tasks, cfs tasks are preempted by rt tasks and in this case util_avg reflects the remaining capacity that is used by cfs tasks but not what cfs tasks want to use.

[RESEND PATCH v2 1/2] sched/rt: add utilization tracking

2017-08-04 Thread Vincent Guittot
schedutil governor relies on cfs_rq's util_avg to choose the OPP when cfs tasks are running. When the CPU is overloaded by cfs and rt tasks, cfs tasks are preempted by rt tasks and in this case util_avg reflects the remaining capacity that is used by cfs tasks but not what cfs tasks want to use.

[PATCH v2 1/2] sched/rt: add utilization tracking

2017-06-19 Thread Vincent Guittot
schedutil governor relies on cfs_rq's util_avg to choose the OPP when cfs tasks are running. When the CPU is overloaded by cfs and rt tasks, cfs tasks are preempted by rt tasks and in this case util_avg reflects the remaining capacity that is used by cfs tasks but not what cfs tasks want to use.

[PATCH v2 1/2] sched/rt: add utilization tracking

2017-06-19 Thread Vincent Guittot
schedutil governor relies on cfs_rq's util_avg to choose the OPP when cfs tasks are running. When the CPU is overloaded by cfs and rt tasks, cfs tasks are preempted by rt tasks and in this case util_avg reflects the remaining capacity that is used by cfs tasks but not what cfs tasks want to use.