Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-19 Thread Vincent Guittot
On 19 February 2013 11:29, Vincent Guittot wrote: > On 18 February 2013 16:40, Frederic Weisbecker wrote: >> 2013/2/18 Vincent Guittot : >>> On 18 February 2013 15:38, Frederic Weisbecker wrote: I pasted the original at: http://pastebin.com/DMm5U8J8 >>> >>> We can clear the idle flag only

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-19 Thread Vincent Guittot
On 18 February 2013 16:40, Frederic Weisbecker wrote: > 2013/2/18 Vincent Guittot : >> On 18 February 2013 15:38, Frederic Weisbecker wrote: >>> I pasted the original at: http://pastebin.com/DMm5U8J8 >> >> We can clear the idle flag only in the nohz_kick_needed which will not >> be called if the

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-19 Thread Vincent Guittot
On 18 February 2013 16:40, Frederic Weisbecker fweis...@gmail.com wrote: 2013/2/18 Vincent Guittot vincent.guit...@linaro.org: On 18 February 2013 15:38, Frederic Weisbecker fweis...@gmail.com wrote: I pasted the original at: http://pastebin.com/DMm5U8J8 We can clear the idle flag only in the

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-19 Thread Vincent Guittot
On 19 February 2013 11:29, Vincent Guittot vincent.guit...@linaro.org wrote: On 18 February 2013 16:40, Frederic Weisbecker fweis...@gmail.com wrote: 2013/2/18 Vincent Guittot vincent.guit...@linaro.org: On 18 February 2013 15:38, Frederic Weisbecker fweis...@gmail.com wrote: I pasted the

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-18 Thread Frederic Weisbecker
2013/2/18 Vincent Guittot : > On 18 February 2013 15:38, Frederic Weisbecker wrote: >> I pasted the original at: http://pastebin.com/DMm5U8J8 > > We can clear the idle flag only in the nohz_kick_needed which will not > be called if the sched_domain is NULL so the sequence will be > > = CPU 0 =

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-18 Thread Vincent Guittot
On 18 February 2013 15:38, Frederic Weisbecker wrote: > 2013/2/18 Frederic Weisbecker : >> 2013/2/8 Vincent Guittot : >>> On 8 February 2013 16:35, Frederic Weisbecker wrote: What if the following happen (inventing function names but you get the idea): CPU 0

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-18 Thread Frederic Weisbecker
2013/2/18 Frederic Weisbecker : > 2013/2/8 Vincent Guittot : >> On 8 February 2013 16:35, Frederic Weisbecker wrote: >>> What if the following happen (inventing function names but you get the >>> idea): >>> >>> CPU 0 CPU 1 >>> >>> dom = new_domain(...) {

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-18 Thread Frederic Weisbecker
2013/2/8 Vincent Guittot : > On 8 February 2013 16:35, Frederic Weisbecker wrote: >> What if the following happen (inventing function names but you get the idea): >> >> CPU 0 CPU 1 >> >> dom = new_domain(...) { >>nr_cpus_busy = 0; >>

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-18 Thread Frederic Weisbecker
2013/2/8 Vincent Guittot vincent.guit...@linaro.org: On 8 February 2013 16:35, Frederic Weisbecker fweis...@gmail.com wrote: What if the following happen (inventing function names but you get the idea): CPU 0 CPU 1 dom = new_domain(...) {

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-18 Thread Frederic Weisbecker
2013/2/18 Frederic Weisbecker fweis...@gmail.com: 2013/2/8 Vincent Guittot vincent.guit...@linaro.org: On 8 February 2013 16:35, Frederic Weisbecker fweis...@gmail.com wrote: What if the following happen (inventing function names but you get the idea): CPU 0

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-18 Thread Vincent Guittot
On 18 February 2013 15:38, Frederic Weisbecker fweis...@gmail.com wrote: 2013/2/18 Frederic Weisbecker fweis...@gmail.com: 2013/2/8 Vincent Guittot vincent.guit...@linaro.org: On 8 February 2013 16:35, Frederic Weisbecker fweis...@gmail.com wrote: What if the following happen (inventing

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-18 Thread Frederic Weisbecker
2013/2/18 Vincent Guittot vincent.guit...@linaro.org: On 18 February 2013 15:38, Frederic Weisbecker fweis...@gmail.com wrote: I pasted the original at: http://pastebin.com/DMm5U8J8 We can clear the idle flag only in the nohz_kick_needed which will not be called if the sched_domain is NULL so

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-08 Thread Vincent Guittot
On 8 February 2013 16:35, Frederic Weisbecker wrote: > 2013/2/4 Vincent Guittot : >> On 1 February 2013 19:03, Frederic Weisbecker wrote: diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 257002c..fd41924 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-08 Thread Frederic Weisbecker
2013/2/4 Vincent Guittot : > On 1 February 2013 19:03, Frederic Weisbecker wrote: >>> diff --git a/kernel/sched/core.c b/kernel/sched/core.c >>> index 257002c..fd41924 100644 >>> --- a/kernel/sched/core.c >>> +++ b/kernel/sched/core.c >>> @@ -5884,6 +5884,7 @@ static void

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-08 Thread Frederic Weisbecker
2013/2/4 Vincent Guittot vincent.guit...@linaro.org: On 1 February 2013 19:03, Frederic Weisbecker fweis...@gmail.com wrote: diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 257002c..fd41924 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -5884,6 +5884,7 @@ static

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-08 Thread Vincent Guittot
On 8 February 2013 16:35, Frederic Weisbecker fweis...@gmail.com wrote: 2013/2/4 Vincent Guittot vincent.guit...@linaro.org: On 1 February 2013 19:03, Frederic Weisbecker fweis...@gmail.com wrote: diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 257002c..fd41924 100644 ---

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-04 Thread Vincent Guittot
On 1 February 2013 19:03, Frederic Weisbecker wrote: > 2013/1/29 Vincent Guittot : >> On my smp platform which is made of 5 cores in 2 clusters,I have the >> nr_busy_cpu field of sched_group_power struct that is not null when the >> platform is fully idle. The root cause seems to be: >> During

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-04 Thread Vincent Guittot
On 1 February 2013 19:03, Frederic Weisbecker fweis...@gmail.com wrote: 2013/1/29 Vincent Guittot vincent.guit...@linaro.org: On my smp platform which is made of 5 cores in 2 clusters,I have the nr_busy_cpu field of sched_group_power struct that is not null when the platform is fully idle. The

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-01 Thread Frederic Weisbecker
2013/1/29 Vincent Guittot : > On my smp platform which is made of 5 cores in 2 clusters,I have the > nr_busy_cpu field of sched_group_power struct that is not null when the > platform is fully idle. The root cause seems to be: > During the boot sequence, some CPUs reach the idle loop and set their

Re: [PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-02-01 Thread Frederic Weisbecker
2013/1/29 Vincent Guittot vincent.guit...@linaro.org: On my smp platform which is made of 5 cores in 2 clusters,I have the nr_busy_cpu field of sched_group_power struct that is not null when the platform is fully idle. The root cause seems to be: During the boot sequence, some CPUs reach the

[PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-01-29 Thread Vincent Guittot
On my smp platform which is made of 5 cores in 2 clusters,I have the nr_busy_cpu field of sched_group_power struct that is not null when the platform is fully idle. The root cause seems to be: During the boot sequence, some CPUs reach the idle loop and set their NOHZ_IDLE flag while waiting for

[PATCH v2 1/2] sched: fix init NOHZ_IDLE flag

2013-01-29 Thread Vincent Guittot
On my smp platform which is made of 5 cores in 2 clusters,I have the nr_busy_cpu field of sched_group_power struct that is not null when the platform is fully idle. The root cause seems to be: During the boot sequence, some CPUs reach the idle loop and set their NOHZ_IDLE flag while waiting for