Re: [PATCH v2 1/3] ASoC: rockchip: Parse dai links from dts

2017-08-16 Thread jeffy
Hi Matthias, On 08/17/2017 07:50 AM, Matthias Kaehlcke wrote: El Thu, Aug 17, 2017 at 06:55:20AM +0800 jeffy ha dit: hi matthias, thanks for your suggestion. On 08/17/2017 05:59 AM, Matthias Kaehlcke wrote: El Thu, Aug 10, 2017 at 12:54:56PM +0800 Jeffy Chen ha dit: Refactor

Re: [PATCH v2 1/3] ASoC: rockchip: Parse dai links from dts

2017-08-16 Thread jeffy
Hi Matthias, On 08/17/2017 07:50 AM, Matthias Kaehlcke wrote: El Thu, Aug 17, 2017 at 06:55:20AM +0800 jeffy ha dit: hi matthias, thanks for your suggestion. On 08/17/2017 05:59 AM, Matthias Kaehlcke wrote: El Thu, Aug 10, 2017 at 12:54:56PM +0800 Jeffy Chen ha dit: Refactor

Re: [PATCH v2 1/3] ASoC: rockchip: Parse dai links from dts

2017-08-16 Thread Matthias Kaehlcke
El Thu, Aug 17, 2017 at 06:55:20AM +0800 jeffy ha dit: > hi matthias, > > thanks for your suggestion. > > On 08/17/2017 05:59 AM, Matthias Kaehlcke wrote: > >El Thu, Aug 10, 2017 at 12:54:56PM +0800 Jeffy Chen ha dit: > > > >>>Refactor rockchip_sound_probe, parse dai links from dts instead of >

Re: [PATCH v2 1/3] ASoC: rockchip: Parse dai links from dts

2017-08-16 Thread Matthias Kaehlcke
El Thu, Aug 17, 2017 at 06:55:20AM +0800 jeffy ha dit: > hi matthias, > > thanks for your suggestion. > > On 08/17/2017 05:59 AM, Matthias Kaehlcke wrote: > >El Thu, Aug 10, 2017 at 12:54:56PM +0800 Jeffy Chen ha dit: > > > >>>Refactor rockchip_sound_probe, parse dai links from dts instead of >

Re: [PATCH v2 1/3] ASoC: rockchip: Parse dai links from dts

2017-08-16 Thread jeffy
hi matthias, thanks for your suggestion. On 08/17/2017 05:59 AM, Matthias Kaehlcke wrote: El Thu, Aug 10, 2017 at 12:54:56PM +0800 Jeffy Chen ha dit: >Refactor rockchip_sound_probe, parse dai links from dts instead of >hard coding them. Mark doesn't seem to be overly convinced that

Re: [PATCH v2 1/3] ASoC: rockchip: Parse dai links from dts

2017-08-16 Thread jeffy
hi matthias, thanks for your suggestion. On 08/17/2017 05:59 AM, Matthias Kaehlcke wrote: El Thu, Aug 10, 2017 at 12:54:56PM +0800 Jeffy Chen ha dit: >Refactor rockchip_sound_probe, parse dai links from dts instead of >hard coding them. Mark doesn't seem to be overly convinced that

Re: [PATCH v2 1/3] ASoC: rockchip: Parse dai links from dts

2017-08-16 Thread Matthias Kaehlcke
El Thu, Aug 10, 2017 at 12:54:56PM +0800 Jeffy Chen ha dit: > Refactor rockchip_sound_probe, parse dai links from dts instead of > hard coding them. Mark doesn't seem to be overly convinced that 'rockchip,codec-names' is a good idea (https://lkml.org/lkml/2017/8/10/511). How about using

Re: [PATCH v2 1/3] ASoC: rockchip: Parse dai links from dts

2017-08-16 Thread Matthias Kaehlcke
El Thu, Aug 10, 2017 at 12:54:56PM +0800 Jeffy Chen ha dit: > Refactor rockchip_sound_probe, parse dai links from dts instead of > hard coding them. Mark doesn't seem to be overly convinced that 'rockchip,codec-names' is a good idea (https://lkml.org/lkml/2017/8/10/511). How about using

[PATCH v2 1/3] ASoC: rockchip: Parse dai links from dts

2017-08-09 Thread Jeffy Chen
Refactor rockchip_sound_probe, parse dai links from dts instead of hard coding them. Signed-off-by: Jeffy Chen --- Changes in v2: Let rockchip,codec-names be a required property, because we plan to add more supported codecs to the fixed dai link list in the driver.

[PATCH v2 1/3] ASoC: rockchip: Parse dai links from dts

2017-08-09 Thread Jeffy Chen
Refactor rockchip_sound_probe, parse dai links from dts instead of hard coding them. Signed-off-by: Jeffy Chen --- Changes in v2: Let rockchip,codec-names be a required property, because we plan to add more supported codecs to the fixed dai link list in the driver.