Re: [alsa-devel] [PATCH v2 1/5] ASoC: qcom: sdm845: Add board specific dapm widgets
On Wed, Dec 05, 2018 at 02:18:25PM +, Srinivas Kandagatla wrote: > Am not sure why are you sending patches that are already applied to > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/log/?h=for-next > > It just wastes other people time in looking at something which is already > applied. > Also it looks like you have not picked acked-bys on some of the patches! I've applied the patches with acks, please resend anything else that needs applying. signature.asc Description: PGP signature
Re: [alsa-devel] [PATCH v2 1/5] ASoC: qcom: sdm845: Add board specific dapm widgets
On Wed, Dec 05, 2018 at 02:18:25PM +, Srinivas Kandagatla wrote: > Am not sure why are you sending patches that are already applied to > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/log/?h=for-next > > It just wastes other people time in looking at something which is already > applied. > Also it looks like you have not picked acked-bys on some of the patches! I've applied the patches with acks, please resend anything else that needs applying. signature.asc Description: PGP signature
Re: [alsa-devel] [PATCH v2 1/5] ASoC: qcom: sdm845: Add board specific dapm widgets
Hi Jimmy, On 28/11/18 09:00, Cheng-Yi Chiang wrote: Add board specific dapm widgets so these widgets can be used in the route. Signed-off-by: Rohit kumar Signed-off-by: Cheng-Yi Chiang --- sound/soc/qcom/sdm845.c | 10 ++ 1 file changed, 10 insertions(+) Am not sure why are you sending patches that are already applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/log/?h=for-next It just wastes other people time in looking at something which is already applied. Also it looks like you have not picked acked-bys on some of the patches! thanks, srini
Re: [alsa-devel] [PATCH v2 1/5] ASoC: qcom: sdm845: Add board specific dapm widgets
Hi Jimmy, On 28/11/18 09:00, Cheng-Yi Chiang wrote: Add board specific dapm widgets so these widgets can be used in the route. Signed-off-by: Rohit kumar Signed-off-by: Cheng-Yi Chiang --- sound/soc/qcom/sdm845.c | 10 ++ 1 file changed, 10 insertions(+) Am not sure why are you sending patches that are already applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/log/?h=for-next It just wastes other people time in looking at something which is already applied. Also it looks like you have not picked acked-bys on some of the patches! thanks, srini
[PATCH v2 1/5] ASoC: qcom: sdm845: Add board specific dapm widgets
Add board specific dapm widgets so these widgets can be used
in the route.
Signed-off-by: Rohit kumar
Signed-off-by: Cheng-Yi Chiang
---
sound/soc/qcom/sdm845.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/sound/soc/qcom/sdm845.c b/sound/soc/qcom/sdm845.c
index 58593db2ab151..95d8d4422dae0 100644
--- a/sound/soc/qcom/sdm845.c
+++ b/sound/soc/qcom/sdm845.c
@@ -212,6 +212,14 @@ static int sdm845_be_hw_params_fixup(struct
snd_soc_pcm_runtime *rtd,
return 0;
}
+static const struct snd_soc_dapm_widget sdm845_snd_widgets[] = {
+ SND_SOC_DAPM_HP("Headphone Jack", NULL),
+ SND_SOC_DAPM_MIC("Headset Mic", NULL),
+ SND_SOC_DAPM_SPK("Left Spk", NULL),
+ SND_SOC_DAPM_SPK("Right Spk", NULL),
+ SND_SOC_DAPM_MIC("Int Mic", NULL),
+};
+
static void sdm845_add_be_ops(struct snd_soc_card *card)
{
struct snd_soc_dai_link *link;
@@ -243,6 +251,8 @@ static int sdm845_snd_platform_probe(struct platform_device
*pdev)
goto data_alloc_fail;
}
+ card->dapm_widgets = sdm845_snd_widgets;
+ card->num_dapm_widgets = ARRAY_SIZE(sdm845_snd_widgets);
card->dev = dev;
dev_set_drvdata(dev, card);
ret = qcom_snd_parse_of(card);
--
2.20.0.rc0.387.gc7a69e6b6c-goog
[PATCH v2 1/5] ASoC: qcom: sdm845: Add board specific dapm widgets
Add board specific dapm widgets so these widgets can be used
in the route.
Signed-off-by: Rohit kumar
Signed-off-by: Cheng-Yi Chiang
---
sound/soc/qcom/sdm845.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/sound/soc/qcom/sdm845.c b/sound/soc/qcom/sdm845.c
index 58593db2ab151..95d8d4422dae0 100644
--- a/sound/soc/qcom/sdm845.c
+++ b/sound/soc/qcom/sdm845.c
@@ -212,6 +212,14 @@ static int sdm845_be_hw_params_fixup(struct
snd_soc_pcm_runtime *rtd,
return 0;
}
+static const struct snd_soc_dapm_widget sdm845_snd_widgets[] = {
+ SND_SOC_DAPM_HP("Headphone Jack", NULL),
+ SND_SOC_DAPM_MIC("Headset Mic", NULL),
+ SND_SOC_DAPM_SPK("Left Spk", NULL),
+ SND_SOC_DAPM_SPK("Right Spk", NULL),
+ SND_SOC_DAPM_MIC("Int Mic", NULL),
+};
+
static void sdm845_add_be_ops(struct snd_soc_card *card)
{
struct snd_soc_dai_link *link;
@@ -243,6 +251,8 @@ static int sdm845_snd_platform_probe(struct platform_device
*pdev)
goto data_alloc_fail;
}
+ card->dapm_widgets = sdm845_snd_widgets;
+ card->num_dapm_widgets = ARRAY_SIZE(sdm845_snd_widgets);
card->dev = dev;
dev_set_drvdata(dev, card);
ret = qcom_snd_parse_of(card);
--
2.20.0.rc0.387.gc7a69e6b6c-goog
