Re: [PATCH v2 10/10] x86/entry/32: Add and check a stack canary for the SYSENTER stack

2016-03-09 Thread Andy Lutomirski
On Mon, Mar 7, 2016 at 10:40 PM, Borislav Petkov wrote: > On Sat, Mar 05, 2016 at 09:52:23PM -0800, Andy Lutomirski wrote: > > <--- ? > > So all patches before are nice and verbose in explaining what they do. > Where did the commit message of this one disappear? > > :-) > > Or is

Re: [PATCH v2 10/10] x86/entry/32: Add and check a stack canary for the SYSENTER stack

2016-03-09 Thread Andy Lutomirski
On Mon, Mar 7, 2016 at 10:40 PM, Borislav Petkov wrote: > On Sat, Mar 05, 2016 at 09:52:23PM -0800, Andy Lutomirski wrote: > > <--- ? > > So all patches before are nice and verbose in explaining what they do. > Where did the commit message of this one disappear? > > :-) > > Or is it that obvious

Re: [PATCH v2 10/10] x86/entry/32: Add and check a stack canary for the SYSENTER stack

2016-03-07 Thread Borislav Petkov
On Sat, Mar 05, 2016 at 09:52:23PM -0800, Andy Lutomirski wrote: <--- ? So all patches before are nice and verbose in explaining what they do. Where did the commit message of this one disappear? :-) Or is it that obvious that we should have a stack canary? How about some text *why* we need it?

Re: [PATCH v2 10/10] x86/entry/32: Add and check a stack canary for the SYSENTER stack

2016-03-07 Thread Borislav Petkov
On Sat, Mar 05, 2016 at 09:52:23PM -0800, Andy Lutomirski wrote: <--- ? So all patches before are nice and verbose in explaining what they do. Where did the commit message of this one disappear? :-) Or is it that obvious that we should have a stack canary? How about some text *why* we need it?

[PATCH v2 10/10] x86/entry/32: Add and check a stack canary for the SYSENTER stack

2016-03-05 Thread Andy Lutomirski
Signed-off-by: Andy Lutomirski --- arch/x86/include/asm/processor.h | 3 ++- arch/x86/kernel/process.c| 3 +++ arch/x86/kernel/traps.c | 8 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/processor.h

[PATCH v2 10/10] x86/entry/32: Add and check a stack canary for the SYSENTER stack

2016-03-05 Thread Andy Lutomirski
Signed-off-by: Andy Lutomirski --- arch/x86/include/asm/processor.h | 3 ++- arch/x86/kernel/process.c| 3 +++ arch/x86/kernel/traps.c | 8 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h