Re: [PATCH v2 15/22] mmc: tmio: change bus_shift to unsigned int

2017-12-04 Thread Wolfram Sang 
On Sat, Nov 25, 2017 at 01:24:50AM +0900, Masahiro Yamada wrote:
> Sane values for bus_shift are:
>0 - for 16 bit bus
>1 - for 32 bit bus
>2 - for 64 bit bus
> 
> "unsigned long" is too much.
> 
> Signed-off-by: Masahiro Yamada 

Reviewed-by: Wolfram Sang

Re: [PATCH v2 15/22] mmc: tmio: change bus_shift to unsigned int

2017-12-04 Thread Wolfram Sang 
On Sat, Nov 25, 2017 at 01:24:50AM +0900, Masahiro Yamada wrote:
> Sane values for bus_shift are:
>0 - for 16 bit bus
>1 - for 32 bit bus
>2 - for 64 bit bus
> 
> "unsigned long" is too much.
> 
> Signed-off-by: Masahiro Yamada 

Reviewed-by: Wolfram Sang

[PATCH v2 15/22] mmc: tmio: change bus_shift to unsigned int

2017-11-24 Thread Masahiro Yamada 
Sane values for bus_shift are:
   0 - for 16 bit bus
   1 - for 32 bit bus
   2 - for 64 bit bus

"unsigned long" is too much.

Signed-off-by: Masahiro Yamada 
---

Changes in v2:
  - Newly added

 drivers/mmc/host/tmio_mmc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h
index 9f083dc..27894474 100644
--- a/drivers/mmc/host/tmio_mmc.h
+++ b/drivers/mmc/host/tmio_mmc.h
@@ -139,7 +139,7 @@ struct tmio_mmc_host {
struct scatterlist  *sg_orig;
unsigned intsg_len;
unsigned intsg_off;
-   unsigned long   bus_shift;
+   unsigned intbus_shift;
 
struct platform_device *pdev;
struct tmio_mmc_data *pdata;
-- 
2.7.4

[PATCH v2 15/22] mmc: tmio: change bus_shift to unsigned int

2017-11-24 Thread Masahiro Yamada 
Sane values for bus_shift are:
   0 - for 16 bit bus
   1 - for 32 bit bus
   2 - for 64 bit bus

"unsigned long" is too much.

Signed-off-by: Masahiro Yamada 
---

Changes in v2:
  - Newly added

 drivers/mmc/host/tmio_mmc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h
index 9f083dc..27894474 100644
--- a/drivers/mmc/host/tmio_mmc.h
+++ b/drivers/mmc/host/tmio_mmc.h
@@ -139,7 +139,7 @@ struct tmio_mmc_host {
struct scatterlist  *sg_orig;
unsigned intsg_len;
unsigned intsg_off;
-   unsigned long   bus_shift;
+   unsigned intbus_shift;
 
struct platform_device *pdev;
struct tmio_mmc_data *pdata;
-- 
2.7.4