Re: [PATCH v2 2/2] ASoC: ak5558: Add bindings for AK5558 ADC

2018-02-04 Thread Rob Herring 
On Fri, Feb 02, 2018 at 06:20:06PM +0200, Daniel Baluta wrote:
> Signed-off-by: Daniel Baluta 
> ---
>  Documentation/devicetree/bindings/sound/ak5558.txt | 23 
> ++
>  1 file changed, 23 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/ak5558.txt
> 
> diff --git a/Documentation/devicetree/bindings/sound/ak5558.txt 
> b/Documentation/devicetree/bindings/sound/ak5558.txt
> new file mode 100644
> index 000..61c85568
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/ak5558.txt
> @@ -0,0 +1,23 @@
> +AK5558 8 channel differential 32-bit delta-sigma ADC
> +
> +This device supports I2C mode only.
> +
> +Required properties:
> +
> +- compatible : "asahi-kasei,ak5558"
> +- reg : The I2C address of the device for I2C.
> +
> +Optional properties:
> +
> +- reset-gpios: A GPIO specifier for the GPIO controlling
> + the power down & reset pin.
> +
> +Example:
> +
> +&i2c {
> + ak5558: ak5558@10 {

adc@10

> + compatible = "asahi-kasei,ak5558";
> + reg = <0x10>;
> + reset-gpios = <&gpio1 10 GPIO_ACTIVE_LOW>;
> + };
> +};
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [alsa-devel] [PATCH v2 2/2] ASoC: ak5558: Add bindings for AK5558 ADC

2018-02-02 Thread Fabio Estevam 
Hi Daniel,

You missed to add the dt maintainer, Rob Herring.

On Fri, Feb 2, 2018 at 2:20 PM, Daniel Baluta  wrote:
> Signed-off-by: Daniel Baluta 

Please add a commit log.

> ---
>  Documentation/devicetree/bindings/sound/ak5558.txt | 23 
> ++
>  1 file changed, 23 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/ak5558.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/ak5558.txt 
> b/Documentation/devicetree/bindings/sound/ak5558.txt
> new file mode 100644
> index 000..61c85568
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/ak5558.txt
> @@ -0,0 +1,23 @@
> +AK5558 8 channel differential 32-bit delta-sigma ADC
> +
> +This device supports I2C mode only.
> +
> +Required properties:
> +
> +- compatible : "asahi-kasei,ak5558"
> +- reg : The I2C address of the device for I2C.

No need for repeating "I2C" in this phrase.

"- reg : The I2C address of the device." would be better.

> +Optional properties:
> +
> +- reset-gpios: A GPIO specifier for the GPIO controlling
> +   the power down & reset pin.

No need for repeating "GPIO" in this phrase.

"- reset-gpios: A GPIO specifier for the the power down & reset pin."
would be better.

[PATCH v2 2/2] ASoC: ak5558: Add bindings for AK5558 ADC

2018-02-02 Thread Daniel Baluta 
Signed-off-by: Daniel Baluta 
---
 Documentation/devicetree/bindings/sound/ak5558.txt | 23 ++
 1 file changed, 23 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/ak5558.txt

diff --git a/Documentation/devicetree/bindings/sound/ak5558.txt 
b/Documentation/devicetree/bindings/sound/ak5558.txt
new file mode 100644
index 000..61c85568
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/ak5558.txt
@@ -0,0 +1,23 @@
+AK5558 8 channel differential 32-bit delta-sigma ADC
+
+This device supports I2C mode only.
+
+Required properties:
+
+- compatible : "asahi-kasei,ak5558"
+- reg : The I2C address of the device for I2C.
+
+Optional properties:
+
+- reset-gpios: A GPIO specifier for the GPIO controlling
+   the power down & reset pin.
+
+Example:
+
+&i2c {
+   ak5558: ak5558@10 {
+   compatible = "asahi-kasei,ak5558";
+   reg = <0x10>;
+   reset-gpios = <&gpio1 10 GPIO_ACTIVE_LOW>;
+   };
+};
-- 
2.7.4