RE: [PATCH v2 2/2] MIPS: DTS: img: add device tree for Marduk board

2016-11-18 Thread James Hartley 
Hi Rahul,

> -Original Message-
> From: Rob Herring [mailto:r...@kernel.org]
> Sent: 18 October 2016 15:14
> To: Rahul Bedarkar
> Cc: Ralf Baechle; Mark Rutland; James Hartley; linux-m...@linux-mips.org;
> devicet...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 2/2] MIPS: DTS: img: add device tree for Marduk
> board
> 
> On Fri, Oct 14, 2016 at 11:25:55AM +0530, Rahul Bedarkar wrote:
> > Add support for Imagination Technologies' Marduk board which is based
> > on Pistachio SoC. It is also known as Creator Ci40. Marduk is legacy
> > name and will be there for decades.
> >
> > Documentation for this board can be found on
> > https://docs.creatordev.io/ci40/
> >
> > This patch adds initial support for board with following peripherals:
> >
> > * PWM based heartbeat LED
> > * GPIO based buttons
> > * SPI NOR flash on SPI1
> > * UART0 and UART1
> > * SD card
> > * Ethernet
> > * USB
> > * PWM
> > * ADC
> > * I2C
> >
> > Signed-off-by: Rahul Bedarkar <rahul.bedar...@imgtec.com>
> > ---
> > Changes in v2:
> >   - Correct RAM size. It is 256MB instead of 128MB.
> >   - Rename nodes pwm_leds -> leds and gpio_keys -> keys (Suggested by
> Rob Herring)
> >   - Don't use '_' in node name for internal_dac_supply (Suggested by Rob
> Herring)
> >   - Add part name in compatible string for spi-nor (Suggested by Rob
> > Herring)
> > ---
> >  .../bindings/mips/img/pistachio-marduk.txt |  10 ++
> >  MAINTAINERS|   6 +
> >  arch/mips/boot/dts/img/Makefile|   9 ++
> >  arch/mips/boot/dts/img/pistachio_marduk.dts| 163
> +
> >  4 files changed, 188 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/mips/img/pistachio-marduk.txt
> >  create mode 100644 arch/mips/boot/dts/img/Makefile  create mode
> > 100644 arch/mips/boot/dts/img/pistachio_marduk.dts
> 
> Acked-by: Rob Herring <r...@kernel.org>

Acked-by: James Hartley <james.hart...@imgtec.com>

RE: [PATCH v2 2/2] MIPS: DTS: img: add device tree for Marduk board

2016-11-18 Thread James Hartley 
Hi Rahul,

> -Original Message-
> From: Rob Herring [mailto:r...@kernel.org]
> Sent: 18 October 2016 15:14
> To: Rahul Bedarkar
> Cc: Ralf Baechle; Mark Rutland; James Hartley; linux-m...@linux-mips.org;
> devicet...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 2/2] MIPS: DTS: img: add device tree for Marduk
> board
> 
> On Fri, Oct 14, 2016 at 11:25:55AM +0530, Rahul Bedarkar wrote:
> > Add support for Imagination Technologies' Marduk board which is based
> > on Pistachio SoC. It is also known as Creator Ci40. Marduk is legacy
> > name and will be there for decades.
> >
> > Documentation for this board can be found on
> > https://docs.creatordev.io/ci40/
> >
> > This patch adds initial support for board with following peripherals:
> >
> > * PWM based heartbeat LED
> > * GPIO based buttons
> > * SPI NOR flash on SPI1
> > * UART0 and UART1
> > * SD card
> > * Ethernet
> > * USB
> > * PWM
> > * ADC
> > * I2C
> >
> > Signed-off-by: Rahul Bedarkar 
> > ---
> > Changes in v2:
> >   - Correct RAM size. It is 256MB instead of 128MB.
> >   - Rename nodes pwm_leds -> leds and gpio_keys -> keys (Suggested by
> Rob Herring)
> >   - Don't use '_' in node name for internal_dac_supply (Suggested by Rob
> Herring)
> >   - Add part name in compatible string for spi-nor (Suggested by Rob
> > Herring)
> > ---
> >  .../bindings/mips/img/pistachio-marduk.txt |  10 ++
> >  MAINTAINERS|   6 +
> >  arch/mips/boot/dts/img/Makefile|   9 ++
> >  arch/mips/boot/dts/img/pistachio_marduk.dts| 163
> +
> >  4 files changed, 188 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/mips/img/pistachio-marduk.txt
> >  create mode 100644 arch/mips/boot/dts/img/Makefile  create mode
> > 100644 arch/mips/boot/dts/img/pistachio_marduk.dts
> 
> Acked-by: Rob Herring 

Acked-by: James Hartley

Re: [PATCH v2 2/2] MIPS: DTS: img: add device tree for Marduk board

2016-10-18 Thread Rob Herring 
On Fri, Oct 14, 2016 at 11:25:55AM +0530, Rahul Bedarkar wrote:
> Add support for Imagination Technologies' Marduk board which is based
> on Pistachio SoC. It is also known as Creator Ci40. Marduk is legacy
> name and will be there for decades.
> 
> Documentation for this board can be found on
> https://docs.creatordev.io/ci40/
> 
> This patch adds initial support for board with following peripherals:
> 
> * PWM based heartbeat LED
> * GPIO based buttons
> * SPI NOR flash on SPI1
> * UART0 and UART1
> * SD card
> * Ethernet
> * USB
> * PWM
> * ADC
> * I2C
> 
> Signed-off-by: Rahul Bedarkar 
> ---
> Changes in v2:
>   - Correct RAM size. It is 256MB instead of 128MB.
>   - Rename nodes pwm_leds -> leds and gpio_keys -> keys (Suggested by Rob 
> Herring)
>   - Don't use '_' in node name for internal_dac_supply (Suggested by Rob 
> Herring)
>   - Add part name in compatible string for spi-nor (Suggested by Rob Herring)
> ---
>  .../bindings/mips/img/pistachio-marduk.txt |  10 ++
>  MAINTAINERS|   6 +
>  arch/mips/boot/dts/img/Makefile|   9 ++
>  arch/mips/boot/dts/img/pistachio_marduk.dts| 163 
> +
>  4 files changed, 188 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/mips/img/pistachio-marduk.txt
>  create mode 100644 arch/mips/boot/dts/img/Makefile
>  create mode 100644 arch/mips/boot/dts/img/pistachio_marduk.dts

Acked-by: Rob Herring

Re: [PATCH v2 2/2] MIPS: DTS: img: add device tree for Marduk board

2016-10-18 Thread Rob Herring 
On Fri, Oct 14, 2016 at 11:25:55AM +0530, Rahul Bedarkar wrote:
> Add support for Imagination Technologies' Marduk board which is based
> on Pistachio SoC. It is also known as Creator Ci40. Marduk is legacy
> name and will be there for decades.
> 
> Documentation for this board can be found on
> https://docs.creatordev.io/ci40/
> 
> This patch adds initial support for board with following peripherals:
> 
> * PWM based heartbeat LED
> * GPIO based buttons
> * SPI NOR flash on SPI1
> * UART0 and UART1
> * SD card
> * Ethernet
> * USB
> * PWM
> * ADC
> * I2C
> 
> Signed-off-by: Rahul Bedarkar 
> ---
> Changes in v2:
>   - Correct RAM size. It is 256MB instead of 128MB.
>   - Rename nodes pwm_leds -> leds and gpio_keys -> keys (Suggested by Rob 
> Herring)
>   - Don't use '_' in node name for internal_dac_supply (Suggested by Rob 
> Herring)
>   - Add part name in compatible string for spi-nor (Suggested by Rob Herring)
> ---
>  .../bindings/mips/img/pistachio-marduk.txt |  10 ++
>  MAINTAINERS|   6 +
>  arch/mips/boot/dts/img/Makefile|   9 ++
>  arch/mips/boot/dts/img/pistachio_marduk.dts| 163 
> +
>  4 files changed, 188 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/mips/img/pistachio-marduk.txt
>  create mode 100644 arch/mips/boot/dts/img/Makefile
>  create mode 100644 arch/mips/boot/dts/img/pistachio_marduk.dts

Acked-by: Rob Herring

[PATCH v2 2/2] MIPS: DTS: img: add device tree for Marduk board

2016-10-13 Thread Rahul Bedarkar 
Add support for Imagination Technologies' Marduk board which is based
on Pistachio SoC. It is also known as Creator Ci40. Marduk is legacy
name and will be there for decades.

Documentation for this board can be found on
https://docs.creatordev.io/ci40/

This patch adds initial support for board with following peripherals:

* PWM based heartbeat LED
* GPIO based buttons
* SPI NOR flash on SPI1
* UART0 and UART1
* SD card
* Ethernet
* USB
* PWM
* ADC
* I2C

Signed-off-by: Rahul Bedarkar 
---
Changes in v2:
  - Correct RAM size. It is 256MB instead of 128MB.
  - Rename nodes pwm_leds -> leds and gpio_keys -> keys (Suggested by Rob 
Herring)
  - Don't use '_' in node name for internal_dac_supply (Suggested by Rob 
Herring)
  - Add part name in compatible string for spi-nor (Suggested by Rob Herring)
---
 .../bindings/mips/img/pistachio-marduk.txt |  10 ++
 MAINTAINERS|   6 +
 arch/mips/boot/dts/img/Makefile|   9 ++
 arch/mips/boot/dts/img/pistachio_marduk.dts| 163 +
 4 files changed, 188 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/mips/img/pistachio-marduk.txt
 create mode 100644 arch/mips/boot/dts/img/Makefile
 create mode 100644 arch/mips/boot/dts/img/pistachio_marduk.dts

diff --git a/Documentation/devicetree/bindings/mips/img/pistachio-marduk.txt 
b/Documentation/devicetree/bindings/mips/img/pistachio-marduk.txt
new file mode 100644
index 000..2d5126d
--- /dev/null
+++ b/Documentation/devicetree/bindings/mips/img/pistachio-marduk.txt
@@ -0,0 +1,10 @@
+Imagination Technologies' Pistachio SoC based Marduk Board
+==
+
+Compatible string must be "img,pistachio-marduk", "img,pistachio"
+
+Hardware and other related documentation is available at
+https://docs.creatordev.io/ci40/
+
+It is also known as Creator Ci40. Marduk is legacy name and will
+be there for decades.
diff --git a/MAINTAINERS b/MAINTAINERS
index 98bcf06..8e6c962b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7515,6 +7515,12 @@ W:   http://www.kernel.org/doc/man-pages
 L: linux-...@vger.kernel.org
 S: Maintained
 
+MARDUK (CREATOR CI40) DEVICE TREE SUPPORT
+M: Rahul Bedarkar 
+L: linux-m...@linux-mips.org
+S: Maintained
+F: arch/mips/boot/dts/img/pistachio_marduk.dts
+
 MARVELL 88E6XXX ETHERNET SWITCH FABRIC DRIVER
 M: Andrew Lunn 
 M: Vivien Didelot 
diff --git a/arch/mips/boot/dts/img/Makefile b/arch/mips/boot/dts/img/Makefile
new file mode 100644
index 000..69a65f0
--- /dev/null
+++ b/arch/mips/boot/dts/img/Makefile
@@ -0,0 +1,9 @@
+dtb-$(CONFIG_MACH_PISTACHIO)   += pistachio_marduk.dtb
+
+obj-y  += $(patsubst %.dtb, %.dtb.o, $(dtb-y))
+
+# Force kbuild to make empty built-in.o if necessary
+obj-   += dummy.o
+
+always := $(dtb-y)
+clean-files:= *.dtb *.dtb.S
diff --git a/arch/mips/boot/dts/img/pistachio_marduk.dts 
b/arch/mips/boot/dts/img/pistachio_marduk.dts
new file mode 100644
index 000..cf9cebd
--- /dev/null
+++ b/arch/mips/boot/dts/img/pistachio_marduk.dts
@@ -0,0 +1,163 @@
+/*
+ * Copyright (C) 2015, 2016 Imagination Technologies Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * IMG Marduk board is also known as Creator Ci40.
+ */
+
+/dts-v1/;
+
+#include "pistachio.dtsi"
+
+/ {
+   model = "IMG Marduk (Creator Ci40)";
+   compatible = "img,pistachio-marduk", "img,pistachio";
+
+   aliases {
+   serial0 = 
+   serial1 = 
+   ethernet0 = 
+   spi0 = 
+   spi1 = 
+   };
+
+   chosen {
+   bootargs = "root=/dev/sda1 rootwait ro lpj=723968";
+   stdout-path = "serial1:115200";
+   };
+
+   memory {
+   device_type = "memory";
+   reg =  <0x 0x1000>;
+   };
+
+   reg_1v8: fixed-regulator {
+   compatible = "regulator-fixed";
+   regulator-name = "aux_adc_vref";
+   regulator-min-microvolt = <180>;
+   regulator-max-microvolt = <180>;
+   regulator-boot-on;
+   };
+
+   internal_dac_supply: internal-dac-supply {
+   compatible = "regulator-fixed";
+   regulator-name = "internal_dac_supply";
+   regulator-min-microvolt = <180>;
+   regulator-max-microvolt = <180>;
+   };
+
+   leds {
+   compatible = "pwm-leds";
+   heartbeat {
+   label = "marduk:red:heartbeat";
+   pwms = < 3 30>;
+

[PATCH v2 2/2] MIPS: DTS: img: add device tree for Marduk board

2016-10-13 Thread Rahul Bedarkar 
Add support for Imagination Technologies' Marduk board which is based
on Pistachio SoC. It is also known as Creator Ci40. Marduk is legacy
name and will be there for decades.

Documentation for this board can be found on
https://docs.creatordev.io/ci40/

This patch adds initial support for board with following peripherals:

* PWM based heartbeat LED
* GPIO based buttons
* SPI NOR flash on SPI1
* UART0 and UART1
* SD card
* Ethernet
* USB
* PWM
* ADC
* I2C

Signed-off-by: Rahul Bedarkar 
---
Changes in v2:
  - Correct RAM size. It is 256MB instead of 128MB.
  - Rename nodes pwm_leds -> leds and gpio_keys -> keys (Suggested by Rob 
Herring)
  - Don't use '_' in node name for internal_dac_supply (Suggested by Rob 
Herring)
  - Add part name in compatible string for spi-nor (Suggested by Rob Herring)
---
 .../bindings/mips/img/pistachio-marduk.txt |  10 ++
 MAINTAINERS|   6 +
 arch/mips/boot/dts/img/Makefile|   9 ++
 arch/mips/boot/dts/img/pistachio_marduk.dts| 163 +
 4 files changed, 188 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/mips/img/pistachio-marduk.txt
 create mode 100644 arch/mips/boot/dts/img/Makefile
 create mode 100644 arch/mips/boot/dts/img/pistachio_marduk.dts

diff --git a/Documentation/devicetree/bindings/mips/img/pistachio-marduk.txt 
b/Documentation/devicetree/bindings/mips/img/pistachio-marduk.txt
new file mode 100644
index 000..2d5126d
--- /dev/null
+++ b/Documentation/devicetree/bindings/mips/img/pistachio-marduk.txt
@@ -0,0 +1,10 @@
+Imagination Technologies' Pistachio SoC based Marduk Board
+==
+
+Compatible string must be "img,pistachio-marduk", "img,pistachio"
+
+Hardware and other related documentation is available at
+https://docs.creatordev.io/ci40/
+
+It is also known as Creator Ci40. Marduk is legacy name and will
+be there for decades.
diff --git a/MAINTAINERS b/MAINTAINERS
index 98bcf06..8e6c962b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7515,6 +7515,12 @@ W:   http://www.kernel.org/doc/man-pages
 L: linux-...@vger.kernel.org
 S: Maintained
 
+MARDUK (CREATOR CI40) DEVICE TREE SUPPORT
+M: Rahul Bedarkar 
+L: linux-m...@linux-mips.org
+S: Maintained
+F: arch/mips/boot/dts/img/pistachio_marduk.dts
+
 MARVELL 88E6XXX ETHERNET SWITCH FABRIC DRIVER
 M: Andrew Lunn 
 M: Vivien Didelot 
diff --git a/arch/mips/boot/dts/img/Makefile b/arch/mips/boot/dts/img/Makefile
new file mode 100644
index 000..69a65f0
--- /dev/null
+++ b/arch/mips/boot/dts/img/Makefile
@@ -0,0 +1,9 @@
+dtb-$(CONFIG_MACH_PISTACHIO)   += pistachio_marduk.dtb
+
+obj-y  += $(patsubst %.dtb, %.dtb.o, $(dtb-y))
+
+# Force kbuild to make empty built-in.o if necessary
+obj-   += dummy.o
+
+always := $(dtb-y)
+clean-files:= *.dtb *.dtb.S
diff --git a/arch/mips/boot/dts/img/pistachio_marduk.dts 
b/arch/mips/boot/dts/img/pistachio_marduk.dts
new file mode 100644
index 000..cf9cebd
--- /dev/null
+++ b/arch/mips/boot/dts/img/pistachio_marduk.dts
@@ -0,0 +1,163 @@
+/*
+ * Copyright (C) 2015, 2016 Imagination Technologies Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * IMG Marduk board is also known as Creator Ci40.
+ */
+
+/dts-v1/;
+
+#include "pistachio.dtsi"
+
+/ {
+   model = "IMG Marduk (Creator Ci40)";
+   compatible = "img,pistachio-marduk", "img,pistachio";
+
+   aliases {
+   serial0 = 
+   serial1 = 
+   ethernet0 = 
+   spi0 = 
+   spi1 = 
+   };
+
+   chosen {
+   bootargs = "root=/dev/sda1 rootwait ro lpj=723968";
+   stdout-path = "serial1:115200";
+   };
+
+   memory {
+   device_type = "memory";
+   reg =  <0x 0x1000>;
+   };
+
+   reg_1v8: fixed-regulator {
+   compatible = "regulator-fixed";
+   regulator-name = "aux_adc_vref";
+   regulator-min-microvolt = <180>;
+   regulator-max-microvolt = <180>;
+   regulator-boot-on;
+   };
+
+   internal_dac_supply: internal-dac-supply {
+   compatible = "regulator-fixed";
+   regulator-name = "internal_dac_supply";
+   regulator-min-microvolt = <180>;
+   regulator-max-microvolt = <180>;
+   };
+
+   leds {
+   compatible = "pwm-leds";
+   heartbeat {
+   label = "marduk:red:heartbeat";
+   pwms = < 3 30>;
+   max-brightness = <255>;
+   linux,default-trigger = "heartbeat";
+   };
+