Re: [PATCH v2 2/2] pinctrl: stm32: Optimizes and enhances stm32gpio irqchip

[Linus Walleij]

On Fri, Feb 23, 2018 at 9:31 AM, Radoslaw Pietrzyk
 wrote:

> - removes unneeded irq_chip.irq_eoi callback
> - adds irq_chip.irq_set_wake callback for possible
> in the future GPIO wakeup
> - adds irq_chip.irq_ack callback
>
> Signed-off-by: Radoslaw Pietrzyk 

This v2 patch applied with Ludovic's tags.

Yours,
Linus Walleij

Re: [PATCH v2 2/2] pinctrl: stm32: Optimizes and enhances stm32gpio irqchip

[Linus Walleij]

On Fri, Feb 23, 2018 at 9:31 AM, Radoslaw Pietrzyk
 wrote:

> - removes unneeded irq_chip.irq_eoi callback
> - adds irq_chip.irq_set_wake callback for possible
> in the future GPIO wakeup
> - adds irq_chip.irq_ack callback
>
> Signed-off-by: Radoslaw Pietrzyk 

This v2 patch applied with Ludovic's tags.

Yours,
Linus Walleij

Re: [PATCH v2 2/2] pinctrl: stm32: Optimizes and enhances stm32gpio irqchip

[Ludovic BARRE]

hi Radoslaw

Reviewed-by: Ludovic Barre 
Tested-by: Ludovic Barre 

BR
Ludo

On 02/23/2018 09:31 AM, Radoslaw Pietrzyk wrote:

- removes unneeded irq_chip.irq_eoi callback
- adds irq_chip.irq_set_wake callback for possible
in the future GPIO wakeup
- adds irq_chip.irq_ack callback

Signed-off-by: Radoslaw Pietrzyk 
---
  drivers/pinctrl/stm32/pinctrl-stm32.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c 
b/drivers/pinctrl/stm32/pinctrl-stm32.c
index 617df16..6cbcff4 100644
--- a/drivers/pinctrl/stm32/pinctrl-stm32.c
+++ b/drivers/pinctrl/stm32/pinctrl-stm32.c
@@ -268,10 +268,11 @@ static void stm32_gpio_irq_release_resources(struct 
irq_data *irq_data)
  
  static struct irq_chip stm32_gpio_irq_chip = {

.name   = "stm32gpio",
-   .irq_eoi= irq_chip_eoi_parent,
+   .irq_ack   = irq_chip_ack_parent,
.irq_mask   = irq_chip_mask_parent,
.irq_unmask = irq_chip_unmask_parent,
.irq_set_type   = irq_chip_set_type_parent,
+   .irq_set_wake   = irq_chip_set_wake_parent,
.irq_request_resources = stm32_gpio_irq_request_resources,
.irq_release_resources = stm32_gpio_irq_release_resources,
  };

Re: [PATCH v2 2/2] pinctrl: stm32: Optimizes and enhances stm32gpio irqchip

[Ludovic BARRE]

hi Radoslaw

Reviewed-by: Ludovic Barre 
Tested-by: Ludovic Barre 

BR
Ludo

On 02/23/2018 09:31 AM, Radoslaw Pietrzyk wrote:

- removes unneeded irq_chip.irq_eoi callback
- adds irq_chip.irq_set_wake callback for possible
in the future GPIO wakeup
- adds irq_chip.irq_ack callback

Signed-off-by: Radoslaw Pietrzyk 
---
  drivers/pinctrl/stm32/pinctrl-stm32.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c 
b/drivers/pinctrl/stm32/pinctrl-stm32.c
index 617df16..6cbcff4 100644
--- a/drivers/pinctrl/stm32/pinctrl-stm32.c
+++ b/drivers/pinctrl/stm32/pinctrl-stm32.c
@@ -268,10 +268,11 @@ static void stm32_gpio_irq_release_resources(struct 
irq_data *irq_data)
  
  static struct irq_chip stm32_gpio_irq_chip = {

.name   = "stm32gpio",
-   .irq_eoi= irq_chip_eoi_parent,
+   .irq_ack   = irq_chip_ack_parent,
.irq_mask   = irq_chip_mask_parent,
.irq_unmask = irq_chip_unmask_parent,
.irq_set_type   = irq_chip_set_type_parent,
+   .irq_set_wake   = irq_chip_set_wake_parent,
.irq_request_resources = stm32_gpio_irq_request_resources,
.irq_release_resources = stm32_gpio_irq_release_resources,
  };

[PATCH v2 2/2] pinctrl: stm32: Optimizes and enhances stm32gpio irqchip

[Radoslaw Pietrzyk]

- removes unneeded irq_chip.irq_eoi callback
- adds irq_chip.irq_set_wake callback for possible
in the future GPIO wakeup
- adds irq_chip.irq_ack callback

Signed-off-by: Radoslaw Pietrzyk 
---
 drivers/pinctrl/stm32/pinctrl-stm32.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c 
b/drivers/pinctrl/stm32/pinctrl-stm32.c
index 617df16..6cbcff4 100644
--- a/drivers/pinctrl/stm32/pinctrl-stm32.c
+++ b/drivers/pinctrl/stm32/pinctrl-stm32.c
@@ -268,10 +268,11 @@ static void stm32_gpio_irq_release_resources(struct 
irq_data *irq_data)
 
 static struct irq_chip stm32_gpio_irq_chip = {
.name   = "stm32gpio",
-   .irq_eoi= irq_chip_eoi_parent,
+   .irq_ack   = irq_chip_ack_parent,
.irq_mask   = irq_chip_mask_parent,
.irq_unmask = irq_chip_unmask_parent,
.irq_set_type   = irq_chip_set_type_parent,
+   .irq_set_wake   = irq_chip_set_wake_parent,
.irq_request_resources = stm32_gpio_irq_request_resources,
.irq_release_resources = stm32_gpio_irq_release_resources,
 };
-- 
1.9.1

[PATCH v2 2/2] pinctrl: stm32: Optimizes and enhances stm32gpio irqchip

[Radoslaw Pietrzyk]

- removes unneeded irq_chip.irq_eoi callback
- adds irq_chip.irq_set_wake callback for possible
in the future GPIO wakeup
- adds irq_chip.irq_ack callback

Signed-off-by: Radoslaw Pietrzyk 
---
 drivers/pinctrl/stm32/pinctrl-stm32.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c 
b/drivers/pinctrl/stm32/pinctrl-stm32.c
index 617df16..6cbcff4 100644
--- a/drivers/pinctrl/stm32/pinctrl-stm32.c
+++ b/drivers/pinctrl/stm32/pinctrl-stm32.c
@@ -268,10 +268,11 @@ static void stm32_gpio_irq_release_resources(struct 
irq_data *irq_data)
 
 static struct irq_chip stm32_gpio_irq_chip = {
.name   = "stm32gpio",
-   .irq_eoi= irq_chip_eoi_parent,
+   .irq_ack   = irq_chip_ack_parent,
.irq_mask   = irq_chip_mask_parent,
.irq_unmask = irq_chip_unmask_parent,
.irq_set_type   = irq_chip_set_type_parent,
+   .irq_set_wake   = irq_chip_set_wake_parent,
.irq_request_resources = stm32_gpio_irq_request_resources,
.irq_release_resources = stm32_gpio_irq_release_resources,
 };
-- 
1.9.1