Re: [PATCH v2 2/3] time,signal: protect resource use statistics with seqlock

2014-08-19 Thread Mike Galbraith
On Mon, 2014-08-18 at 10:03 -0400, Rik van Riel wrote: > On 08/18/2014 12:44 AM, Mike Galbraith wrote: > > On Sat, 2014-08-16 at 19:50 +0200, Oleg Nesterov wrote: > >> On 08/16, Rik van Riel wrote: > >>> > >>> + do { > >>> + seq = nextseq; > >>> +

Re: [PATCH v2 2/3] time,signal: protect resource use statistics with seqlock

2014-08-19 Thread Mike Galbraith
On Mon, 2014-08-18 at 10:03 -0400, Rik van Riel wrote: On 08/18/2014 12:44 AM, Mike Galbraith wrote: On Sat, 2014-08-16 at 19:50 +0200, Oleg Nesterov wrote: On 08/16, Rik van Riel wrote: + do { + seq = nextseq; + read_seqbegin_or_lock(sig-stats_lock, seq); +

Re: [PATCH v2 2/3] time,signal: protect resource use statistics with seqlock

2014-08-18 Thread Rik van Riel
On 08/18/2014 12:44 AM, Mike Galbraith wrote: On Sat, 2014-08-16 at 19:50 +0200, Oleg Nesterov wrote: On 08/16, Rik van Riel wrote: + do { + seq = nextseq; + read_seqbegin_or_lock(>stats_lock, ); + times->utime = sig->utime; +

Re: [PATCH v2 2/3] time,signal: protect resource use statistics with seqlock

2014-08-18 Thread Rik van Riel
On 08/18/2014 12:44 AM, Mike Galbraith wrote: On Sat, 2014-08-16 at 19:50 +0200, Oleg Nesterov wrote: On 08/16, Rik van Riel wrote: + do { + seq = nextseq; + read_seqbegin_or_lock(sig-stats_lock, seq); + times-utime = sig-utime; +

Re: [PATCH v2 2/3] time,signal: protect resource use statistics with seqlock

2014-08-17 Thread Mike Galbraith
On Sat, 2014-08-16 at 19:50 +0200, Oleg Nesterov wrote: > On 08/16, Rik van Riel wrote: > > > > + do { > > + seq = nextseq; > > + read_seqbegin_or_lock(>stats_lock, ); > > + times->utime = sig->utime; > > + times->stime = sig->stime; > > +

Re: [PATCH v2 2/3] time,signal: protect resource use statistics with seqlock

2014-08-17 Thread Mike Galbraith
On Sat, 2014-08-16 at 19:50 +0200, Oleg Nesterov wrote: On 08/16, Rik van Riel wrote: + do { + seq = nextseq; + read_seqbegin_or_lock(sig-stats_lock, seq); + times-utime = sig-utime; + times-stime = sig-stime; +

Re: [PATCH v2 2/3] time,signal: protect resource use statistics with seqlock

2014-08-16 Thread Oleg Nesterov
On 08/16, Rik van Riel wrote: > > + do { > + seq = nextseq; > + read_seqbegin_or_lock(>stats_lock, ); > + times->utime = sig->utime; > + times->stime = sig->stime; > + times->sum_exec_runtime = sig->sum_sched_runtime; > + > +

[PATCH v2 2/3] time,signal: protect resource use statistics with seqlock

2014-08-16 Thread Rik van Riel
On Sat, 16 Aug 2014 16:11:59 +0200 Oleg Nesterov wrote: > Rik, I do not understand why did you silently ignore my comments about > this change twice ;) Here is the version I have actually been running my latest tests with. This one addresses the forward progress issue you pointed out. ---8<---

[PATCH v2 2/3] time,signal: protect resource use statistics with seqlock

2014-08-16 Thread Rik van Riel
On Sat, 16 Aug 2014 16:11:59 +0200 Oleg Nesterov o...@redhat.com wrote: Rik, I do not understand why did you silently ignore my comments about this change twice ;) Here is the version I have actually been running my latest tests with. This one addresses the forward progress issue you pointed

Re: [PATCH v2 2/3] time,signal: protect resource use statistics with seqlock

2014-08-16 Thread Oleg Nesterov
On 08/16, Rik van Riel wrote: + do { + seq = nextseq; + read_seqbegin_or_lock(sig-stats_lock, seq); + times-utime = sig-utime; + times-stime = sig-stime; + times-sum_exec_runtime = sig-sum_sched_runtime; + +