Re: [PATCH v2 3/8] tpm: factor out tpm1_get_random into tpm1-cmd.c

2018-03-16 Thread Jarkko Sakkinen
On Thu, Mar 15, 2018 at 11:24:23PM +, Winkler, Tomas wrote: > > > > On Sat, 2018-03-10 at 10:24 +0200, Tomas Winkler wrote: > > > + rlength = be32_to_cpu(tpm_cmd.header.out.length); > > > + if (rlength < offsetof(struct tpm_getrandom_out, rng_data) + > > > +

Re: [PATCH v2 3/8] tpm: factor out tpm1_get_random into tpm1-cmd.c

2018-03-16 Thread Jarkko Sakkinen
On Thu, Mar 15, 2018 at 11:24:23PM +, Winkler, Tomas wrote: > > > > On Sat, 2018-03-10 at 10:24 +0200, Tomas Winkler wrote: > > > + rlength = be32_to_cpu(tpm_cmd.header.out.length); > > > + if (rlength < offsetof(struct tpm_getrandom_out, rng_data) + > > > +

RE: [PATCH v2 3/8] tpm: factor out tpm1_get_random into tpm1-cmd.c

2018-03-15 Thread Winkler, Tomas
> > On Sat, 2018-03-10 at 10:24 +0200, Tomas Winkler wrote: > > + rlength = be32_to_cpu(tpm_cmd.header.out.length); > > + if (rlength < offsetof(struct tpm_getrandom_out, rng_data) + > > + recd) { > > + total = -EFAULT; > > +

RE: [PATCH v2 3/8] tpm: factor out tpm1_get_random into tpm1-cmd.c

2018-03-15 Thread Winkler, Tomas
> > On Sat, 2018-03-10 at 10:24 +0200, Tomas Winkler wrote: > > + rlength = be32_to_cpu(tpm_cmd.header.out.length); > > + if (rlength < offsetof(struct tpm_getrandom_out, rng_data) + > > + recd) { > > + total = -EFAULT; > > +

Re: [PATCH v2 3/8] tpm: factor out tpm1_get_random into tpm1-cmd.c

2018-03-15 Thread Jarkko Sakkinen
On Sat, 2018-03-10 at 10:24 +0200, Tomas Winkler wrote: > + rlength = be32_to_cpu(tpm_cmd.header.out.length); > + if (rlength < offsetof(struct tpm_getrandom_out, rng_data) + > + recd) { > + total = -EFAULT; > +

Re: [PATCH v2 3/8] tpm: factor out tpm1_get_random into tpm1-cmd.c

2018-03-15 Thread Jarkko Sakkinen
On Sat, 2018-03-10 at 10:24 +0200, Tomas Winkler wrote: > + rlength = be32_to_cpu(tpm_cmd.header.out.length); > + if (rlength < offsetof(struct tpm_getrandom_out, rng_data) + > + recd) { > + total = -EFAULT; > +

[PATCH v2 3/8] tpm: factor out tpm1_get_random into tpm1-cmd.c

2018-03-10 Thread Tomas Winkler
Factor out get random implementation from tpm-interface.c into tpm1_get_random function in tpm1-cmd.c. No functional changes. Signed-off-by: Tomas Winkler --- drivers/char/tpm/tpm-interface.c | 56 drivers/char/tpm/tpm.h

[PATCH v2 3/8] tpm: factor out tpm1_get_random into tpm1-cmd.c

2018-03-10 Thread Tomas Winkler
Factor out get random implementation from tpm-interface.c into tpm1_get_random function in tpm1-cmd.c. No functional changes. Signed-off-by: Tomas Winkler --- drivers/char/tpm/tpm-interface.c | 56 drivers/char/tpm/tpm.h | 2 ++