Re: [PATCH v2 4/4] arm64: dts: renesas: r8a7796: Fix register mappings on VSPs

2018-02-13 Thread Laurent Pinchart 
Hi Kieran,

Thank you for the patch.

On Tuesday, 13 February 2018 21:30:37 EET Kieran Bingham wrote:
> From: Kieran Bingham 
> 
> The VSPD includes a CLUT on RPF2. Ensure that the register space is
> mapped correctly to support this.
> 
> Signed-off-by: Kieran Bingham 

Reviewed-by: Laurent Pinchart 

> ---
>  arch/arm64/boot/dts/renesas/r8a7796.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> b/arch/arm64/boot/dts/renesas/r8a7796.dtsi index 60755117cba5..3fe5566e0630
> 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -2285,7 +2285,7 @@
> 
>   vspd0: vsp@fea2 {
>   compatible = "renesas,vsp2";
> - reg = <0 0xfea2 0 0x4000>;
> + reg = <0 0xfea2 0 0x8000>;
>   interrupts = ;
>   clocks = < CPG_MOD 623>;
>   power-domains = < R8A7796_PD_ALWAYS_ON>;
> @@ -2305,7 +2305,7 @@
> 
>   vspd1: vsp@fea28000 {
>   compatible = "renesas,vsp2";
> - reg = <0 0xfea28000 0 0x4000>;
> + reg = <0 0xfea28000 0 0x8000>;
>   interrupts = ;
>   clocks = < CPG_MOD 622>;
>   power-domains = < R8A7796_PD_ALWAYS_ON>;
> @@ -2325,7 +2325,7 @@
> 
>   vspd2: vsp@fea3 {
>   compatible = "renesas,vsp2";
> - reg = <0 0xfea3 0 0x4000>;
> + reg = <0 0xfea3 0 0x8000>;
>   interrupts = ;
>   clocks = < CPG_MOD 621>;
>   power-domains = < R8A7796_PD_ALWAYS_ON>;

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 4/4] arm64: dts: renesas: r8a7796: Fix register mappings on VSPs

2018-02-13 Thread Laurent Pinchart 
Hi Kieran,

Thank you for the patch.

On Tuesday, 13 February 2018 21:30:37 EET Kieran Bingham wrote:
> From: Kieran Bingham 
> 
> The VSPD includes a CLUT on RPF2. Ensure that the register space is
> mapped correctly to support this.
> 
> Signed-off-by: Kieran Bingham 

Reviewed-by: Laurent Pinchart 

> ---
>  arch/arm64/boot/dts/renesas/r8a7796.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> b/arch/arm64/boot/dts/renesas/r8a7796.dtsi index 60755117cba5..3fe5566e0630
> 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -2285,7 +2285,7 @@
> 
>   vspd0: vsp@fea2 {
>   compatible = "renesas,vsp2";
> - reg = <0 0xfea2 0 0x4000>;
> + reg = <0 0xfea2 0 0x8000>;
>   interrupts = ;
>   clocks = < CPG_MOD 623>;
>   power-domains = < R8A7796_PD_ALWAYS_ON>;
> @@ -2305,7 +2305,7 @@
> 
>   vspd1: vsp@fea28000 {
>   compatible = "renesas,vsp2";
> - reg = <0 0xfea28000 0 0x4000>;
> + reg = <0 0xfea28000 0 0x8000>;
>   interrupts = ;
>   clocks = < CPG_MOD 622>;
>   power-domains = < R8A7796_PD_ALWAYS_ON>;
> @@ -2325,7 +2325,7 @@
> 
>   vspd2: vsp@fea3 {
>   compatible = "renesas,vsp2";
> - reg = <0 0xfea3 0 0x4000>;
> + reg = <0 0xfea3 0 0x8000>;
>   interrupts = ;
>   clocks = < CPG_MOD 621>;
>   power-domains = < R8A7796_PD_ALWAYS_ON>;

-- 
Regards,

Laurent Pinchart

[PATCH v2 4/4] arm64: dts: renesas: r8a7796: Fix register mappings on VSPs

2018-02-13 Thread Kieran Bingham 
From: Kieran Bingham 

The VSPD includes a CLUT on RPF2. Ensure that the register space is
mapped correctly to support this.

Signed-off-by: Kieran Bingham 
---
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi 
b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index 60755117cba5..3fe5566e0630 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -2285,7 +2285,7 @@
 
vspd0: vsp@fea2 {
compatible = "renesas,vsp2";
-   reg = <0 0xfea2 0 0x4000>;
+   reg = <0 0xfea2 0 0x8000>;
interrupts = ;
clocks = < CPG_MOD 623>;
power-domains = < R8A7796_PD_ALWAYS_ON>;
@@ -2305,7 +2305,7 @@
 
vspd1: vsp@fea28000 {
compatible = "renesas,vsp2";
-   reg = <0 0xfea28000 0 0x4000>;
+   reg = <0 0xfea28000 0 0x8000>;
interrupts = ;
clocks = < CPG_MOD 622>;
power-domains = < R8A7796_PD_ALWAYS_ON>;
@@ -2325,7 +2325,7 @@
 
vspd2: vsp@fea3 {
compatible = "renesas,vsp2";
-   reg = <0 0xfea3 0 0x4000>;
+   reg = <0 0xfea3 0 0x8000>;
interrupts = ;
clocks = < CPG_MOD 621>;
power-domains = < R8A7796_PD_ALWAYS_ON>;
-- 
2.7.4

[PATCH v2 4/4] arm64: dts: renesas: r8a7796: Fix register mappings on VSPs

2018-02-13 Thread Kieran Bingham 
From: Kieran Bingham 

The VSPD includes a CLUT on RPF2. Ensure that the register space is
mapped correctly to support this.

Signed-off-by: Kieran Bingham 
---
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi 
b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index 60755117cba5..3fe5566e0630 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -2285,7 +2285,7 @@
 
vspd0: vsp@fea2 {
compatible = "renesas,vsp2";
-   reg = <0 0xfea2 0 0x4000>;
+   reg = <0 0xfea2 0 0x8000>;
interrupts = ;
clocks = < CPG_MOD 623>;
power-domains = < R8A7796_PD_ALWAYS_ON>;
@@ -2305,7 +2305,7 @@
 
vspd1: vsp@fea28000 {
compatible = "renesas,vsp2";
-   reg = <0 0xfea28000 0 0x4000>;
+   reg = <0 0xfea28000 0 0x8000>;
interrupts = ;
clocks = < CPG_MOD 622>;
power-domains = < R8A7796_PD_ALWAYS_ON>;
@@ -2325,7 +2325,7 @@
 
vspd2: vsp@fea3 {
compatible = "renesas,vsp2";
-   reg = <0 0xfea3 0 0x4000>;
+   reg = <0 0xfea3 0 0x8000>;
interrupts = ;
clocks = < CPG_MOD 621>;
power-domains = < R8A7796_PD_ALWAYS_ON>;
-- 
2.7.4