Re: [PATCH v2 6/8] xfs: use dax ops for zero and truncate in fsdax mode

2022-12-01 Thread Darrick J. Wong
On Thu, Dec 01, 2022 at 03:32:10PM +, Shiyang Ruan wrote:
> Zero and truncate on a dax file may execute CoW.  So use dax ops which
> contains end work for CoW.
> 
> Signed-off-by: Shiyang Ruan 

LGTM
Reviewed-by: Darrick J. Wong 

--D

> ---
>  fs/xfs/xfs_iomap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
> index 881de99766ca..d9401d0300ad 100644
> --- a/fs/xfs/xfs_iomap.c
> +++ b/fs/xfs/xfs_iomap.c
> @@ -1370,7 +1370,7 @@ xfs_zero_range(
>  
>   if (IS_DAX(inode))
>   return dax_zero_range(inode, pos, len, did_zero,
> -   _direct_write_iomap_ops);
> +   _dax_write_iomap_ops);
>   return iomap_zero_range(inode, pos, len, did_zero,
>   _buffered_write_iomap_ops);
>  }
> @@ -1385,7 +1385,7 @@ xfs_truncate_page(
>  
>   if (IS_DAX(inode))
>   return dax_truncate_page(inode, pos, did_zero,
> - _direct_write_iomap_ops);
> + _dax_write_iomap_ops);
>   return iomap_truncate_page(inode, pos, did_zero,
>  _buffered_write_iomap_ops);
>  }
> -- 
> 2.38.1
> 



[PATCH v2 6/8] xfs: use dax ops for zero and truncate in fsdax mode

2022-12-01 Thread Shiyang Ruan
Zero and truncate on a dax file may execute CoW.  So use dax ops which
contains end work for CoW.

Signed-off-by: Shiyang Ruan 
---
 fs/xfs/xfs_iomap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
index 881de99766ca..d9401d0300ad 100644
--- a/fs/xfs/xfs_iomap.c
+++ b/fs/xfs/xfs_iomap.c
@@ -1370,7 +1370,7 @@ xfs_zero_range(
 
if (IS_DAX(inode))
return dax_zero_range(inode, pos, len, did_zero,
- _direct_write_iomap_ops);
+ _dax_write_iomap_ops);
return iomap_zero_range(inode, pos, len, did_zero,
_buffered_write_iomap_ops);
 }
@@ -1385,7 +1385,7 @@ xfs_truncate_page(
 
if (IS_DAX(inode))
return dax_truncate_page(inode, pos, did_zero,
-   _direct_write_iomap_ops);
+   _dax_write_iomap_ops);
return iomap_truncate_page(inode, pos, did_zero,
   _buffered_write_iomap_ops);
 }
-- 
2.38.1