Re: [PATCH v3] leds: triggers: Check return value of kobject_uevent_env()

[Greg KH]

On Mon, Sep 19, 2016 at 12:52:24PM +0200, Jacek Anaszewski wrote:
> Log error message if kobject_uevent_env() fails in led_trigger_set().
> 
> Signed-off-by: Jacek Anaszewski 
> ---
> Changes from v1:
> - switched to using dev_err() instead of pr_err()
> Changes from v2:
> - switched to using __func__ instead of explicit function name,
>   to simplify code maintenance
> 
>  drivers/leds/led-triggers.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c
> index c7a38d4..431123b 100644
> --- a/drivers/leds/led-triggers.c
> +++ b/drivers/leds/led-triggers.c
> @@ -141,7 +141,9 @@ void led_trigger_set(struct led_classdev *led_cdev, 
> struct led_trigger *trig)
>   if (event) {
>   envp[0] = event;
>   envp[1] = NULL;
> - kobject_uevent_env(_cdev->dev->kobj, KOBJ_CHANGE, envp);
> + if (kobject_uevent_env(_cdev->dev->kobj, KOBJ_CHANGE, envp))
> + dev_err(led_cdev->dev,
> + "%s: Error sending uevent\n", __func__);
>   kfree(event);
>   }
>  }
> -- 
> 1.9.1


Acked-by: Greg Kroah-Hartman 

Re: [PATCH v3] leds: triggers: Check return value of kobject_uevent_env()

[Greg KH]

On Mon, Sep 19, 2016 at 12:52:24PM +0200, Jacek Anaszewski wrote:
> Log error message if kobject_uevent_env() fails in led_trigger_set().
> 
> Signed-off-by: Jacek Anaszewski 
> ---
> Changes from v1:
> - switched to using dev_err() instead of pr_err()
> Changes from v2:
> - switched to using __func__ instead of explicit function name,
>   to simplify code maintenance
> 
>  drivers/leds/led-triggers.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c
> index c7a38d4..431123b 100644
> --- a/drivers/leds/led-triggers.c
> +++ b/drivers/leds/led-triggers.c
> @@ -141,7 +141,9 @@ void led_trigger_set(struct led_classdev *led_cdev, 
> struct led_trigger *trig)
>   if (event) {
>   envp[0] = event;
>   envp[1] = NULL;
> - kobject_uevent_env(_cdev->dev->kobj, KOBJ_CHANGE, envp);
> + if (kobject_uevent_env(_cdev->dev->kobj, KOBJ_CHANGE, envp))
> + dev_err(led_cdev->dev,
> + "%s: Error sending uevent\n", __func__);
>   kfree(event);
>   }
>  }
> -- 
> 1.9.1


Acked-by: Greg Kroah-Hartman 

[PATCH v3] leds: triggers: Check return value of kobject_uevent_env()

[Jacek Anaszewski]

Log error message if kobject_uevent_env() fails in led_trigger_set().

Signed-off-by: Jacek Anaszewski 
---
Changes from v1:
- switched to using dev_err() instead of pr_err()
Changes from v2:
- switched to using __func__ instead of explicit function name,
  to simplify code maintenance

 drivers/leds/led-triggers.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c
index c7a38d4..431123b 100644
--- a/drivers/leds/led-triggers.c
+++ b/drivers/leds/led-triggers.c
@@ -141,7 +141,9 @@ void led_trigger_set(struct led_classdev *led_cdev, struct 
led_trigger *trig)
if (event) {
envp[0] = event;
envp[1] = NULL;
-   kobject_uevent_env(_cdev->dev->kobj, KOBJ_CHANGE, envp);
+   if (kobject_uevent_env(_cdev->dev->kobj, KOBJ_CHANGE, envp))
+   dev_err(led_cdev->dev,
+   "%s: Error sending uevent\n", __func__);
kfree(event);
}
 }
-- 
1.9.1

[PATCH v3] leds: triggers: Check return value of kobject_uevent_env()

[Jacek Anaszewski]

Log error message if kobject_uevent_env() fails in led_trigger_set().

Signed-off-by: Jacek Anaszewski 
---
Changes from v1:
- switched to using dev_err() instead of pr_err()
Changes from v2:
- switched to using __func__ instead of explicit function name,
  to simplify code maintenance

 drivers/leds/led-triggers.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c
index c7a38d4..431123b 100644
--- a/drivers/leds/led-triggers.c
+++ b/drivers/leds/led-triggers.c
@@ -141,7 +141,9 @@ void led_trigger_set(struct led_classdev *led_cdev, struct 
led_trigger *trig)
if (event) {
envp[0] = event;
envp[1] = NULL;
-   kobject_uevent_env(_cdev->dev->kobj, KOBJ_CHANGE, envp);
+   if (kobject_uevent_env(_cdev->dev->kobj, KOBJ_CHANGE, envp))
+   dev_err(led_cdev->dev,
+   "%s: Error sending uevent\n", __func__);
kfree(event);
}
 }
-- 
1.9.1