Re: [PATCH v3 0/6] Add different features for I2C
On Wed, Apr 11, 2018 at 03:24:52PM +0200, Pierre-Yves MORDRET wrote: > Append new I2C STM32F7 feature set. This includes 10 bit support, slave > support, SMBBus protocols support, DMA Support and eventually an I2C release > mechanism. Applied to for-next, thanks! While building, I saw this. While this is mostly not related to your patch series, maybe you want to have a look at it? drivers/i2c/busses/i2c-stm32f7.c:227: warning: Function parameter or member 'node' not described in 'stm32f7_i2c_timings' drivers/i2c/busses/i2c-stm32f7.c:227: warning: Function parameter or member 'presc' not described in 'stm32f7_i2c_timings' drivers/i2c/busses/i2c-stm32f7.c:227: warning: Function parameter or member 'scll' not described in 'stm32f7_i2c_timings' drivers/i2c/busses/i2c-stm32f7.c:255: warning: Function parameter or member 'smbus_buf' not described in 'stm32f7_i2c_msg' drivers/i2c/busses/i2c-stm32f7.c:307: warning: cannot understand function prototype: 'struct stm32f7_i2c_spec i2c_specs[] = ' And don't forget to add yourself as MAINTAINER as I mentioned in the old thread. signature.asc Description: PGP signature
[PATCH v3 0/6] Add different features for I2C
Append new I2C STM32F7 feature set. This includes 10 bit support, slave support, SMBBus protocols support, DMA Support and eventually an I2C release mechanism. --- Version history: v1: * Initial v2: * Kbuild test robot issue * I2C master recovery mechanism v3: * Provide more details on what have already been implemented and not implemented for SMBus protocols * Raise DMA usage threshold * s/recovery/release/ throughout the patch. Recovery is really something else. --- Pierre-Yves MORDRET (6): i2c: i2c-stm32f7: Add 10-bit address support i2c: i2c-stm32f7: Add slave support i2c: i2c-stm32f7: Add initial SMBus protocols support i2c: i2c-stm32: Add generic DMA API i2c: i2c-stm32f7: Add DMA support i2c: i2c-stm32f7: Implement I2C release mechanism drivers/i2c/busses/Kconfig |1 + drivers/i2c/busses/Makefile |3 +- drivers/i2c/busses/i2c-stm32.c | 153 ++ drivers/i2c/busses/i2c-stm32.h | 37 ++ drivers/i2c/busses/i2c-stm32f7.c | 1040 +- 5 files changed, 1207 insertions(+), 27 deletions(-) create mode 100644 drivers/i2c/busses/i2c-stm32.c -- 2.7.4
