Re: [PATCH v3 10/25] ASoC: qcom: q6asm: Add support to memory map and unmap

Thanks for the review, On 01/03/18 21:28, Mark Brown wrote: On Tue, Feb 13, 2018 at 04:58:22PM +, srinivas.kandaga...@linaro.org wrote: + num_regions = is_contiguous ? 1 : periods; + buf_sz = is_contiguous ? (period_sz * periods) : period_sz; Please write normal if statements

Re: [PATCH v3 10/25] ASoC: qcom: q6asm: Add support to memory map and unmap

On Tue, Feb 13, 2018 at 04:58:22PM +, srinivas.kandaga...@linaro.org wrote: > + num_regions = is_contiguous ? 1 : periods; > + buf_sz = is_contiguous ? (period_sz * periods) : period_sz; Please write normal if statements, it's much easier to read. > + buf_sz = PAGE_ALIGN(buf_sz);

[PATCH v3 10/25] ASoC: qcom: q6asm: Add support to memory map and unmap

From: Srinivas Kandagatla This patch adds support to memory map and unmap regions commands in q6asm module. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6asm.c | 312 +++ sound/soc/qcom/qdsp6/q6asm.h | 5 + 2 files changed, 317 insertio