Re: [PATCH v3 2/2] tpm: Detach page allocation from tpm_buf

2019-10-06 Thread Jarkko Sakkinen
On Fri, Oct 04, 2019 at 11:24:34AM -0700, Jerry Snitselaar wrote: > On Fri Oct 04 19, James Bottomley wrote: > > On Fri, 2019-10-04 at 13:37 -0400, Mimi Zohar wrote: > > > On Fri, 2019-10-04 at 09:37 -0700, James Bottomley wrote: > > > > On Thu, 2019-10-03 at 21:51 +0300, Jarkko Sakkinen wrote: >

Re: [PATCH v3 2/2] tpm: Detach page allocation from tpm_buf

2019-10-04 Thread Jarkko Sakkinen
On Fri, Oct 04, 2019 at 09:37:42AM -0700, James Bottomley wrote: > On Thu, 2019-10-03 at 21:51 +0300, Jarkko Sakkinen wrote: > > As has been seen recently, binding the buffer allocation and tpm_buf > > together is sometimes far from optimal. > > Can you elaborate on this a bit more? I must have

Re: [PATCH v3 2/2] tpm: Detach page allocation from tpm_buf

2019-10-04 Thread Jerry Snitselaar
On Fri Oct 04 19, James Bottomley wrote: On Fri, 2019-10-04 at 13:37 -0400, Mimi Zohar wrote: On Fri, 2019-10-04 at 09:37 -0700, James Bottomley wrote: > On Thu, 2019-10-03 at 21:51 +0300, Jarkko Sakkinen wrote: > > As has been seen recently, binding the buffer allocation and > > tpm_buf > >

Re: [PATCH v3 2/2] tpm: Detach page allocation from tpm_buf

2019-10-04 Thread James Bottomley
On Fri, 2019-10-04 at 13:37 -0400, Mimi Zohar wrote: > On Fri, 2019-10-04 at 09:37 -0700, James Bottomley wrote: > > On Thu, 2019-10-03 at 21:51 +0300, Jarkko Sakkinen wrote: > > > As has been seen recently, binding the buffer allocation and > > > tpm_buf > > > together is sometimes far from

Re: [PATCH v3 2/2] tpm: Detach page allocation from tpm_buf

2019-10-04 Thread Mimi Zohar
On Fri, 2019-10-04 at 09:37 -0700, James Bottomley wrote: > On Thu, 2019-10-03 at 21:51 +0300, Jarkko Sakkinen wrote: > > As has been seen recently, binding the buffer allocation and tpm_buf > > together is sometimes far from optimal. > > Can you elaborate on this a bit more? I must have missed

Re: [PATCH v3 2/2] tpm: Detach page allocation from tpm_buf

2019-10-04 Thread James Bottomley
On Thu, 2019-10-03 at 21:51 +0300, Jarkko Sakkinen wrote: > As has been seen recently, binding the buffer allocation and tpm_buf > together is sometimes far from optimal. Can you elaborate on this a bit more? I must have missed the discussion. > The buffer might come from the caller namely

[PATCH v3 2/2] tpm: Detach page allocation from tpm_buf

2019-10-03 Thread Jarkko Sakkinen
As has been seen recently, binding the buffer allocation and tpm_buf together is sometimes far from optimal. The buffer might come from the caller namely when tpm_send() is used by another subsystem. In addition we can stability in call sites w/o rollback (e.g. power events)> Take allocation out