Re: [PATCH v3 2/5] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

2018-02-13 Thread Dou Liyang
Hi Eric, At 02/14/2018 01:40 AM, Eric W. Biederman wrote: Dou Liyang writes: Hi Baoquan, At 02/12/2018 11:08 AM, Eric W. Biederman wrote: Baoquan He writes: This is a regression fix. Before, to fix erratum AVR31, commit 522e66464467

Re: [PATCH v3 2/5] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

2018-02-13 Thread Baoquan He
On 02/13/18 at 11:44am, Eric W. Biederman wrote: > Baoquan He writes: > > > Hi Eric, > > > > On 02/11/18 at 09:08pm, Eric W. Biederman wrote: > >> Baoquan He writes: > >> > >> > This is a regression fix. > >> > > >> > Before, to fix erratum AVR31, commit

Re: [PATCH v3 2/5] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

2018-02-13 Thread Eric W. Biederman
Baoquan He writes: > Hi Eric, > > On 02/11/18 at 09:08pm, Eric W. Biederman wrote: >> Baoquan He writes: >> >> > This is a regression fix. >> > >> > Before, to fix erratum AVR31, commit 522e66464467 ("x86/apic: Disable >> > I/O APIC before shutdown of the

Re: [PATCH v3 2/5] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

2018-02-13 Thread Eric W. Biederman
Dou Liyang writes: > Hi Baoquan, > > At 02/12/2018 11:08 AM, Eric W. Biederman wrote: >> Baoquan He writes: >> >>> This is a regression fix. >>> >>> Before, to fix erratum AVR31, commit 522e66464467 ("x86/apic: Disable >>> I/O APIC before shutdown of

Re: [PATCH v3 2/5] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

2018-02-12 Thread Baoquan He
Hi Eric, On 02/11/18 at 09:08pm, Eric W. Biederman wrote: > Baoquan He writes: > > > This is a regression fix. > > > > Before, to fix erratum AVR31, commit 522e66464467 ("x86/apic: Disable > > I/O APIC before shutdown of the local APIC") moved lapic_shutdown() > > calling after

Re: [PATCH v3 2/5] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

2018-02-12 Thread Baoquan He
On 02/13/18 at 10:43am, Dou Liyang wrote: > Hi Baoquan, > > At 02/12/2018 11:08 AM, Eric W. Biederman wrote: > > Baoquan He writes: > > > > > This is a regression fix. > > > > > > Before, to fix erratum AVR31, commit 522e66464467 ("x86/apic: Disable > > > I/O APIC before

Re: [PATCH v3 2/5] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

2018-02-12 Thread Dou Liyang
Hi Baoquan, At 02/12/2018 11:08 AM, Eric W. Biederman wrote: Baoquan He writes: This is a regression fix. Before, to fix erratum AVR31, commit 522e66464467 ("x86/apic: Disable I/O APIC before shutdown of the local APIC") moved lapic_shutdown() calling after

Re: [PATCH v3 2/5] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

2018-02-12 Thread Baoquan He
On 02/11/18 at 09:08pm, Eric W. Biederman wrote: > Baoquan He writes: > > > This is a regression fix. > > > > Before, to fix erratum AVR31, commit 522e66464467 ("x86/apic: Disable > > I/O APIC before shutdown of the local APIC") moved lapic_shutdown() > > calling after

Re: [PATCH v3 2/5] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

2018-02-11 Thread Eric W. Biederman
Baoquan He writes: > This is a regression fix. > > Before, to fix erratum AVR31, commit 522e66464467 ("x86/apic: Disable > I/O APIC before shutdown of the local APIC") moved lapic_shutdown() > calling after disable_IO_APIC(). This introdued a regression. The > root cause is that

[PATCH v3 2/5] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

2018-02-09 Thread Baoquan He
This is a regression fix. Before, to fix erratum AVR31, commit 522e66464467 ("x86/apic: Disable I/O APIC before shutdown of the local APIC") moved lapic_shutdown() calling after disable_IO_APIC(). This introdued a regression. The root cause is that disable_IO_APIC() not only clears IO_APIC, also