Re: [PATCH v3 21/28] drm/tegra: switch to drm_*_get(), drm_*_put() helpers

2017-08-17 Thread Thierry Reding 
On Fri, Aug 11, 2017 at 03:33:07PM +0300, Cihangir Akturk wrote:
> Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference()
> and drm_*_unreference() helpers.
> 
> drm_*_reference() and drm_*_unreference() functions are just
> compatibility alias for drm_*_get() and drm_*_put() and should not be
> used by new code. So convert all users of compatibility functions to
> use the new APIs.
> 
> Generated by: scripts/coccinelle/api/drm-get-put.cocci
> 
> Signed-off-by: Cihangir Akturk 
> ---
>  drivers/gpu/drm/tegra/drm.c | 12 ++--
>  drivers/gpu/drm/tegra/fb.c  |  8 
>  drivers/gpu/drm/tegra/gem.c | 10 +-
>  3 files changed, 15 insertions(+), 15 deletions(-)

Applied, thanks.

Thierry


signature.asc
Description: PGP signature

Re: [PATCH v3 21/28] drm/tegra: switch to drm_*_get(), drm_*_put() helpers

2017-08-17 Thread Thierry Reding 
On Fri, Aug 11, 2017 at 03:33:07PM +0300, Cihangir Akturk wrote:
> Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference()
> and drm_*_unreference() helpers.
> 
> drm_*_reference() and drm_*_unreference() functions are just
> compatibility alias for drm_*_get() and drm_*_put() and should not be
> used by new code. So convert all users of compatibility functions to
> use the new APIs.
> 
> Generated by: scripts/coccinelle/api/drm-get-put.cocci
> 
> Signed-off-by: Cihangir Akturk 
> ---
>  drivers/gpu/drm/tegra/drm.c | 12 ++--
>  drivers/gpu/drm/tegra/fb.c  |  8 
>  drivers/gpu/drm/tegra/gem.c | 10 +-
>  3 files changed, 15 insertions(+), 15 deletions(-)

Applied, thanks.

Thierry


signature.asc
Description: PGP signature

[PATCH v3 21/28] drm/tegra: switch to drm_*_get(), drm_*_put() helpers

2017-08-11 Thread Cihangir Akturk 
Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference()
and drm_*_unreference() helpers.

drm_*_reference() and drm_*_unreference() functions are just
compatibility alias for drm_*_get() and drm_*_put() and should not be
used by new code. So convert all users of compatibility functions to
use the new APIs.

Generated by: scripts/coccinelle/api/drm-get-put.cocci

Signed-off-by: Cihangir Akturk 
---
 drivers/gpu/drm/tegra/drm.c | 12 ++--
 drivers/gpu/drm/tegra/fb.c  |  8 
 drivers/gpu/drm/tegra/gem.c | 10 +-
 3 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index 3ba659a..e70c67b 100644
--- a/drivers/gpu/drm/tegra/drm.c
+++ b/drivers/gpu/drm/tegra/drm.c
@@ -306,7 +306,7 @@ host1x_bo_lookup(struct drm_file *file, u32 handle)
if (!gem)
return NULL;
 
-   drm_gem_object_unreference_unlocked(gem);
+   drm_gem_object_put_unlocked(gem);
 
bo = to_tegra_bo(gem);
return >base;
@@ -593,7 +593,7 @@ static int tegra_gem_mmap(struct drm_device *drm, void 
*data,
 
args->offset = drm_vma_node_offset_addr(>gem.vma_node);
 
-   drm_gem_object_unreference_unlocked(gem);
+   drm_gem_object_put_unlocked(gem);
 
return 0;
 }
@@ -860,7 +860,7 @@ static int tegra_gem_set_tiling(struct drm_device *drm, 
void *data,
bo->tiling.mode = mode;
bo->tiling.value = value;
 
-   drm_gem_object_unreference_unlocked(gem);
+   drm_gem_object_put_unlocked(gem);
 
return 0;
 }
@@ -900,7 +900,7 @@ static int tegra_gem_get_tiling(struct drm_device *drm, 
void *data,
break;
}
 
-   drm_gem_object_unreference_unlocked(gem);
+   drm_gem_object_put_unlocked(gem);
 
return err;
 }
@@ -925,7 +925,7 @@ static int tegra_gem_set_flags(struct drm_device *drm, void 
*data,
if (args->flags & DRM_TEGRA_GEM_BOTTOM_UP)
bo->flags |= TEGRA_BO_BOTTOM_UP;
 
-   drm_gem_object_unreference_unlocked(gem);
+   drm_gem_object_put_unlocked(gem);
 
return 0;
 }
@@ -947,7 +947,7 @@ static int tegra_gem_get_flags(struct drm_device *drm, void 
*data,
if (bo->flags & TEGRA_BO_BOTTOM_UP)
args->flags |= DRM_TEGRA_GEM_BOTTOM_UP;
 
-   drm_gem_object_unreference_unlocked(gem);
+   drm_gem_object_put_unlocked(gem);
 
return 0;
 }
diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c
index 25acb73..80540c1 100644
--- a/drivers/gpu/drm/tegra/fb.c
+++ b/drivers/gpu/drm/tegra/fb.c
@@ -88,7 +88,7 @@ static void tegra_fb_destroy(struct drm_framebuffer 
*framebuffer)
if (bo->pages)
vunmap(bo->vaddr);
 
-   drm_gem_object_unreference_unlocked(>gem);
+   drm_gem_object_put_unlocked(>gem);
}
}
 
@@ -195,7 +195,7 @@ struct drm_framebuffer *tegra_fb_create(struct drm_device 
*drm,
 
 unreference:
while (i--)
-   drm_gem_object_unreference_unlocked([i]->gem);
+   drm_gem_object_put_unlocked([i]->gem);
 
return ERR_PTR(err);
 }
@@ -242,7 +242,7 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper,
info = drm_fb_helper_alloc_fbi(helper);
if (IS_ERR(info)) {
dev_err(drm->dev, "failed to allocate framebuffer info\n");
-   drm_gem_object_unreference_unlocked(>gem);
+   drm_gem_object_put_unlocked(>gem);
return PTR_ERR(info);
}
 
@@ -251,7 +251,7 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper,
err = PTR_ERR(fbdev->fb);
dev_err(drm->dev, "failed to allocate DRM framebuffer: %d\n",
err);
-   drm_gem_object_unreference_unlocked(>gem);
+   drm_gem_object_put_unlocked(>gem);
return PTR_ERR(fbdev->fb);
}
 
diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c
index 7a39a35..fe77bcd 100644
--- a/drivers/gpu/drm/tegra/gem.c
+++ b/drivers/gpu/drm/tegra/gem.c
@@ -24,7 +24,7 @@ static void tegra_bo_put(struct host1x_bo *bo)
 {
struct tegra_bo *obj = host1x_to_tegra_bo(bo);
 
-   drm_gem_object_unreference_unlocked(>gem);
+   drm_gem_object_put_unlocked(>gem);
 }
 
 static dma_addr_t tegra_bo_pin(struct host1x_bo *bo, struct sg_table **sgt)
@@ -95,7 +95,7 @@ static struct host1x_bo *tegra_bo_get(struct host1x_bo *bo)
 {
struct tegra_bo *obj = host1x_to_tegra_bo(bo);
 
-   drm_gem_object_reference(>gem);
+   drm_gem_object_get(>gem);
 
return bo;
 }
@@ -325,7 +325,7 @@ struct tegra_bo *tegra_bo_create_with_handle(struct 
drm_file *file,
return ERR_PTR(err);
}
 
-   drm_gem_object_unreference_unlocked(>gem);
+   drm_gem_object_put_unlocked(>gem);
 
return bo;
 }
@@ -439,7 +439,7 @@ int

[PATCH v3 21/28] drm/tegra: switch to drm_*_get(), drm_*_put() helpers

2017-08-11 Thread Cihangir Akturk 
Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference()
and drm_*_unreference() helpers.

drm_*_reference() and drm_*_unreference() functions are just
compatibility alias for drm_*_get() and drm_*_put() and should not be
used by new code. So convert all users of compatibility functions to
use the new APIs.

Generated by: scripts/coccinelle/api/drm-get-put.cocci

Signed-off-by: Cihangir Akturk 
---
 drivers/gpu/drm/tegra/drm.c | 12 ++--
 drivers/gpu/drm/tegra/fb.c  |  8 
 drivers/gpu/drm/tegra/gem.c | 10 +-
 3 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index 3ba659a..e70c67b 100644
--- a/drivers/gpu/drm/tegra/drm.c
+++ b/drivers/gpu/drm/tegra/drm.c
@@ -306,7 +306,7 @@ host1x_bo_lookup(struct drm_file *file, u32 handle)
if (!gem)
return NULL;
 
-   drm_gem_object_unreference_unlocked(gem);
+   drm_gem_object_put_unlocked(gem);
 
bo = to_tegra_bo(gem);
return >base;
@@ -593,7 +593,7 @@ static int tegra_gem_mmap(struct drm_device *drm, void 
*data,
 
args->offset = drm_vma_node_offset_addr(>gem.vma_node);
 
-   drm_gem_object_unreference_unlocked(gem);
+   drm_gem_object_put_unlocked(gem);
 
return 0;
 }
@@ -860,7 +860,7 @@ static int tegra_gem_set_tiling(struct drm_device *drm, 
void *data,
bo->tiling.mode = mode;
bo->tiling.value = value;
 
-   drm_gem_object_unreference_unlocked(gem);
+   drm_gem_object_put_unlocked(gem);
 
return 0;
 }
@@ -900,7 +900,7 @@ static int tegra_gem_get_tiling(struct drm_device *drm, 
void *data,
break;
}
 
-   drm_gem_object_unreference_unlocked(gem);
+   drm_gem_object_put_unlocked(gem);
 
return err;
 }
@@ -925,7 +925,7 @@ static int tegra_gem_set_flags(struct drm_device *drm, void 
*data,
if (args->flags & DRM_TEGRA_GEM_BOTTOM_UP)
bo->flags |= TEGRA_BO_BOTTOM_UP;
 
-   drm_gem_object_unreference_unlocked(gem);
+   drm_gem_object_put_unlocked(gem);
 
return 0;
 }
@@ -947,7 +947,7 @@ static int tegra_gem_get_flags(struct drm_device *drm, void 
*data,
if (bo->flags & TEGRA_BO_BOTTOM_UP)
args->flags |= DRM_TEGRA_GEM_BOTTOM_UP;
 
-   drm_gem_object_unreference_unlocked(gem);
+   drm_gem_object_put_unlocked(gem);
 
return 0;
 }
diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c
index 25acb73..80540c1 100644
--- a/drivers/gpu/drm/tegra/fb.c
+++ b/drivers/gpu/drm/tegra/fb.c
@@ -88,7 +88,7 @@ static void tegra_fb_destroy(struct drm_framebuffer 
*framebuffer)
if (bo->pages)
vunmap(bo->vaddr);
 
-   drm_gem_object_unreference_unlocked(>gem);
+   drm_gem_object_put_unlocked(>gem);
}
}
 
@@ -195,7 +195,7 @@ struct drm_framebuffer *tegra_fb_create(struct drm_device 
*drm,
 
 unreference:
while (i--)
-   drm_gem_object_unreference_unlocked([i]->gem);
+   drm_gem_object_put_unlocked([i]->gem);
 
return ERR_PTR(err);
 }
@@ -242,7 +242,7 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper,
info = drm_fb_helper_alloc_fbi(helper);
if (IS_ERR(info)) {
dev_err(drm->dev, "failed to allocate framebuffer info\n");
-   drm_gem_object_unreference_unlocked(>gem);
+   drm_gem_object_put_unlocked(>gem);
return PTR_ERR(info);
}
 
@@ -251,7 +251,7 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper,
err = PTR_ERR(fbdev->fb);
dev_err(drm->dev, "failed to allocate DRM framebuffer: %d\n",
err);
-   drm_gem_object_unreference_unlocked(>gem);
+   drm_gem_object_put_unlocked(>gem);
return PTR_ERR(fbdev->fb);
}
 
diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c
index 7a39a35..fe77bcd 100644
--- a/drivers/gpu/drm/tegra/gem.c
+++ b/drivers/gpu/drm/tegra/gem.c
@@ -24,7 +24,7 @@ static void tegra_bo_put(struct host1x_bo *bo)
 {
struct tegra_bo *obj = host1x_to_tegra_bo(bo);
 
-   drm_gem_object_unreference_unlocked(>gem);
+   drm_gem_object_put_unlocked(>gem);
 }
 
 static dma_addr_t tegra_bo_pin(struct host1x_bo *bo, struct sg_table **sgt)
@@ -95,7 +95,7 @@ static struct host1x_bo *tegra_bo_get(struct host1x_bo *bo)
 {
struct tegra_bo *obj = host1x_to_tegra_bo(bo);
 
-   drm_gem_object_reference(>gem);
+   drm_gem_object_get(>gem);
 
return bo;
 }
@@ -325,7 +325,7 @@ struct tegra_bo *tegra_bo_create_with_handle(struct 
drm_file *file,
return ERR_PTR(err);
}
 
-   drm_gem_object_unreference_unlocked(>gem);
+   drm_gem_object_put_unlocked(>gem);
 
return bo;
 }
@@ -439,7 +439,7 @@ int