Re: [PATCH v3 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131

2016-02-22 Thread Darren Hart
On Mon, Feb 22, 2016 at 09:56:50AM +0100, Michał Kępień wrote: > > > /* > > > * Certain keys are flagged as KE_IGNORE. All of these are either > > > * notifications (rather than requests for change) or are also sent > > > @@ -513,6 +533,7 @@ static int __init dell_wmi_init(void) > > > { > >

Re: [PATCH v3 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131

2016-02-22 Thread Darren Hart
On Mon, Feb 22, 2016 at 09:56:50AM +0100, Michał Kępień wrote: > > > /* > > > * Certain keys are flagged as KE_IGNORE. All of these are either > > > * notifications (rather than requests for change) or are also sent > > > @@ -513,6 +533,7 @@ static int __init dell_wmi_init(void) > > > { > >

Re: [PATCH v3 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131

2016-02-22 Thread Michał Kępień
> > > Pali's point about documenting the hardcoded values and eliminating the > > > code > > > duplication with a function (inline) is a good one. > > > > I plan to only put a comment next to 0x51534554 as 0x1 is apparently > > just something pulled out of a hat (as the link provided in the

Re: [PATCH v3 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131

2016-02-22 Thread Michał Kępień
> > > Pali's point about documenting the hardcoded values and eliminating the > > > code > > > duplication with a function (inline) is a good one. > > > > I plan to only put a comment next to 0x51534554 as 0x1 is apparently > > just something pulled out of a hat (as the link provided in the

Re: [PATCH v3 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131

2016-02-22 Thread Pali Rohár
On Monday 22 February 2016 09:56:50 Michał Kępień wrote: > > > /* > > > * Certain keys are flagged as KE_IGNORE. All of these are either > > > * notifications (rather than requests for change) or are also sent > > > @@ -513,6 +533,7 @@ static int __init dell_wmi_init(void) > > > { > > >

Re: [PATCH v3 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131

2016-02-22 Thread Pali Rohár
On Monday 22 February 2016 09:56:50 Michał Kępień wrote: > > > /* > > > * Certain keys are flagged as KE_IGNORE. All of these are either > > > * notifications (rather than requests for change) or are also sent > > > @@ -513,6 +533,7 @@ static int __init dell_wmi_init(void) > > > { > > >

Re: [PATCH v3 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131

2016-02-22 Thread Michał Kępień
> > /* > > * Certain keys are flagged as KE_IGNORE. All of these are either > > * notifications (rather than requests for change) or are also sent > > @@ -513,6 +533,7 @@ static int __init dell_wmi_init(void) > > { > > int err; > > acpi_status status; > > + struct

Re: [PATCH v3 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131

2016-02-22 Thread Michał Kępień
> > /* > > * Certain keys are flagged as KE_IGNORE. All of these are either > > * notifications (rather than requests for change) or are also sent > > @@ -513,6 +533,7 @@ static int __init dell_wmi_init(void) > > { > > int err; > > acpi_status status; > > + struct

Re: [PATCH v3 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131

2016-02-19 Thread Darren Hart
On Tue, Feb 16, 2016 at 03:50:28PM +0100, Michał Kępień wrote: > On some laptop models (e.g. Dell Vostro V131), WMI events are not > generated until a specific SMBIOS request is issued to register an event > listener [1]. As there seems to be no ACPI method or SMBIOS request to > determine

Re: [PATCH v3 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131

2016-02-19 Thread Darren Hart
On Tue, Feb 16, 2016 at 03:50:28PM +0100, Michał Kępień wrote: > On some laptop models (e.g. Dell Vostro V131), WMI events are not > generated until a specific SMBIOS request is issued to register an event > listener [1]. As there seems to be no ACPI method or SMBIOS request to > determine

Re: [PATCH v3 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131

2016-02-16 Thread Michał Kępień
> > static void __exit dell_wmi_exit(void) > > { > > + struct calling_interface_buffer *buffer; > > + > > + if (wmi_requires_smbios_request) { > > + buffer = dell_smbios_get_buffer(); > > + buffer->input[0] = 0x1; > > + buffer->input[1] = 0x51534554; > > +

Re: [PATCH v3 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131

2016-02-16 Thread Michał Kępień
> > static void __exit dell_wmi_exit(void) > > { > > + struct calling_interface_buffer *buffer; > > + > > + if (wmi_requires_smbios_request) { > > + buffer = dell_smbios_get_buffer(); > > + buffer->input[0] = 0x1; > > + buffer->input[1] = 0x51534554; > > +

Re: [PATCH v3 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131

2016-02-16 Thread Pali Rohár
On Tuesday 16 February 2016 15:50:28 Michał Kępień wrote: > + if (wmi_requires_smbios_request) { > + buffer = dell_smbios_get_buffer(); > + buffer->input[0] = 0x1; > + buffer->input[1] = 0x51534554; > + buffer->input[3] = 0x1; > +

Re: [PATCH v3 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131

2016-02-16 Thread Pali Rohár
On Tuesday 16 February 2016 15:50:28 Michał Kępień wrote: > + if (wmi_requires_smbios_request) { > + buffer = dell_smbios_get_buffer(); > + buffer->input[0] = 0x1; > + buffer->input[1] = 0x51534554; > + buffer->input[3] = 0x1; > +

[PATCH v3 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131

2016-02-16 Thread Michał Kępień
On some laptop models (e.g. Dell Vostro V131), WMI events are not generated until a specific SMBIOS request is issued to register an event listener [1]. As there seems to be no ACPI method or SMBIOS request to determine without possible side effects whether a given machine needs to issue this

[PATCH v3 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131

2016-02-16 Thread Michał Kępień
On some laptop models (e.g. Dell Vostro V131), WMI events are not generated until a specific SMBIOS request is issued to register an event listener [1]. As there seems to be no ACPI method or SMBIOS request to determine without possible side effects whether a given machine needs to issue this