Re: [PATCH v3 3/6] xfs, dax: introduce IS_FSDAX()

2018-02-26 Thread Dan Williams
On Mon, Feb 26, 2018 at 2:06 AM, Jan Kara wrote: > On Fri 23-02-18 16:43:27, Dan Williams wrote: >> Given that S_DAX is non-zero in the FS_DAX=n + DEV_DAX=y case, another >> mechanism besides the plain IS_DAX() check to compile out dead >> filesystem-dax code paths. Without

Re: [PATCH v3 3/6] xfs, dax: introduce IS_FSDAX()

2018-02-26 Thread Dan Williams
On Mon, Feb 26, 2018 at 2:06 AM, Jan Kara wrote: > On Fri 23-02-18 16:43:27, Dan Williams wrote: >> Given that S_DAX is non-zero in the FS_DAX=n + DEV_DAX=y case, another >> mechanism besides the plain IS_DAX() check to compile out dead >> filesystem-dax code paths. Without IS_FSDAX() xfs will

Re: [PATCH v3 3/6] xfs, dax: introduce IS_FSDAX()

2018-02-26 Thread Jan Kara
On Fri 23-02-18 16:43:27, Dan Williams wrote: > Given that S_DAX is non-zero in the FS_DAX=n + DEV_DAX=y case, another > mechanism besides the plain IS_DAX() check to compile out dead > filesystem-dax code paths. Without IS_FSDAX() xfs will fail at link time > with: > > ERROR:

Re: [PATCH v3 3/6] xfs, dax: introduce IS_FSDAX()

2018-02-26 Thread Jan Kara
On Fri 23-02-18 16:43:27, Dan Williams wrote: > Given that S_DAX is non-zero in the FS_DAX=n + DEV_DAX=y case, another > mechanism besides the plain IS_DAX() check to compile out dead > filesystem-dax code paths. Without IS_FSDAX() xfs will fail at link time > with: > > ERROR:

[PATCH v3 3/6] xfs, dax: introduce IS_FSDAX()

2018-02-23 Thread Dan Williams
Given that S_DAX is non-zero in the FS_DAX=n + DEV_DAX=y case, another mechanism besides the plain IS_DAX() check to compile out dead filesystem-dax code paths. Without IS_FSDAX() xfs will fail at link time with: ERROR: "dax_finish_sync_fault" [fs/xfs/xfs.ko] undefined! ERROR:

[PATCH v3 3/6] xfs, dax: introduce IS_FSDAX()

2018-02-23 Thread Dan Williams
Given that S_DAX is non-zero in the FS_DAX=n + DEV_DAX=y case, another mechanism besides the plain IS_DAX() check to compile out dead filesystem-dax code paths. Without IS_FSDAX() xfs will fail at link time with: ERROR: "dax_finish_sync_fault" [fs/xfs/xfs.ko] undefined! ERROR: