Re: [PATCH v3 4/6] ARM: dts: exynos: Enable HDMI audio on Snow Chromebook

[Krzysztof Kozlowski]

On Fri, Mar 09, 2018 at 06:22:48PM +0100, Sylwester Nawrocki wrote:
> This patch adds new cpu, codec subnodes according to the updated
> "google,snow-audio-max98095" DT bindings and the I2S clock tree
> configuration so sound on the HDMI interface can also be supported.
> 
> Signed-off-by: Sylwester Nawrocki 
> ---
> Changes since v2:
>  - i2s0/#clock-cells property moved to exynos5250.dtsi
>  - edited commit summary line.
> 
> Changes since v1:
>  - changed order of codec in codec/cpu-dai property
>to match the DT bindings documentation.
> ---
>  arch/arm/boot/dts/exynos5250-snow-common.dtsi | 3 +++
>  arch/arm/boot/dts/exynos5250-snow.dts | 8 
>  arch/arm/boot/dts/exynos5250.dtsi | 1 +
>  3 files changed, 12 insertions(+)
> 

Thanks, applied.

Best regards,
Krzysztof

Re: [PATCH v3 4/6] ARM: dts: exynos: Enable HDMI audio on Snow Chromebook

[Krzysztof Kozlowski]

On Fri, Mar 09, 2018 at 06:22:48PM +0100, Sylwester Nawrocki wrote:
> This patch adds new cpu, codec subnodes according to the updated
> "google,snow-audio-max98095" DT bindings and the I2S clock tree
> configuration so sound on the HDMI interface can also be supported.
> 
> Signed-off-by: Sylwester Nawrocki 
> ---
> Changes since v2:
>  - i2s0/#clock-cells property moved to exynos5250.dtsi
>  - edited commit summary line.
> 
> Changes since v1:
>  - changed order of codec in codec/cpu-dai property
>to match the DT bindings documentation.
> ---
>  arch/arm/boot/dts/exynos5250-snow-common.dtsi | 3 +++
>  arch/arm/boot/dts/exynos5250-snow.dts | 8 
>  arch/arm/boot/dts/exynos5250.dtsi | 1 +
>  3 files changed, 12 insertions(+)
> 

Thanks, applied.

Best regards,
Krzysztof

[PATCH v3 4/6] ARM: dts: exynos: Enable HDMI audio on Snow Chromebook

[Sylwester Nawrocki]

This patch adds new cpu, codec subnodes according to the updated
"google,snow-audio-max98095" DT bindings and the I2S clock tree
configuration so sound on the HDMI interface can also be supported.

Signed-off-by: Sylwester Nawrocki 
---
Changes since v2:
 - i2s0/#clock-cells property moved to exynos5250.dtsi
 - edited commit summary line.

Changes since v1:
 - changed order of codec in codec/cpu-dai property
   to match the DT bindings documentation.
---
 arch/arm/boot/dts/exynos5250-snow-common.dtsi | 3 +++
 arch/arm/boot/dts/exynos5250-snow.dts | 8 
 arch/arm/boot/dts/exynos5250.dtsi | 1 +
 3 files changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250-snow-common.dtsi 
b/arch/arm/boot/dts/exynos5250-snow-common.dtsi
index bdf59dd3654b..fd9226d3b207 100644
--- a/arch/arm/boot/dts/exynos5250-snow-common.dtsi
+++ b/arch/arm/boot/dts/exynos5250-snow-common.dtsi
@@ -9,6 +9,7 @@
 #include 
 #include 
 #include 
+#include 
 #include "exynos5250.dtsi"
 
 / {
@@ -523,6 +524,8 @@
 };
 
  {
+   assigned-clocks = < CLK_I2S_RCLK_SRC>;
+   assigned-clock-parents = <_audss EXYNOS_I2S_BUS>;
status = "okay";
 };
 
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts 
b/arch/arm/boot/dts/exynos5250-snow.dts
index 16e37c337a3f..75fdc5e6d423 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -18,6 +18,14 @@
 
samsung,model = "Snow-I2S-MAX98095";
samsung,audio-codec = <>;
+
+   cpu {
+   sound-dai = < 0>;
+   };
+
+   codec {
+   sound-dai = < 0>, <>;
+   };
};
 };
 
diff --git a/arch/arm/boot/dts/exynos5250.dtsi 
b/arch/arm/boot/dts/exynos5250.dtsi
index 71d2ede118e3..f6c6c94d3d7d 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -500,6 +500,7 @@
pinctrl-names = "default";
pinctrl-0 = <_bus>;
power-domains = <_mau>;
+   #clock-cells = <1>;
};
 
i2s1: i2s@12d6 {
-- 
2.14.2

[PATCH v3 4/6] ARM: dts: exynos: Enable HDMI audio on Snow Chromebook

[Sylwester Nawrocki]

This patch adds new cpu, codec subnodes according to the updated
"google,snow-audio-max98095" DT bindings and the I2S clock tree
configuration so sound on the HDMI interface can also be supported.

Signed-off-by: Sylwester Nawrocki 
---
Changes since v2:
 - i2s0/#clock-cells property moved to exynos5250.dtsi
 - edited commit summary line.

Changes since v1:
 - changed order of codec in codec/cpu-dai property
   to match the DT bindings documentation.
---
 arch/arm/boot/dts/exynos5250-snow-common.dtsi | 3 +++
 arch/arm/boot/dts/exynos5250-snow.dts | 8 
 arch/arm/boot/dts/exynos5250.dtsi | 1 +
 3 files changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250-snow-common.dtsi 
b/arch/arm/boot/dts/exynos5250-snow-common.dtsi
index bdf59dd3654b..fd9226d3b207 100644
--- a/arch/arm/boot/dts/exynos5250-snow-common.dtsi
+++ b/arch/arm/boot/dts/exynos5250-snow-common.dtsi
@@ -9,6 +9,7 @@
 #include 
 #include 
 #include 
+#include 
 #include "exynos5250.dtsi"
 
 / {
@@ -523,6 +524,8 @@
 };
 
  {
+   assigned-clocks = < CLK_I2S_RCLK_SRC>;
+   assigned-clock-parents = <_audss EXYNOS_I2S_BUS>;
status = "okay";
 };
 
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts 
b/arch/arm/boot/dts/exynos5250-snow.dts
index 16e37c337a3f..75fdc5e6d423 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -18,6 +18,14 @@
 
samsung,model = "Snow-I2S-MAX98095";
samsung,audio-codec = <>;
+
+   cpu {
+   sound-dai = < 0>;
+   };
+
+   codec {
+   sound-dai = < 0>, <>;
+   };
};
 };
 
diff --git a/arch/arm/boot/dts/exynos5250.dtsi 
b/arch/arm/boot/dts/exynos5250.dtsi
index 71d2ede118e3..f6c6c94d3d7d 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -500,6 +500,7 @@
pinctrl-names = "default";
pinctrl-0 = <_bus>;
power-domains = <_mau>;
+   #clock-cells = <1>;
};
 
i2s1: i2s@12d6 {
-- 
2.14.2