RE: [PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

2016-12-15 Thread Stuart Yoder
Li > <leoyang...@nxp.com>; Ioana Ciornei <ioana.cior...@nxp.com>; Catalin Horghidan > <catalin.horghi...@nxp.com>; Ruxandra Ioana Radulescu > <ruxandra.radule...@nxp.com>; Roy Pledge > <roy.ple...@nxp.com> > Subject: Re: [PATCH v3 4/9] bus: fsl-mc: dpio: a

RE: [PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

2016-12-15 Thread Stuart Yoder
i ; Catalin Horghidan > ; Ruxandra Ioana Radulescu > ; Roy Pledge > > Subject: Re: [PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and > scatter/gather APIs > > > Some more bits and pieces inside. > > --- > Best Regards, Laurentiu > > On 12/02/2016 12:41 AM,

Re: [PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

2016-12-06 Thread Laurentiu Tudor
On 12/05/2016 10:52 PM, Dan Carpenter wrote: > On Fri, Dec 02, 2016 at 12:12:14PM +, Laurentiu Tudor wrote: >>> +static inline bool dpaa2_sg_is_final(const struct dpaa2_sg_entry *sg) >>> +{ >>> + return !!(le16_to_cpu(sg->format_offset) >> SG_FINAL_FLAG_SHIFT); >> >> In other places in this

Re: [PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

2016-12-06 Thread Laurentiu Tudor
On 12/05/2016 10:52 PM, Dan Carpenter wrote: > On Fri, Dec 02, 2016 at 12:12:14PM +, Laurentiu Tudor wrote: >>> +static inline bool dpaa2_sg_is_final(const struct dpaa2_sg_entry *sg) >>> +{ >>> + return !!(le16_to_cpu(sg->format_offset) >> SG_FINAL_FLAG_SHIFT); >> >> In other places in this

Re: [PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

2016-12-05 Thread Dan Carpenter
On Fri, Dec 02, 2016 at 12:12:14PM +, Laurentiu Tudor wrote: > > +static inline bool dpaa2_sg_is_final(const struct dpaa2_sg_entry *sg) > > +{ > > + return !!(le16_to_cpu(sg->format_offset) >> SG_FINAL_FLAG_SHIFT); > > In other places in this file we don't use the '!!' to convert to bool.

Re: [PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

2016-12-05 Thread Dan Carpenter
On Fri, Dec 02, 2016 at 12:12:14PM +, Laurentiu Tudor wrote: > > +static inline bool dpaa2_sg_is_final(const struct dpaa2_sg_entry *sg) > > +{ > > + return !!(le16_to_cpu(sg->format_offset) >> SG_FINAL_FLAG_SHIFT); > > In other places in this file we don't use the '!!' to convert to bool.

Re: [PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

2016-12-02 Thread Laurentiu Tudor
Some more bits and pieces inside. --- Best Regards, Laurentiu On 12/02/2016 12:41 AM, Stuart Yoder wrote: > From: Roy Pledge > > Add global definitions for DPAA2 frame descriptors and scatter > gather entries. > > Signed-off-by: Roy Pledge >

Re: [PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

2016-12-02 Thread Laurentiu Tudor
Some more bits and pieces inside. --- Best Regards, Laurentiu On 12/02/2016 12:41 AM, Stuart Yoder wrote: > From: Roy Pledge > > Add global definitions for DPAA2 frame descriptors and scatter > gather entries. > > Signed-off-by: Roy Pledge > Signed-off-by: Stuart Yoder > --- > > Notes: >

[PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

2016-12-01 Thread Stuart Yoder
From: Roy Pledge Add global definitions for DPAA2 frame descriptors and scatter gather entries. Signed-off-by: Roy Pledge Signed-off-by: Stuart Yoder --- Notes: -v3 -no changes -v2 -added setter/getter for

[PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

2016-12-01 Thread Stuart Yoder
From: Roy Pledge Add global definitions for DPAA2 frame descriptors and scatter gather entries. Signed-off-by: Roy Pledge Signed-off-by: Stuart Yoder --- Notes: -v3 -no changes -v2 -added setter/getter for the FD ctrl field -corrected comment for SG format_offset