Re: [PATCH v4 09/15] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-04-30 Thread Thierry Reding
On Mon, Apr 09, 2018 at 10:28:31PM +0300, Dmitry Osipenko wrote: > Tegra30+ has some minor differences in registers / bits layout compared > to Tegra20. Let's squash Tegra20 driver into the common tegra-mc driver > in a preparation for the upcoming MC hot reset controls implementation, > avoiding

Re: [PATCH v4 09/15] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-04-30 Thread Thierry Reding
On Mon, Apr 09, 2018 at 10:28:31PM +0300, Dmitry Osipenko wrote: > Tegra30+ has some minor differences in registers / bits layout compared > to Tegra20. Let's squash Tegra20 driver into the common tegra-mc driver > in a preparation for the upcoming MC hot reset controls implementation, > avoiding

Re: [PATCH v4 09/15] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-04-27 Thread Dmitry Osipenko
On 27.04.2018 13:24, Thierry Reding wrote: > On Fri, Apr 27, 2018 at 01:13:47PM +0300, Dmitry Osipenko wrote: >> On 27.04.2018 12:34, Thierry Reding wrote: >>> On Mon, Apr 09, 2018 at 10:28:31PM +0300, Dmitry Osipenko wrote: >>> [...] diff --git a/drivers/memory/tegra/mc.c

Re: [PATCH v4 09/15] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-04-27 Thread Dmitry Osipenko
On 27.04.2018 13:24, Thierry Reding wrote: > On Fri, Apr 27, 2018 at 01:13:47PM +0300, Dmitry Osipenko wrote: >> On 27.04.2018 12:34, Thierry Reding wrote: >>> On Mon, Apr 09, 2018 at 10:28:31PM +0300, Dmitry Osipenko wrote: >>> [...] diff --git a/drivers/memory/tegra/mc.c

Re: [PATCH v4 09/15] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-04-27 Thread Thierry Reding
On Fri, Apr 27, 2018 at 01:13:47PM +0300, Dmitry Osipenko wrote: > On 27.04.2018 12:34, Thierry Reding wrote: > > On Mon, Apr 09, 2018 at 10:28:31PM +0300, Dmitry Osipenko wrote: > > [...] > >> diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c > > [...] > >> +#define

Re: [PATCH v4 09/15] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-04-27 Thread Thierry Reding
On Fri, Apr 27, 2018 at 01:13:47PM +0300, Dmitry Osipenko wrote: > On 27.04.2018 12:34, Thierry Reding wrote: > > On Mon, Apr 09, 2018 at 10:28:31PM +0300, Dmitry Osipenko wrote: > > [...] > >> diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c > > [...] > >> +#define

Re: [PATCH v4 09/15] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-04-27 Thread Dmitry Osipenko
On 27.04.2018 12:34, Thierry Reding wrote: > On Mon, Apr 09, 2018 at 10:28:31PM +0300, Dmitry Osipenko wrote: > [...] >> diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c > [...] >> +#define MC_GART_ERROR_REQ 0x30 >> +#define MC_DECERR_EMEM_OTHERS_STATUS0x58 >>

Re: [PATCH v4 09/15] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-04-27 Thread Dmitry Osipenko
On 27.04.2018 12:34, Thierry Reding wrote: > On Mon, Apr 09, 2018 at 10:28:31PM +0300, Dmitry Osipenko wrote: > [...] >> diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c > [...] >> +#define MC_GART_ERROR_REQ 0x30 >> +#define MC_DECERR_EMEM_OTHERS_STATUS0x58 >>

Re: [PATCH v4 09/15] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-04-27 Thread Thierry Reding
On Mon, Apr 09, 2018 at 10:28:31PM +0300, Dmitry Osipenko wrote: [...] > diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c [...] > +#define MC_GART_ERROR_REQ0x30 > +#define MC_DECERR_EMEM_OTHERS_STATUS 0x58 > +#define MC_SECURITY_VIOLATION_STATUS 0x74 [...] > diff

Re: [PATCH v4 09/15] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-04-27 Thread Thierry Reding
On Mon, Apr 09, 2018 at 10:28:31PM +0300, Dmitry Osipenko wrote: [...] > diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c [...] > +#define MC_GART_ERROR_REQ0x30 > +#define MC_DECERR_EMEM_OTHERS_STATUS 0x58 > +#define MC_SECURITY_VIOLATION_STATUS 0x74 [...] > diff

[PATCH v4 09/15] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-04-09 Thread Dmitry Osipenko
Tegra30+ has some minor differences in registers / bits layout compared to Tegra20. Let's squash Tegra20 driver into the common tegra-mc driver in a preparation for the upcoming MC hot reset controls implementation, avoiding code duplication. Signed-off-by: Dmitry Osipenko ---

[PATCH v4 09/15] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-04-09 Thread Dmitry Osipenko
Tegra30+ has some minor differences in registers / bits layout compared to Tegra20. Let's squash Tegra20 driver into the common tegra-mc driver in a preparation for the upcoming MC hot reset controls implementation, avoiding code duplication. Signed-off-by: Dmitry Osipenko ---