Re: [PATCH v4 11/13] ASoC: arizona-jack: Cleanup logging

2021-01-30 Thread Charles Keepax
On Sat, Jan 23, 2021 at 01:17:18PM +0100, Hans de Goede wrote: > Cleanup the use of dev_foo functions used for logging: > > 1. Many of these are unnecessarily split over multiple lines > 2. Use dev_err_probe() in cases where we might get a -EPROBE_DEFER >return value > > Suggested-by: Andy

Re: [PATCH v4 11/13] ASoC: arizona-jack: Cleanup logging

2021-01-24 Thread Hans de Goede
Hi, On 1/24/21 8:53 PM, Andy Shevchenko wrote: > On Sat, Jan 23, 2021 at 2:17 PM Hans de Goede wrote: >> >> Cleanup the use of dev_foo functions used for logging: >> >> 1. Many of these are unnecessarily split over multiple lines >> 2. Use dev_err_probe() in cases where we might get a

Re: [PATCH v4 11/13] ASoC: arizona-jack: Cleanup logging

2021-01-24 Thread Andy Shevchenko
On Sat, Jan 23, 2021 at 2:17 PM Hans de Goede wrote: > > Cleanup the use of dev_foo functions used for logging: > > 1. Many of these are unnecessarily split over multiple lines > 2. Use dev_err_probe() in cases where we might get a -EPROBE_DEFER >return value ... > if

[PATCH v4 11/13] ASoC: arizona-jack: Cleanup logging

2021-01-23 Thread Hans de Goede
Cleanup the use of dev_foo functions used for logging: 1. Many of these are unnecessarily split over multiple lines 2. Use dev_err_probe() in cases where we might get a -EPROBE_DEFER return value Suggested-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Changes in v4: - While at it