Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard

On Mon, 2018-04-16 at 15:36 +0200, Benjamin Tissoires wrote: > > > > +MODULE_LICENSE("GPL"); > > > > > > The SPDX header says GPL-v2. And IIRC if there is the SPDX header > > > you > > > can drop the MODULE_LICENSE (not entirely sure though). > > > > Ack, will adjust and re-test. > > Actually,

Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard

On Mon, 2018-04-16 at 15:36 +0200, Benjamin Tissoires wrote: > > > > +MODULE_LICENSE("GPL"); > > > > > > The SPDX header says GPL-v2. And IIRC if there is the SPDX header > > > you > > > can drop the MODULE_LICENSE (not entirely sure though). > > > > Ack, will adjust and re-test. > > Actually,

Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard

On Mon, Apr 16, 2018 at 12:14 PM, Robert Munteanu wrote: > Hi Benjamin and Jiri, > > On Mon, 2018-04-16 at 12:02 +0200, Benjamin Tissoires wrote: >> Hi Robert, >> >> On Wed, Apr 11, 2018 at 11:49 AM, Robert Munteanu > > wrote: >> > Changelog: >> > >> > -

Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard

On Mon, Apr 16, 2018 at 12:14 PM, Robert Munteanu wrote: > Hi Benjamin and Jiri, > > On Mon, 2018-04-16 at 12:02 +0200, Benjamin Tissoires wrote: >> Hi Robert, >> >> On Wed, Apr 11, 2018 at 11:49 AM, Robert Munteanu > > wrote: >> > Changelog: >> > >> > - v2: modifier keys work, some combinations

Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard

Hi Benjamin and Jiri, On Mon, 2018-04-16 at 12:02 +0200, Benjamin Tissoires wrote: > Hi Robert, > > On Wed, Apr 11, 2018 at 11:49 AM, Robert Munteanu > wrote: > > Changelog: > > > > - v2: modifier keys work, some combinations are still troublesome > > - v3: style cleanup,

Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard

Hi Benjamin and Jiri, On Mon, 2018-04-16 at 12:02 +0200, Benjamin Tissoires wrote: > Hi Robert, > > On Wed, Apr 11, 2018 at 11:49 AM, Robert Munteanu > wrote: > > Changelog: > > > > - v2: modifier keys work, some combinations are still troublesome > > - v3: style cleanup, rebase on top of 4.14

Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard

Hi Robert, On Wed, Apr 11, 2018 at 11:49 AM, Robert Munteanu wrote: > Changelog: > > - v2: modifier keys work, some combinations are still troublesome > - v3: style cleanup, rebase on top of 4.14 > - v4: remove most debugging calls, make init info useful for user, > rebased

Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard

Hi Robert, On Wed, Apr 11, 2018 at 11:49 AM, Robert Munteanu wrote: > Changelog: > > - v2: modifier keys work, some combinations are still troublesome > - v3: style cleanup, rebase on top of 4.14 > - v4: remove most debugging calls, make init info useful for user, > rebased on top of 4.15 > -

Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard

On Mon, Apr 16, 2018 at 11:49 AM, Jiri Kosina wrote: > On Wed, 11 Apr 2018, Robert Munteanu wrote: > >> Changelog: >> >> - v2: modifier keys work, some combinations are still troublesome >> - v3: style cleanup, rebase on top of 4.14 >> - v4: remove most debugging calls, make

Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard

On Mon, Apr 16, 2018 at 11:49 AM, Jiri Kosina wrote: > On Wed, 11 Apr 2018, Robert Munteanu wrote: > >> Changelog: >> >> - v2: modifier keys work, some combinations are still troublesome >> - v3: style cleanup, rebase on top of 4.14 >> - v4: remove most debugging calls, make init info useful for

Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard

On Wed, 11 Apr 2018, Robert Munteanu wrote: > Changelog: > > - v2: modifier keys work, some combinations are still troublesome > - v3: style cleanup, rebase on top of 4.14 > - v4: remove most debugging calls, make init info useful for user, > rebased on top of 4.15 > - v5: fix the HID

Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard

On Wed, 11 Apr 2018, Robert Munteanu wrote: > Changelog: > > - v2: modifier keys work, some combinations are still troublesome > - v3: style cleanup, rebase on top of 4.14 > - v4: remove most debugging calls, make init info useful for user, > rebased on top of 4.15 > - v5: fix the HID

[PATCH v5] Fix modifier keys for Redragon Asura Keyboard

Changelog: - v2: modifier keys work, some combinations are still troublesome - v3: style cleanup, rebase on top of 4.14 - v4: remove most debugging calls, make init info useful for user, rebased on top of 4.15 - v5: fix the HID descriptor as suggested by Benjamin Tissoires, use existing USB

[PATCH v5] Fix modifier keys for Redragon Asura Keyboard

Changelog: - v2: modifier keys work, some combinations are still troublesome - v3: style cleanup, rebase on top of 4.14 - v4: remove most debugging calls, make init info useful for user, rebased on top of 4.15 - v5: fix the HID descriptor as suggested by Benjamin Tissoires, use existing USB